From: Brandon Guttersohn <brandon@guttersohn.org>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>,
"Kyle Meyer" <kyle@kyleam.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: Possible fix for :includes header argument in org-babel C source blocks
Date: Thu, 28 May 2020 22:37:32 -0500 [thread overview]
Message-ID: <fd8b71c9-04ee-f3d8-5408-7e3aca91b07d@guttersohn.org> (raw)
In-Reply-To: <87blm8v09s.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
Hey Kévin,
Apologies for the regression, and thank you for fixing it. I neglected to run the tests before suggesting that fix -- I'll try not to do that again..
I can at least confirm that the patch wasn't intended to change how C-header-files are specified in the org-babel-block-header. The goal was only to change how the headers are formatted in the generated C-language file during execution, and only for headers which were not wrapped in <>'s. Your fix looks right to me.
On 5/28/20 5:09 AM, Kévin Le Gouguec wrote:
> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> That leads me to believe that the coercion was an unintended side-effect
>> of (format …).
> Never mind, the ORG-NEWS entry for 9.1 shows an example of unquoted
> header, so I guess it is intentional.
>
> Here is a patch to fix the regression:
>
>
> And here is a patch to add a test for the unquoted-single-header case,
> since otherwise it's hard to tell whether this behaviour is intentional:
>
>
> (Is the Org source for the C/C++/D Babel syntax[1] committed somewhere,
> BTW? I could not find it in the Org repo.)
>
>
> I'd like to say that all tests pass now, but I'm getting failures on
> master (even without my changes) for two other tests:
>
>> FAILED ob-tangle/jump-to-org
>> FAILED test-org-attach/dir
>
> [1] https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-C.html
[-- Attachment #2: Type: text/html, Size: 2431 bytes --]
next prev parent reply other threads:[~2020-05-29 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <21b0cd85-d678-2fe6-3c22-e41abc6cf242@guttersohn.org>
[not found] ` <87wo51jo5w.fsf@gnu.org>
2020-05-27 22:20 ` Possible fix for :includes header argument in org-babel C source blocks Kévin Le Gouguec
2020-05-28 2:30 ` Kyle Meyer
2020-05-28 8:25 ` Kévin Le Gouguec
2020-05-28 10:09 ` Kévin Le Gouguec
2020-05-29 2:47 ` Kyle Meyer
2020-05-29 12:41 ` Failing tests (was: Possible fix for :includes header argument in org-babel C source blocks) Kévin Le Gouguec
2020-05-31 4:59 ` Kyle Meyer
2020-06-01 14:48 ` Failing tests Kévin Le Gouguec
2020-06-01 14:56 ` Kévin Le Gouguec
2020-06-03 4:20 ` Kyle Meyer
2020-06-01 13:54 ` Bastien
2020-05-29 3:37 ` Brandon Guttersohn [this message]
2020-05-29 9:57 ` Possible fix for :includes header argument in org-babel C source blocks Kévin Le Gouguec
2020-05-30 17:29 ` Brandon Guttersohn
2020-06-01 13:55 ` Bastien
2020-06-01 20:17 ` Kévin Le Gouguec
2020-06-02 0:02 ` Brandon Guttersohn
2020-05-29 2:45 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8b71c9-04ee-f3d8-5408-7e3aca91b07d@guttersohn.org \
--to=brandon@guttersohn.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).