From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0DZZHQPlF19VQwAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 07:04:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gP1ZGQPlF1/PSwAA1q6Kng (envelope-from ) for ; Wed, 22 Jul 2020 07:04:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C354E9400B1 for ; Wed, 22 Jul 2020 07:04:34 +0000 (UTC) Received: from localhost ([::1]:59818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jy8np-00017D-Kq for larch@yhetil.org; Wed, 22 Jul 2020 03:04:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy8nT-00016o-4j for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 03:04:11 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy8nR-0003vF-1N for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 03:04:10 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8E6E22400FE for ; Wed, 22 Jul 2020 09:04:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1595401442; bh=P6wGGwFwLla+rCUxZOLdkptbDBUKcOJZwr+t7qU0hpk=; h=Subject:To:Cc:From:Date:From; b=cmwSdAy2jm7g1Ffvk7YkfjIHhvl0NEDo5OK8ZKOfMCRGdtxGJSmEY+ihmi0Bysvfp VgJ/vka9G17HX/K9BFs6afj1dsH6Q4oIEsr1knWT8xEZyFahEbtD5QDERmIq7xs+CV lPhBQwZwkaUsG1Klqggkp83hj+qb+22zrnalpeLufw4rV1AAeWUzGWBeNHZ4ed9zRW QmIUgFDSMSRfCMHR/tK7msOLQ/rE3Dc24Pshpj1ZiXpkNkqQsF9UlK3lQ7OmoxTebN LOm+ZDm7e64GqHmZD1GvHTZGlnssFdjm/Qsqn28N9AO5LZquwW2N2QGJNNjB40ejmG oK4/TKbjHsZVg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BBRJx6WGHz9rxY; Wed, 22 Jul 2020 09:04:01 +0200 (CEST) Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command To: Kyle Meyer References: <87imegyy2r.fsf@kyleam.com> From: Clemens Message-ID: Date: Wed, 22 Jul 2020 09:04:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87imegyy2r.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=clemens.radermacher@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 01:21:48 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=cmwSdAy2; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: j57n4UY50ATT > With the built-in completion, org-set-tags-command already supports > completing multiple tags. Interesting, I couldn't figure out how. I tried with emacs -Q (v 26.3) and I get only completion for the first tag. If you try to get completion after entering the first you get an [no match] message. Maybe I'm doing something wrong? How do you get completion after the first tag with default completion? > So that aim reduces to using > completing-read-multiple because other completion libraries are more > likely to play nicely with crm. > > At the moment that's not mentioned in the commit message (and, less > importantly, it wasn't mentioned in the message introducing the patch), > but in my view that aim should be the emphasis of the commit message. > It'd be good to note the popular completion libraries that don't work > out of the box with the current approach, and whether they do after this > patch. As described above my initial aim was really to get completion after entering the first tag (that is mentioned in my message introducing the patch but it is a good idea to mention it also in the commit). Completion frameworks automatically benefit from this if they support `completing-read-multiple`. > It's also probably worth mentioning why org-tags-completion-function is > still passed as the completion function to completing-read-multiple, as > the completion function's main purpose of completing multiple tags could > now be fulfilled by completing-read-multiple alone. And what about the > other spots that use org-tags-completion-function? I haven't looked at `org-tags-completion-function` in detail will have to check if something could be adjusted there, too. I thought usages in other spots wouldn't be affected and should automatically work with the new enhanced behavior. I will look into that, had you something specific in mind? Thanks for your review and help!