From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id gMK6B3WGYGZmxQAAe85BDQ:P1 (envelope-from ) for ; Wed, 05 Jun 2024 17:38:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id gMK6B3WGYGZmxQAAe85BDQ (envelope-from ) for ; Wed, 05 Jun 2024 17:38:29 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=UsalZbj2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717601909; a=rsa-sha256; cv=none; b=ra7RGie92doNqrxgbHlEkEQFX2aGZEoRFZ+DPI8P9ngqZ4c85Jw9TK8nZpJ0vY7Ehcn8+R eFmt3G5FHs8W3VSQKp2dfxrB4garAwwy8cDRzCsuZh5O+KntP53nN+WpuD62W1ogZCg9F7 OSWGEHIygCnOkM5JxXlfE17GtsXkR1zhEunT5fIRDZ9ax/c0uK6mkSaqjvfyzQH6LWdL5+ hoaB1VOWQQj/4QcF8AqSWrA/T9ekPUAfoXUCs4dSRm6wKzfGj6v9qALd6g6JG/RtrTExPa wFDQUYsK2V71Ft7Dn74SxQ9vp3MwOXjUcP/CzZZ8eK2O/g7kV8+tz+uRfMWhUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=UsalZbj2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717601909; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Pz920q/TTKD4DojG0/+6eQFmBBpxSYY/VW50oMH3dS0=; b=SH9yVsQ5qDMcwACIxxMULMWMn+ZZ/qo3VvRxyk9nyR94hnFtYUt1z2vuDYPaa+PKqS969S CDtq9I1xF/TpBrSOsacz6DAkJrPh4LZGxfvbbGOzIP3cJOJW0DoaC6VW6gy7mj3JGMPOZP 1nVk51KQA1yJAh8SnN30LphuhUxHux+SBUzAM3y3DnaBeZB6vF6AEf8TXLby93m1hMailJ zdTZnRd2VmZh4lUbGy/0ctM/iwNDzceUEQLyl7hffZv7X/ImXeptMZYwK0RWmj4oAmHbQ4 JJz7Ba8RooXb59p8tcUGjWcH+OUhhvRmrgX8YgQcfWtK/MN0lf8yU4lU4qs3AQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9862411BB2 for ; Wed, 5 Jun 2024 17:38:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEshb-0005yB-8O; Wed, 05 Jun 2024 11:37:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEshX-0005xH-4f for emacs-orgmode@gnu.org; Wed, 05 Jun 2024 11:37:24 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEshQ-0002BO-Nn for emacs-orgmode@gnu.org; Wed, 05 Jun 2024 11:37:22 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-52b7e693b8aso1025208e87.1 for ; Wed, 05 Jun 2024 08:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717601823; x=1718206623; darn=gnu.org; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=Pz920q/TTKD4DojG0/+6eQFmBBpxSYY/VW50oMH3dS0=; b=UsalZbj2+YZUc2lEhsEh0t95kQLYX2dKtkUI5vU2mqUcC6QFnorxuHj/WyLLfjOmuR 3g0IQ++xWFaIXQLODD7zmmY5jLFviBy93PgZcC4MC/FeSY3VdmyucyOZZqH5ayy0PsGg +z7eV8LtDmDrZYB6aVUAqU9gKcPU7yYQZtvPrUXuwsUVrHuY9r3OaX/xgC26hVljgUrI e3dnhKKIE9qrAQCZ4HSpcJfq+GWir2Fr8jov4A1INHToNW6daDpPliSqOGpQ9LZsmZ5K blV0ngkN8DoYz/F9EpWkowGd+wb6KbAqiQG5OplnBN5Pxoc6m/hw+wbEtmEsa+qtbdxF Ip/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717601823; x=1718206623; h=content-transfer-encoding:in-reply-to:mail-followup-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pz920q/TTKD4DojG0/+6eQFmBBpxSYY/VW50oMH3dS0=; b=EkjkzsadxiboI+SVBNspy5oPKRxgbb43fnfmkiGk0d3+BAvIpgqE/XlPhXkFpDMXvX 8vYwH782/f1kjL3ttD1STDLV/EgPk+T3KRZ281Ib+2GiCzICFI5NQKTQDtwb1H3dewgx hdIUEMWTlYwjVlZV+ivePGVTvSMpS/np+mJtqbMWxp9omFk4+2cKw0w6jGBaSVC+6/jT skxFg7g7Ddk/imSouiyu9V/3K/8pJG0fCzKacan3aD5LK18spHqCC8QecDr/P8tYOGQW rvPb12YBr2a6Rlxd1a3ZOOpBnMH+PQbvdQhryLTgbFzTyo89RzbkS9W+59ojshuhn3cK 1fVg== X-Forwarded-Encrypted: i=1; AJvYcCVcLtoQV5YJOJyMOTKBIuLaV1+jnlVh69TqaFFXE47ABv8/jf1CLkDrlhChgNJLcLLFHoiClKMjuNADXgtouF5kTuPWSnk= X-Gm-Message-State: AOJu0YyWstfUQthYBgdVvmug9fwxjtQy5Q2re4DqvUrzrQ9cN7Ata4PL M468gFwIn09DyJcXuDe+7AP6mnKJJUWoPdYtTYXNW+8iL1WeU6BHMJ+soA== X-Google-Smtp-Source: AGHT+IGyO9Ty4BfdF8WGJOsk2LKVtI2lh87tyAunfhoEPZRInqNRwpiMeoruP3GprzOdlnP9eeRzoQ== X-Received: by 2002:a05:6512:49c:b0:52b:90ba:f0e4 with SMTP id 2adb3069b0e04-52bb21863fbmr6004e87.12.1717601822701; Wed, 05 Jun 2024 08:37:02 -0700 (PDT) Received: from [192.168.0.102] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-52b99359d87sm997439e87.277.2024.06.05.08.37.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 08:37:02 -0700 (PDT) Message-ID: Date: Wed, 5 Jun 2024 22:37:00 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add support for shortdoc link type To: Bruno Cardoso , emacs-orgmode@gnu.org References: <87zftatdkr.fsf@gmail.com> <87v83xer0d.fsf@localhost> <87wmodtqxt.fsf@gmail.com> <875xvxs9hi.fsf@localhost> <87ttjhtjx1.fsf@gmail.com> <4b69d3b8-cfe7-4ba2-b9b5-872bcaeb6fe6@gmail.com> <87v83uefpd.fsf@gmail.com> <87h6fdeb3i.fsf@gmail.com> <9f6bbe0f-7cc2-4d55-a77d-331c8f71bb2c@gmail.com> <87y18ondrt.fsf@gmail.com> <938098de-6933-4668-85b0-fbfbc02dd949@gmail.com> <87v83pnm56.fsf@gmail.com> <87seysnggb.fsf@gmail.com> <87ttj4i8u6.fsf@gmail.com> <7ef51938-600d-40cf-bf93-d32b86d77f9d@gmail.com> <87eda5yib3.fsf@gmail.com> Content-Language: en-US, ru-RU From: Max Nikulin Mail-Followup-To: Bruno Cardoso , emacs-orgmode@gnu.org In-Reply-To: <87eda5yib3.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=manikulin@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 9862411BB2 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 2.67 X-Spam-Score: 2.67 X-TUID: lRQyTJ+rgMVV On 13/05/2024 20:04, Bruno Cardoso wrote: > +++ b/etc/ORG-NEWS Bruno, I am sorry, but Org-9.7 has been released and your patch can not be cleanly applied any more. Please, rebase it and check that the new feature is described in the proper section for changes that have not released yet. A couple of notes that unlikely affect real life usage. > + (defun org-link--store-shortdoc (&optional _interactive?) > + "Store \"shortdoc\" type link." > + (when (eq major-mode 'shortdoc-mode) `derived-mode-p' is more reliable in general. > + (let* ((buffer (buffer-name)) > + (group (when (string-match "*Shortdoc \\(.*\\)\\*" buffer) > + (match-string 1 buffer)))) > + (if (and group (assoc (intern-soft group) shortdoc--groups)) > + (org-link-store-props :type "shortdoc" > + :link (format "shortdoc:%s" group) > + :description nil) > + (user-error "Unknown shortdoc group: %s" group))))) I believed that store link functions should fail silently if no suitable link may be offered.