From: Timothy <orgmode@tec.tecosaur.net>
To: "Roshan Shariff" <roshan.shariff@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Fix background color of latex previews
Date: Mon, 08 Jan 2024 18:24:21 +0800 [thread overview]
Message-ID: <e3ec5dc8-fc38-4729-9028-a3dc1c00fe4a@app.fastmail.com> (raw)
In-Reply-To: <CAG8iPGxoAD7qmKzDXQ_SRFbmxD7jdM96piCa-dCSCpzae4rCsw@mail.gmail.com>
Hi Roshin,
> Thanks again for your work on this exciting feature! I tried out your
> new code and it does indeed fix the problem on Emacs 29. But then I
> remembered that I originally encountered the issue on Emacs 28, and
> sure enough the issue persists there.
>
> To summarize, to get it to look right on Emacs 28, you need to append
> the face spec '(:inherit default :extend t) to the list of faces,
> rather than just 'default. Otherwise, when an equation overlay wraps
> to the next line in visual-line-mode, you'll see the background color
> of the org-block face leak through after the end-of-line. Emacs 29
> appears to behave more sensibly: if the overlay wraps to the next
> line, its face is not applied to the end of the current line.
Thanks for this info and the patch! I've had a look at both, and I'm hopeful that https://git.tecosaur.net/tec/org-mode/commit/3b3d48d3bf0 might solve the problem? Do let me know what your think 🙂
All the best,
Timothy
--
Timothy (‘tecosaur’/‘TEC’), Org mode contributor.
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/tec>.
next prev parent reply other threads:[~2024-01-08 10:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 12:23 [Pre-PATCH] Overhaul of the LaTeX preview system Timothy
2023-03-13 12:26 ` Ihor Radchenko
2023-03-14 16:04 ` Timothy
2023-03-15 9:34 ` Ihor Radchenko
2023-03-15 17:28 ` Rudolf Adamkovič
2023-03-13 12:30 ` Ihor Radchenko
2023-03-13 12:32 ` Ihor Radchenko
2023-03-14 14:46 ` Timothy
2023-03-13 12:36 ` Ihor Radchenko
2023-03-14 16:10 ` Timothy
2023-03-15 9:38 ` Ihor Radchenko
2023-03-13 12:37 ` Ihor Radchenko
2023-03-14 16:13 ` Timothy
2023-03-25 15:29 ` Tony Zorman
2023-05-02 12:15 ` K. Chousos
2023-05-03 10:07 ` K. Chousos
2023-05-05 17:57 ` Karthik Chikmagalur
2023-05-05 18:48 ` Konstantinos Chousos
2023-05-05 18:53 ` Konstantinos Chousos
2023-05-05 20:05 ` Karthik Chikmagalur
2023-05-05 21:06 ` Konstantinos Chousos
2023-05-05 22:58 ` Karthik Chikmagalur
2023-05-06 9:19 ` Konstantinos Chousos
2023-05-06 9:30 ` Ihor Radchenko
2023-05-06 10:08 ` Konstantinos Chousos
2023-05-08 20:04 ` Karthik Chikmagalur
2023-05-08 20:40 ` Konstantinos Chousos
2023-05-09 11:34 ` Ihor Radchenko
2023-05-09 12:03 ` Timothy
2023-05-09 12:10 ` Ruijie Yu via General discussions about Org-mode.
2023-05-09 12:12 ` Ihor Radchenko
2023-05-09 12:10 ` Timothy
2023-05-09 12:49 ` Max Nikulin
2023-05-09 12:57 ` Ihor Radchenko
2023-05-10 10:07 ` Jun Inoue
2023-05-10 10:21 ` Timothy
2023-05-10 13:09 ` Jun Inoue
2023-05-26 9:50 ` Rudolf Adamkovič
2023-05-28 17:31 ` Timothy
2023-06-03 9:00 ` Rudolf Adamkovič
2023-08-21 8:59 ` Visuwesh
2023-08-21 16:40 ` Karthik Chikmagalur
2023-08-21 17:19 ` Visuwesh
2023-08-21 21:40 ` Karthik Chikmagalur
2023-08-22 2:57 ` Visuwesh
2024-05-30 8:28 ` Visuwesh
2024-10-15 18:44 ` Ihor Radchenko
2024-10-16 5:58 ` Visuwesh
2023-08-29 6:01 ` Roshan Shariff
2023-08-29 6:01 ` [PATCH 1/1] Fix background color when line-wrapping latex previews Roshan Shariff
2023-08-29 17:14 ` [PATCH v2] Fix background color of " Roshan Shariff
2024-01-07 7:25 ` Timothy
2024-01-07 9:50 ` Roshan Shariff
2024-01-08 10:24 ` Timothy [this message]
2024-01-09 20:12 ` Roshan Shariff
2024-01-07 7:28 ` [Pre-PATCH] Overhaul of the LaTeX preview system Timothy
2024-01-20 5:53 ` Matt Huszagh
2024-01-20 6:02 ` Matt Huszagh
2024-01-20 7:13 ` Matt Huszagh
2024-01-21 17:08 ` Timothy
2024-04-22 11:08 ` Feedback on the new "feature" system in org-export (was: [Pre-PATCH] Overhaul of the LaTeX preview system) Ihor Radchenko
2024-07-21 12:41 ` [Pre-PATCH] Overhaul of the LaTeX preview system Jun Inoue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ec5dc8-fc38-4729-9028-a3dc1c00fe4a@app.fastmail.com \
--to=orgmode@tec.tecosaur.net \
--cc=emacs-orgmode@gnu.org \
--cc=roshan.shariff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).