emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: "Yu Shen (MCBU)" <yushen@utstar.com>
Cc: emacs-orgmode@gnu.org, yubrshen@gmail.com
Subject: Re: A bug of org-freemind.el in org-mode package 3.34c
Date: Tue, 26 Jan 2010 23:50:07 +0100	[thread overview]
Message-ID: <e01d8a51001261450l7830cedboc1c9b92c46846a@mail.gmail.com> (raw)
In-Reply-To: <49DFAE0B9FAF3E4E9BCFC07862B1D46801868048@ITLHZEXCH01.us.utstar.com>

[-- Attachment #1: Type: text/plain, Size: 2250 bytes --]

On Tue, Jan 26, 2010 at 11:31 PM, Yu Shen (MCBU) <yushen@utstar.com> wrote:
> It seems in the function of org-freemind-write-mm-buffer, in the following
> code segment, the treatment of sub-node level may have some problem. If the
> level is one level more than its parent’s level, the function will abort,
> abandoning the expert. I’d wish that it would be more robust to do the
> export regardless the unusual level number, and just give clearer warning.
>
>
>
>
>
> (when (> next-level current-level)
>
>                   (if (not (and org-odd-levels-only
>
>                                 (/= (mod current-level 2) 0)
>
>                                 (= next-level (+ 2 current-level))))
>
>                       (setq skipping-odd nil)
>
>                     (setq skipping-odd t)
>
>                     (setq skipped-odd (1+ skipped-odd)))
>
>                   (unless (or (= next-level (1+ current-level))
>
>                               skipping-odd)
>
>                     (if (or org-odd-levels-only
>
>                             (/= next-level (+ 2 current-level)))
>
>                         (error "Next level step > +1 for node ending at line
> %s" (line-number-at-pos))
>
>                       (error "Next level step = +2 for node ending at line
> %s, forgot org-odd-levels-only?"
>
>                              (line-number-at-pos)))
>
>                     ))
>
>
>
> Attached is an example to demonstrate the problem.
>
>
>
> I’d like to know the author’s (Lennart Borgman) intension before I attempt
> to modify it.


Hi Yu,

My intention was just to help the user find errors. If the subnode
level is not just node level+1 then I expect that there is some
trouble with the org file (if not org-odd-levels-only).

If you think it is useful with bigger level steps then perhaps you
could make the check optional with a defcustom?

Kind regards,
L


> Yu Shen
>
> yubrshen@gmail.com

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      reply	other threads:[~2010-01-26 22:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 22:31 A bug of org-freemind.el in org-mode package 3.34c Yu Shen (MCBU)
2010-01-26 22:50 ` Lennart Borgman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01d8a51001261450l7830cedboc1c9b92c46846a@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yubrshen@gmail.com \
    --cc=yushen@utstar.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).