From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CPygLe/nF1+ZYwAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 07:17:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oIuWKe/nF1+TDAAAB5/wlQ (envelope-from ) for ; Wed, 22 Jul 2020 07:17:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 409F794051F for ; Wed, 22 Jul 2020 07:17:03 +0000 (UTC) Received: from localhost ([::1]:44578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jy8zs-0007EZ-R0 for larch@yhetil.org; Wed, 22 Jul 2020 03:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy8zX-0007EP-Km for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 03:16:39 -0400 Received: from mout02.posteo.de ([185.67.36.66]:60021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy8zV-0005i0-Fj for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 03:16:39 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 273022400FD for ; Wed, 22 Jul 2020 09:16:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1595402194; bh=/ygSbmZdlUiGNHQDGr3UALJzvYZQp91lVf6VEYf2XgA=; h=Subject:To:Cc:From:Date:From; b=W/kfkWlShfViVLip7hNEP/8HTs7nCGaD7JiOYHR2MqWk7c/q36n1Xp2vKBk3ItZ3/ UPasxzxMFmxMA5JXTAENvBZhbmJmOaxiE3cJNgimLFkU6jNt1up1f9ckunKXmjZkVm +ZCzzCQTDxy7Ysg4v+ani0wH6ZfywdG52Xnait/Z2Jp2866QcafJq6gNLzC7fwlcix 4VD4vIDXRhS1BITdJGBvqEBl5JlCsWTQJV3ewtXVzpSkziuwpQPzZ0063Iwlc86d3s C2GPIJNrRz2HjlSoOT6sOUeoevqidFTGugT37485HHKc348JwlLjjt9eu0XWy5USPB KgjLCEKM2K//A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BBRbP43dWz9rxM; Wed, 22 Jul 2020 09:16:33 +0200 (CEST) Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command To: Kyle Meyer References: <87imegyy2r.fsf@kyleam.com> From: Clemens Message-ID: Date: Wed, 22 Jul 2020 09:16:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87imegyy2r.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=clemens.radermacher@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 01:21:48 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=W/kfkWlS; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: SEcLAAthV1oM Sorry, I just figured out you get indeed completion after the first tag my sandbox wasn't clean (usually that shouldn't affect the completion behavior but somehow it did, I have to check why). In this case your are also right that `org-tags-completion-function` need to be adjusted. My patch still is useful to make frameworks which support `completing-read-multiple` automatically work though while the current approach is tightly integrated with the default completion. I will do some more work and report back.