From: Carsten Dominik <dominik@science.uva.nl>
To: Aaron Kaplan <lists2546@aaronkaplan.info>
Cc: emacs-orgmode@gnu.org
Subject: Re: noutline bug
Date: Mon, 4 Jun 2007 20:16:27 +0200 [thread overview]
Message-ID: <dc15bf47828eeec33ab4eaa069e09b0e@science.uva.nl> (raw)
In-Reply-To: <1180978469.26286.1193361613@webmail.messagingengine.com>
Hi Aaron,
thank you very much, I have applied the patch.
- Carsten
On Jun 4, 2007, at 19:34, Aaron Kaplan wrote:
> A bug in xemacs/noutline.el was brought to the surface by a couple of
> recent org-mode changes. Here are some test cases:
>
> -------snip-----------------
> * Heading 1
> note
>
>
> * Heading 2
> ** subheading
> -------snip-----------------
>
> If org-cycle-separator-lines is 2 then doing org-cycle on Heading 1
> fails to fold it, and if subheading is followed by the end of the file
> then org-cycle on Heading 2 fails to fold it as well. These two
> problems surfaced because of two different org-mode changes, but I
> traced both problems back to the same misplaced parenthesis in
> noutline.el:
>
> *** noutline.el 2007/06/04 17:03:41 1.1
> --- noutline.el 2007/06/04 17:22:18
> ***************
> *** 724,733 ****
> (set-extent-endpoints (copy-extent ex)
> (extent-start-position ex) beg)
> (set-extent-endpoints ex end (extent-end-position ex)))
> ! (set-extent-endpoints ex (extent-start-position ex)
> beg)))
> (if (> (extent-end-position ex) end)
> (set-extent-endpoints ex end (extent-end-position ex))
> ! (delete-extent ex)))
> (current-buffer) beg end nil 'end-closed 'outline)))
>
> (defun outline-flag-region (from to flag)
> --- 724,733 ----
> (set-extent-endpoints (copy-extent ex)
> (extent-start-position ex) beg)
> (set-extent-endpoints ex end (extent-end-position ex)))
> ! (set-extent-endpoints ex (extent-start-position ex) beg))
> (if (> (extent-end-position ex) end)
> (set-extent-endpoints ex end (extent-end-position ex))
> ! (delete-extent ex))))
> (current-buffer) beg end nil 'end-closed 'outline)))
>
> (defun outline-flag-region (from to flag)
>
>
> You might want to do a bit of reindenting while you're in there, it
> looks like this file has been edited by people with different tab
> widths
> at different times.
>
> -Aaron
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477
prev parent reply other threads:[~2007-06-04 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 17:34 noutline bug Aaron Kaplan
2007-06-04 18:16 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc15bf47828eeec33ab4eaa069e09b0e@science.uva.nl \
--to=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=lists2546@aaronkaplan.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).