From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cNuQKMfkU18wJQAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 19:19:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4AdnJMfkU19IcgAAbx9fmQ (envelope-from ) for ; Sat, 05 Sep 2020 19:19:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2748F9404C2 for ; Sat, 5 Sep 2020 19:19:35 +0000 (UTC) Received: from localhost ([::1]:58098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEdio-0002Xj-6H for larch@yhetil.org; Sat, 05 Sep 2020 15:19:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEdiQ-0002XY-QN for emacs-orgmode@gnu.org; Sat, 05 Sep 2020 15:19:11 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:38107) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEdiO-0003D0-O6 for emacs-orgmode@gnu.org; Sat, 05 Sep 2020 15:19:10 -0400 Received: by mail-pg1-x533.google.com with SMTP id l191so6045140pgd.5 for ; Sat, 05 Sep 2020 12:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:subject:mime-version; bh=zYrIoOJJ9t3yvO+CVGf7PpfZZuANQnB/nSH7dWMj9Yw=; b=lHmKBtyEHLXkEP2M6SLw96H1q90RSXEl2O71RkSx01Qg7RgIFd9caCYyHpyZG8+vHt uiE3jBuMTw4lgnWUmVbFGYFXNmiVAddeDBjB8n+TL3xOXPde2OLirQQ/leqaGIO921k3 cA3EmT/LzbfVHSsO0pLxhnPAGCCgZP4WItysRSHhMnbZ/VW/woImdRAUYyE3h6JVLYDj p8xYay9N+7MOMAYd4KghyrOeEMboe27Q1JYJaWeHeWfhbDtj2PajWCmxB4zaPOC4AtTX KyAvDwbOEtD4iyVU/s0Hh6x5LDgN15OzhMynVCIY6c/Q8eLOR3805H0CxNUGKao+8UgU +JQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:subject:mime-version; bh=zYrIoOJJ9t3yvO+CVGf7PpfZZuANQnB/nSH7dWMj9Yw=; b=nCDP7tjPOM51Oi+D4OLdrYQe0Q+uwpfn+swPAYWKqmoEQe+ecUtIz3BcKapfap8qUk jURR1X8lJkuUF2YHaDw2P6ytc8huySsu+HyXscNfzQas7CUDwgWVSwHokeaLF9elKNeL rbQ4Fbng0b2K9ep5KW/I24T877RRewmTFiy1I27Y42Y2tKHpjtZBfEXEeXyMMCpZg3Rt UIYXPJo/ZY6wXcrYTderWmIaz7OGHNp+3u9KXknc7m4gNugCP4vEoBdLuULzYkW9ifSw i1gdlLPscG0pUVW7CnamgNVYHARoAjC0zUfAoB/m3iPTYR8jUl/rBZ/xMelgqqS3DQtp fMTQ== X-Gm-Message-State: AOAM531bPFeyqMX2J3w6EzWA1/jwR9A5bvF/j1VLEasiZL9fm7dRR3qN 9w+0pQobUl0JHDW4RSQUt7YLmCx/1nF17g== X-Google-Smtp-Source: ABdhPJxUVv+T6IntbFKLL2HYBeQRkssn1wLyPGAKigfsQSjZbz9AprzVeP3HHMNz4s2mRK11Q85DvA== X-Received: by 2002:a63:c948:: with SMTP id y8mr12012363pgg.164.1599333547014; Sat, 05 Sep 2020 12:19:07 -0700 (PDT) Received: from [2600:1012:b16f:5aff:f0f9:6e80:200:0] ([2600:1012:b16f:5aff:7030:82ee:591e:3bb3]) by smtp.gmail.com with ESMTPSA id h7sm338627pgc.58.2020.09.05.12.19.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Sep 2020 12:19:06 -0700 (PDT) Date: Sat, 5 Sep 2020 12:19:04 -0700 From: Huszaghmatt To: Kyle Meyer Message-ID: Subject: [PATCH] Omit file description when :file-desc has nil value MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="5f53e4a8_643c9869_106" Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=huszaghmatt@gmail.com; helo=mail-pg1-x533.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs-Orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=lHmKBtyE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: 5nFhHIGoX9p2 --5f53e4a8_643c9869_106 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Kyle Meyer writes: > A use case was given in the initial patch: > . > The test for this behavior mentioned there is > test-ob/file-desc-header-argument. > > That thread links to another thread by gmane ID. That's this one: > https://orgmode.org/list/87limm4eo2.fsf@med.uni-goettingen.de/T/#u Thanks for the reply, Kyle, and thanks for pointing me to that thread. I understand that this would break existing functionality, but I think my solution makes more sense. For one, I think that the current implementation is a bit confusing. More importantly though, it makes it impossible to both provide a default value for :file-desc and omit it in some cases. The benefit (as mentioned in that thread) is that in those select cases, the same argument would not need to be provided twice. I think the cost of the current functionality outweighs the benefit. What are your t houghts? I've got a pending patch (https://lists.gnu.org/archive/html/emacs-orgmode/2020-09/msg00041.html) that allows a user to provide lambdas as default header arguments (evaluated during source block execution or export). This makes the use of defaults much more attractive in my mind because they can provide context aware values. Similarly, it increases the cost of the current implementation because then this facility cannot be used for :file-desc. I guess there are other solutions we could explore, such as an empty string (is an empty file descriptor ever a valid use case?) taking the place of the current functionality, or fully eliminating the file descriptor. However, this is starting to feel like a lot of hacks and would be very confusing to new users. Moreover, it really just pushes the problem down the road rather than fixing it outright. > Right, to reflect the current behavior established as a result of the > above thread, I think that should be reworded to distinguis h between an > absent :file-desc header and one with no argument. Sorry for not > catching that when reviewing your initial patch. No worries, and I agree the documentation should be updated. I'm happy to provide the patch myself, but I'd like to talk through whether the current implementation is the correct one before I do. Best Matt --5f53e4a8_643c9869_106 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
--5f53e4a8_643c9869_106--