From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ePmTIvUx+mPSrAAAbAwnHQ (envelope-from ) for ; Sat, 25 Feb 2023 17:06:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KOilIfUx+mOWWgEAG6o9tA (envelope-from ) for ; Sat, 25 Feb 2023 17:06:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5456F3E7CF for ; Sat, 25 Feb 2023 17:06:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVx30-0002Sk-KM; Sat, 25 Feb 2023 11:05:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVx2z-0002SU-8J for emacs-orgmode@gnu.org; Sat, 25 Feb 2023 11:05:17 -0500 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVx2w-0007WF-BX for emacs-orgmode@gnu.org; Sat, 25 Feb 2023 11:05:16 -0500 Received: by mail-lj1-x22c.google.com with SMTP id t14so2114488ljd.5 for ; Sat, 25 Feb 2023 08:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=/oBtwlLPyiiTmuvbDDVBBtueKIT75glXF1LmY26nQUg=; b=TKbM6Biyj9QOA/tezpGRflYmOT7VtZwAXuUVIwj1aiGbZqgr07Vg+s0I0zP7Pya7/g WC8hGLdEs7Ik4f+SIuX1bx79V2hL2Ybx3X4Z7t5QN11H+M5AAVKL6A27NgtpvBtZrf+r TXxBj76DpJIxAVvMCT3VmDGiFMbdAhDSpYYvFaaIviCG0BVgS7GPLf4TS+mF0z63kEew 5OpDSyzpjRogSpMjp2Pim4uLXLBBEAREdqzTWAnLgSst+v3OyPDLYOY2shEUohJB6p6V mGjvQogahR/nRso2dK/bn5aPvSU4gViiiNgxG8Tw2RjjoLddkjXVuq0XVglMFSSvCNUK 86Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/oBtwlLPyiiTmuvbDDVBBtueKIT75glXF1LmY26nQUg=; b=QFvVrHsLtnL4hw/QgtVIlNdbWizwZJyQ6sKVh0yMKgXPGpHG9JooSdaZy2OvouSyvU Y9HKzgMTnINT2ALseYYGeIpYcNV9lzLJ7ohcTXAghdSwePOXrl30eFAVnxMB+7wmsPfx cnEhMpJ3VkHOPgZ4h3mPP99agtXHslR49GOASO2Rtfpuu/vBpDpyQ+n7pKowrXbHuJXy bX16ny9g/LIN9j2/AsT+7WFhybNhnKAN9UgaujPEmktW5YvVppIHX1TxlkkPFqNJtqz6 UYhx6btXC6IecVm7clgbDTRsrtYyIsOdEIQl5KdGA5DWGDU16yMI7zAqtFfm4ybtvIDq 1lfg== X-Gm-Message-State: AO0yUKXZlPCr2ZtfRT3LQ4V2FR72t4me6XK5ZddwFFbK/c91MiNow8wS EtJiYSL/H96492uPWB4gg0o= X-Google-Smtp-Source: AK7set+e8deBatjGdoKIggdM+ZeVuPnfed7WBcxwxMrgRQ8tKWQ6UG5UeZXYigHCDCFuAqmfO+Tjfw== X-Received: by 2002:a05:651c:1a0b:b0:295:9c2e:72ed with SMTP id by11-20020a05651c1a0b00b002959c2e72edmr4834428ljb.50.1677341111891; Sat, 25 Feb 2023 08:05:11 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id k8-20020a05651c10a800b00295a7f35206sm207742ljn.48.2023.02.25.08.05.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 08:05:11 -0800 (PST) Message-ID: Date: Sat, 25 Feb 2023 23:05:09 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] lisp/ob-screen.el: Support ~:var~ header args for babel blocks Content-Language: en-US To: Ken Mankoff Cc: emacs-orgmode@gnu.org References: <87pm9z8089.fsf@t480.home> <87y1om7w23.fsf@t480.home> <96a91a35-eeb6-55d3-683d-5d51ff6d496e@gmail.com> <877cw5aiab.fsf@t480.home> From: Max Nikulin In-Reply-To: <877cw5aiab.fsf@t480.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=manikulin@gmail.com; helo=mail-lj1-x22c.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677341173; a=rsa-sha256; cv=none; b=JPU5U5nLFi1jp26cd6LsH14ZIDB5YyVwivYJ5u5fv3Pwb9ZxkLUqM+L85X5q2eY5WJsC8Z 9hpPhoplG8kvKkR33IHlufniPNdPqMNdATB6vUFTIR1kuE6jdjXzWyKDwCzclBGz/TJO+1 R41eiQFYYVgLB95D/eygVfU7N6L2FKtr42DIM5dGFFZqzabQmOwvsZgnXEj3xi9ey4TLNb 25QU0wnqBJ/t7q/J8hBj8eD++rAFMH60LlAa4r7LgJr2WBtpiYu8c3KGdVNtW/1no3LrSk J06wGAg0qOm+kWSB/qZdZe0xzT1isc8HF/5+mTK/c3IQSdpAw+C+wStf/CMRCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TKbM6Biy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677341173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/oBtwlLPyiiTmuvbDDVBBtueKIT75glXF1LmY26nQUg=; b=EZMWoNgwiyCeFxS1/LyjYUaUymczCPqaqzR1Wh4SQ/dx3FEiqU7kqM8hfTxcZ6umYvhfcF sQeZozDbgftpTOKusa4YQEVp93g/rhkeO+R/lyKfLuINssjM8vue7+R7NAhRVgcPsdw3sF IQMdg/asu4iwC5DoNRCPnISAcRUMwuOJdI/9ouJzszGbf34tmUCc4GAOPEhtOEfXu8662+ BprFbO1MtNZHZota+quB61/VNbyaH8vAmqF1t3GIJh0ANb1mN93GgXzfF7FU/82vBcgz0k 798NlUiRC9DxGUzDihMBasAmXFeZa3YIt6jiNcZS8Vt2eniKb5MCh6r5GLn4gA== X-Migadu-Spam-Score: 6.78 X-Spam-Score: 6.78 X-Migadu-Queue-Id: 5456F3E7CF Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TKbM6Biy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: Pnb3q79Axm3h On 25/02/2023 22:14, Ken Mankoff wrote: > On 2023-02-24 at 19:51 -08, Max Nikulin wrote: >> The code still depends on on ob-shell. Is there a reason why calling >> `org-babel-variable-assignments:shell' is a worse variant than copy of >> the whole function body? > > I didn't realize that was a dependency. I now use that function. This > also means that arrays/tables/etc. are all supported by :var, although > not in the default screen ":cmd sh" because sh doesn't support > "declare", but it works with ":cmd bash". > + (var-lines (org-babel-variable-assignments:shell params)) > (socket (org-babel-screen-session-socketname session))) I believe, it is safer to define `org-babel-variable-assignments:screen' some way: alias, substitution, function that calls `org-babel-variable-assignments:shell'. I am unsure which variant is better. I see a couple of callers for specific language in ob-core.el. I can not suggest anything specific concerning sh vs. bash. I have never tried to pass tables to sh src blocks.