emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve org-mouse support for checkboxes
Date: Sat, 18 Sep 2021 15:47:24 -0700	[thread overview]
Message-ID: <d4ecf4c7-c5e6-ceeb-63a8-f8750b735557@gmail.com> (raw)
In-Reply-To: <CAJcAo8svZKZat6cYgWBNz9j1RN+6rfRJtH1t1m3U+_dy+P9BBQ@mail.gmail.com>

On 9/18/2021 1:54 PM, Samuel Wales wrote:
> thanks for this.  if tests are written, might be useful to include the
> case where half-checked are parents.

I tested manually, and this behaves how I'd expect; not surprising, 
since it just calls `org-toggle-checkbox'. Maybe there's an argument 
that parent checkboxes shouldn't be clickable in the first place though. 
I don't think you can call `org-toggle-checkbox' on parent checkboxes 
(or if you can, I'm not sure what the trick is). My patch doesn't change 
that though, aside from having half-checked boxes be clickable in general.

I could look into writing some automated tests for this, but I don't see 
any existing ones for org-mouse, and I'm not familiar with simulating 
mouse events for Emacs tests.


  reply	other threads:[~2021-09-18 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 19:38 [PATCH] Improve org-mouse support for checkboxes Jim Porter
2021-09-18 20:54 ` Samuel Wales
2021-09-18 22:47   ` Jim Porter [this message]
2021-09-26  5:58 ` Bastien
2021-09-26 18:11   ` Jim Porter
2021-09-26 20:18     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4ecf4c7-c5e6-ceeb-63a8-f8750b735557@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).