From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oN1fIuX8/V/NWAAA0tVLHw (envelope-from ) for ; Tue, 12 Jan 2021 19:47:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8FEdHuX8/V82RgAAbx9fmQ (envelope-from ) for ; Tue, 12 Jan 2021 19:47:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B34E9404E1 for ; Tue, 12 Jan 2021 19:47:49 +0000 (UTC) Received: from localhost ([::1]:40040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzPdr-0004rN-0T for larch@yhetil.org; Tue, 12 Jan 2021 14:47:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzPdA-0004q1-A6 for emacs-orgmode@gnu.org; Tue, 12 Jan 2021 14:47:04 -0500 Received: from server173-4.web-hosting.com ([68.65.122.210]:39517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzPd7-00060L-JA for emacs-orgmode@gnu.org; Tue, 12 Jan 2021 14:47:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=isnotmyreal.name; s=default; h=Content-Transfer-Encoding:Content-Type: Message-ID:References:In-Reply-To:Subject:To:From:Date:MIME-Version:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GFTU99eks7jBSsRolKYnOl1c9moX/fO6IYclxFnU1W0=; b=F96cdiVpKBiNZSpa2FfxWlS5hv vZT6AdxsOxBziL0SdT597u62eeCRe+1bXB7/gTyLmHW2OXd4hiuOR/aHqS+WGIdsU2o+pNG1uBjWu IMwuf/AVQtKd6EBeQTO+xV6NvWYhxl3hTghSS17pI6v4JO4VSkhnECJOkcCOs3Ftfikd1n1WQtnrP 3UdKGYXxiwkOcmcBneG1bctEw4t1WD14VLQ2VOGUodKpfW1CKWmqXk2hYJIKqUU/grpv3wKes3rXY AOSACnzVeLrYYQfSHqPil24JiEsFqRg19xXT24XUeQoLDMOD59mcNmp8D9O1l8yz1Bp1GfOiv3i0s 6aH3Tyfg==; Received: from [::1] (port=43234 helo=server173.web-hosting.com) by server173.web-hosting.com with esmtpa (Exim 4.93) (envelope-from ) id 1kzPcM-0038nW-3Z for emacs-orgmode@gnu.org; Tue, 12 Jan 2021 14:46:18 -0500 MIME-Version: 1.0 Date: Tue, 12 Jan 2021 14:46:14 -0500 From: TRS-80 To: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-footnote: fix inserting new footnote mangling drawers (was: Re: Bug: inserting footnote when Footnotes heading has property drawer [9.3.6 (9.3.6-23-g01ee25-elpaplus @ /home/user/.emacs.d/elpa/org-plus-contrib-20200309/)]) In-Reply-To: <87h7nop9y5.fsf@kyleam.com> References: <1e98d0e48139cfb9cc98460dbf7ffccd@isnotmyreal.name> <87h7nop9y5.fsf@kyleam.com> Message-ID: X-Sender: lists.trs-80@isnotmyreal.name User-Agent: Roundcube Webmail/1.3.15 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-0.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server173.web-hosting.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - isnotmyreal.name X-Get-Message-Sender-Via: server173.web-hosting.com: authenticated_id: lists.trs-80@isnotmyreal.name X-Authenticated-Sender: server173.web-hosting.com: lists.trs-80@isnotmyreal.name X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Received-SPF: pass client-ip=68.65.122.210; envelope-from=lists.trs-80@isnotmyreal.name; helo=server173-4.web-hosting.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.39 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=isnotmyreal.name header.s=default header.b=F96cdiVp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 1B34E9404E1 X-Spam-Score: 0.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: zhp+NdrU5yVq On 2021-01-10 19:57, Kyle Meyer wrote: > Thanks for the initial report and the patch. I am very happy to contribute! Thanks for taking it easy on me the first time around. :) > TRS-80 writes: >> Subject: [PATCH] org-footnote: fix inserting new footnote mangling >> drawers > > convention nit: s/fix/Fix/ (no need to resend) Duly noted! > I'm planning to squash the following test in when applying. Look okay > to you? > > > diff --git a/testing/lisp/test-org-footnote.el > b/testing/lisp/test-org-footnote.el > index eca24d315..50a430785 100644 > --- a/testing/lisp/test-org-footnote.el > +++ b/testing/lisp/test-org-footnote.el > @@ -138,7 +138,20 @@ (ert-deftest test-org-footnote/new () > (org-test-with-temp-text > "Paragraph\n# Local Variables:\n# foo: t\n# End:" > (let ((org-footnote-section "Footnotes")) (org-footnote-new)) > - (buffer-string))))) > + (buffer-string)))) > + (should > + (equal "Para[fn:1] > +* Footnotes > +:properties: > +:custom_id: id > +:end: > + > +\[fn:1]" > + (org-test-with-temp-text > + "Para\n* Footnotes\n:properties:\n:custom_id: > id\n:end:" > + (let ((org-footnote-section "Footnotes")) > + (org-footnote-new)) > + (org-trim (buffer-string)))))) > > (ert-deftest test-org-footnote/delete () > "Test `org-footnote-delete' specifications." I must admit that currently I am still unfamiliar with the testing framework(s). It is something I am interested in learning, but haven't gotten around to /yet/. Therefore, hopefully some other set of eyeballs could give that another look? Cheers, TRS-80