* Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any)
@ 2016-12-29 18:12 Arun Isaac
2016-12-29 20:51 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Arun Isaac @ 2016-12-29 18:12 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
On list elements of `org-publish-project-alist' with :base-extension any
`org-publish-get-project-from-filename' fails with error
(wrong-type-argument sequencep any). This is due to the `concat' call in
`org-publish-get-project-from-filename' where it attempts to construct a
regex by concatenating several strings together. When extension `x' is
any (a symbol), this step fails.
Regards,
Arun Isaac.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any)
2016-12-29 18:12 Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any) Arun Isaac
@ 2016-12-29 20:51 ` Nicolas Goaziou
2016-12-30 5:41 ` Arun Isaac
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2016-12-29 20:51 UTC (permalink / raw)
To: Arun Isaac; +Cc: emacs-orgmode
Hello,
Arun Isaac <arunisaac@systemreboot.net> writes:
> On list elements of `org-publish-project-alist' with :base-extension any
> `org-publish-get-project-from-filename' fails with error
> (wrong-type-argument sequencep any). This is due to the `concat' call in
> `org-publish-get-project-from-filename' where it attempts to construct a
> regex by concatenating several strings together. When extension `x' is
> any (a symbol), this step fails.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any)
2016-12-29 20:51 ` Nicolas Goaziou
@ 2016-12-30 5:41 ` Arun Isaac
2016-12-31 11:31 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Arun Isaac @ 2016-12-30 5:41 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Nicolas Goaziou writes:
> Hello,
>
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> On list elements of `org-publish-project-alist' with :base-extension any
>> `org-publish-get-project-from-filename' fails with error
>> (wrong-type-argument sequencep any). This is due to the `concat' call in
>> `org-publish-get-project-from-filename' where it attempts to construct a
>> regex by concatenating several strings together. When extension `x' is
>> any (a symbol), this step fails.
>
> Fixed. Thank you.
Perhaps, `org-publish-get-project-from-filename' can be rewritten
without `catch' and `throw' using `cl-some' or `seq-some'. This is not a
bug. But, it might help improve readability of the logic.
Thanks,
Arun Isaac.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any)
2016-12-30 5:41 ` Arun Isaac
@ 2016-12-31 11:31 ` Nicolas Goaziou
2017-01-01 10:35 ` Arun Isaac
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2016-12-31 11:31 UTC (permalink / raw)
To: Arun Isaac; +Cc: emacs-orgmode
Hello,
Arun Isaac <arunisaac@systemreboot.net> writes:
> Perhaps, `org-publish-get-project-from-filename' can be rewritten
> without `catch' and `throw' using `cl-some' or `seq-some'. This is not a
> bug. But, it might help improve readability of the logic.
Done. Note that `seq-some' is not an option since we support Emacs 24.3
and onwards.
I also fixed couple of issues in the function.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any)
2016-12-31 11:31 ` Nicolas Goaziou
@ 2017-01-01 10:35 ` Arun Isaac
0 siblings, 0 replies; 5+ messages in thread
From: Arun Isaac @ 2017-01-01 10:35 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
>> Perhaps, `org-publish-get-project-from-filename' can be rewritten
>> without `catch' and `throw' using `cl-some' or `seq-some'. This is not a
>> bug. But, it might help improve readability of the logic.
>
> Done.
Nice. Looks good.
> Note that `seq-some' is not an option since we support Emacs 24.3
> and onwards.
Yeah, I guessed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-01 10:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-29 18:12 Bug: org-publish-get-project-from-filename raises (wrong-type-argument sequencep any) Arun Isaac
2016-12-29 20:51 ` Nicolas Goaziou
2016-12-30 5:41 ` Arun Isaac
2016-12-31 11:31 ` Nicolas Goaziou
2017-01-01 10:35 ` Arun Isaac
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).