From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wDCBCzA/1mVmpwAAe85BDQ:P1 (envelope-from ) for ; Wed, 21 Feb 2024 19:21:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wDCBCzA/1mVmpwAAe85BDQ (envelope-from ) for ; Wed, 21 Feb 2024 19:21:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Yo4aLd9D; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708539655; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=3GGV0NqSYlpgeDd2Ft0/8vzbpxB2IV5yCB7jutvkCVk=; b=ju07QTpXL8B80yhapEuhiGs2n8N7BRWJwIT85xajtFnh06V4ZJlau7c5vL5j+C2iSY46CD CbvmU339L8mV++K233tKZM3Lm67y3rXEO6nYXM2m0OEbUZcvaxzETHuLzcXsiUEkqhzsvc 9Iz9ZMwdt/ZFdrSw3kjhdROncTEQfM2cwDkM7xzJBZ5VJM7fPoBeoPN6sMEQUJB8Il19JX 1t1BHapcha22tEZR2/Hf6l2zbaHVaCWHxZsguRPw+b7MeUvY0D+tNWKNHpJL+NSB8Gpyk9 KRr65mb/mPDC5uU4NXOMtzmwopD8Mw2mdYSraxTzsHJMfWyb+MfuPJjQ3oqjSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Yo4aLd9D; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708539655; a=rsa-sha256; cv=none; b=KDR7Ma/fUWgfxsRpRLL1P9lvsjteQwd6KT1ge+ktJ60DzogA0wqoj+wRR5xBZY0YglMKnE yGTdMm80B1/fO/8zAGRETQyK3J/VxNWrnSlLpOdWoBe7hvQfo8nNpENKmeTyUzXGzVM8xU hcXjBw4cncZDUgMrLPyLMpBOqoBQzoqWA5se2Ow4QU3k0pj2uxv3q/XXirD7BnXEnaa1I8 YEC+7getQ/G6ikuXhKtJBPp3Uxh6zrqD9YXkVZuXf2w5wlknBCrEZSgobcXxxRqOUTJnuR vjFzGYOwYZgXw4BPgjSiOJr34tTc1QnHd2yoNix0U8BLDR5Mtbt7Hy6zRVVQBA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12269749FA for ; Wed, 21 Feb 2024 19:20:55 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcrCN-0006Mt-Tj; Wed, 21 Feb 2024 13:20:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcrCL-0006K4-SC for emacs-orgmode@gnu.org; Wed, 21 Feb 2024 13:20:01 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcrCI-0002m6-80 for emacs-orgmode@gnu.org; Wed, 21 Feb 2024 13:20:01 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0BBA5240103 for ; Wed, 21 Feb 2024 19:19:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708539595; bh=jHih5mtDGJUjPrbK/vaXziQGwDJ3B235NcWVlWoyC3E=; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To: Cc:Subject:Message-ID:From; b=Yo4aLd9D3JWNLl2vsuxkJPn25BP9+k38JV1B1S3Zdd7OyqcjIe1ssqToFsqv5Fr3S rSjSUeb3jmoR0J0qUGBa32d/X2wIFeGKhagcWDaDPqLtiHHMnvrPXw8E5iGcCfNMKW O24cKZkWIwCiVRK6mqkhG+B/1DlAwRdej4fQTSEhPHpYqRYZeXIdK77GALBkW14pEQ OOZtZN1ertHdQs2orp4qc16NuVAFD2kZCF1gVaLgAzpzaE5MlrajF/TLQqRSxNc2uQ PV2NP44qahqgYqlKwWm5j618god/PXyqBgvoKjIIu8o7RrP8ybp28Nzi94ETwtrIF+ puLamYl2112ZQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tg4Lf2zzVz9rxP; Wed, 21 Feb 2024 19:19:54 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 21 Feb 2024 18:19:54 +0000 From: gerard.vermeulen@posteo.net To: Ihor Radchenko Cc: Emacs orgmode , emacs-orgmode-bounces+gerard.vermeulen=posteo.net@gnu.org Subject: Re: [PATCH] org-babel-demarcate-block: split using element API In-Reply-To: <87frxmtasr.fsf@localhost> References: <7e41f9b6e9026a404e256f33371e974c@posteo.net> <87v88a78qd.fsf@localhost> <7f23ea966f0f0aad3fad29b0b96864f3@posteo.net> <87y1d55fc6.fsf@localhost> <37fdcc4bfcf734c2e5ec439d40b4f7d8@posteo.net> <878r50yqmo.fsf@localhost> <442006329cfba666710c989aece5191a@posteo.net> <261356c53e857e0bc4b04f884366edfa@posteo.net> <87bk9uy31w.fsf@localhost> <680e4a4fccf4f3c5c8f51d8215257eff@posteo.net> <87a5p9uute.fsf@localhost> <87wmscrty4.fsf@localhost> <2c82fa1399ddaa52ebe5bb21e241fb5f@posteo.net> <87o7dll7vn.fsf@localhost> <874je4hjmr.fsf@localhost> <87frxmtasr.fsf@localhost> Message-ID: Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.12 X-Spam-Score: -5.12 X-Migadu-Queue-Id: 12269749FA X-TUID: mjYEjkZSXvPC On 21.02.2024 10:40, Ihor Radchenko wrote: > gerard.vermeulen@posteo.net writes: > >>>> Still failing on my side (when running tests non-interactively from >>>> command line). To fix the problem, please use the approach from >>>> `test-org-list/indent-item': >>>> >>>> (transient-mark-mode 1) >>>> (push-mark (point) t t) >>>> >>>> Instead of (set-mark-command nil) >>> >>> Gerard, may I know if you had a chance to look into my comments? >> >> I think that I have addressed this particular comment. > > Not really. > In any case, see the attached updated patch with my suggestion > incorporated. > Indeed, I did not address it. I also tried out your suggestion out this morning and saw that it makes "make test" pass. > [...] > >> Secondly, I see (saw) sometimes Org emitting warnings with backtraces >> starting from my patch. I think the warning may be due either to a >> mistake >> on my side or a bug in Org, but I am not sure. > > May you please provide more details? I fail to reproduce the warnings, but I think that I have seen (rx ... ) type warnings in the Emacs warnings buffer with the patched org-babel-demarcate-block as backtrace entry point. I did not capture those at the time, because I thought I could trigger those warnings easily which is not the case. This is Emacs-30.0.50. I am sorry I cannot give more details. How to proceed? Of course, I agree with your version of the patch although I had started to remove some of the superfluous scaffolding to know where point and mark are. Regards -- Gerard