emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Make org-agenda-todo-ignore-* more flexible
@ 2010-02-12 23:17 Andrew Lutomirski
  2010-02-14 21:37 ` Carsten Dominik
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lutomirski @ 2010-02-12 23:17 UTC (permalink / raw)
  To: emacs-orgmode

Hi all-

I'm pretty close to switching to org-mode to keep a todo list, but the
current set of options doesn't do it for me.  I want my todo list to
show:

 - todos without a date (that means "do at earliest convenience")
 - todos scheduled for today or earlier (that means "do at earliest
convenience, but don't bother until scheduled date")
 - todos with near deadlines (that means "do by deadline but not
before warning")

This patch adds more options to
org-agenda-todo-ignore-{scheduled,deadlines} to allow this usecase.
It shouldn't break compatibility with existing uses -- both variables
do exactly what they used to when set to t.

commit: http://github.com/amluto/org-mode/commit/afa59fc91630bcffe388228566aa0137d1b2e7fd
topic: http://github.com/amluto/org-mode/tree/agenda-todo-improvements
git URL: git@github.com:amluto/org-mode.git agenda-todo-improvements

Do you like this patch?  And do I need to submit a copyright assignment?

Thanks,
Andy

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Make org-agenda-todo-ignore-* more flexible
  2010-02-12 23:17 [PATCH] Make org-agenda-todo-ignore-* more flexible Andrew Lutomirski
@ 2010-02-14 21:37 ` Carsten Dominik
  2010-02-14 22:37   ` Andrew Lutomirski
  0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-02-14 21:37 UTC (permalink / raw)
  To: Andrew Lutomirski; +Cc: emacs-orgmode

Hi Andrew,

On Feb 13, 2010, at 12:17 AM, Andrew Lutomirski wrote:

> Hi all-
>
> I'm pretty close to switching to org-mode to keep a todo list, but the
> current set of options doesn't do it for me.  I want my todo list to
> show:
>
> - todos without a date (that means "do at earliest convenience")
> - todos scheduled for today or earlier (that means "do at earliest
> convenience, but don't bother until scheduled date")
> - todos with near deadlines (that means "do by deadline but not
> before warning")
>
> This patch adds more options to
> org-agenda-todo-ignore-{scheduled,deadlines} to allow this usecase.
> It shouldn't break compatibility with existing uses -- both variables
> do exactly what they used to when set to t.
>
> commit: http://github.com/amluto/org-mode/commit/afa59fc91630bcffe388228566aa0137d1b2e7fd
> topic: http://github.com/amluto/org-mode/tree/agenda-todo-improvements
> git URL: git@github.com:amluto/org-mode.git agenda-todo-improvements
>
> Do you like this patch?  And do I need to submit a copyright  
> assignment?

I like the patch.  I have changed it a bit, and therefore I
guess I can accept it for now without.  Still - if you don't mind,  
please get an assignment just in case you are going to submit more  
patches.

Thanks

- Carsten

>
> Thanks,
> Andy
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Make org-agenda-todo-ignore-* more flexible
  2010-02-14 21:37 ` Carsten Dominik
@ 2010-02-14 22:37   ` Andrew Lutomirski
  2010-02-15  6:56     ` Carsten Dominik
  0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lutomirski @ 2010-02-14 22:37 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

On Sun, Feb 14, 2010 at 4:37 PM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> Hi Andrew,
>
> On Feb 13, 2010, at 12:17 AM, Andrew Lutomirski wrote:
>
>> Hi all-
>>
>> I'm pretty close to switching to org-mode to keep a todo list, but the
>> current set of options doesn't do it for me.  I want my todo list to
>> show:
>>
>> - todos without a date (that means "do at earliest convenience")
>> - todos scheduled for today or earlier (that means "do at earliest
>> convenience, but don't bother until scheduled date")
>> - todos with near deadlines (that means "do by deadline but not
>> before warning")
>>
>> This patch adds more options to
>> org-agenda-todo-ignore-{scheduled,deadlines} to allow this usecase.
>> It shouldn't break compatibility with existing uses -- both variables
>> do exactly what they used to when set to t.
>>
>> commit:
>> http://github.com/amluto/org-mode/commit/afa59fc91630bcffe388228566aa0137d1b2e7fd
>> topic: http://github.com/amluto/org-mode/tree/agenda-todo-improvements
>> git URL: git@github.com:amluto/org-mode.git agenda-todo-improvements
>>
>> Do you like this patch?  And do I need to submit a copyright assignment?
>
> I like the patch.  I have changed it a bit, and therefore I
> guess I can accept it for now without.  Still - if you don't mind, please
> get an assignment just in case you are going to submit more patches.

Great!  For the record, Łukasz Stelmach
(lukasz.stelmach@iem.pw.edu.pl) inspired this patch -- he had an
earlier patch that did something similar, although I didn't use any of
his code.

A couple thoughts, though:

s/applie/applies

org-agenda-todo-ignore-scheduled = all isn't documented.  Maybe the
test could be:

"all or t        Don't show any scheduled entries in the global todo
list." (with the appropriate number of spaces)

--Andy

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Make org-agenda-todo-ignore-* more flexible
  2010-02-14 22:37   ` Andrew Lutomirski
@ 2010-02-15  6:56     ` Carsten Dominik
  2010-02-15 12:52       ` Andrew Lutomirski
  0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-02-15  6:56 UTC (permalink / raw)
  To: Andrew Lutomirski; +Cc: emacs-orgmode


On Feb 14, 2010, at 11:37 PM, Andrew Lutomirski wrote:

> On Sun, Feb 14, 2010 at 4:37 PM, Carsten Dominik
> <carsten.dominik@gmail.com> wrote:
>> Hi Andrew,
>>
>> On Feb 13, 2010, at 12:17 AM, Andrew Lutomirski wrote:
>>
>>> Hi all-
>>>
>>> I'm pretty close to switching to org-mode to keep a todo list, but  
>>> the
>>> current set of options doesn't do it for me.  I want my todo list to
>>> show:
>>>
>>> - todos without a date (that means "do at earliest convenience")
>>> - todos scheduled for today or earlier (that means "do at earliest
>>> convenience, but don't bother until scheduled date")
>>> - todos with near deadlines (that means "do by deadline but not
>>> before warning")
>>>
>>> This patch adds more options to
>>> org-agenda-todo-ignore-{scheduled,deadlines} to allow this usecase.
>>> It shouldn't break compatibility with existing uses -- both  
>>> variables
>>> do exactly what they used to when set to t.
>>>
>>> commit:
>>> http://github.com/amluto/org-mode/commit/afa59fc91630bcffe388228566aa0137d1b2e7fd
>>> topic: http://github.com/amluto/org-mode/tree/agenda-todo-improvements
>>> git URL: git@github.com:amluto/org-mode.git agenda-todo-improvements
>>>
>>> Do you like this patch?  And do I need to submit a copyright  
>>> assignment?
>>
>> I like the patch.  I have changed it a bit, and therefore I
>> guess I can accept it for now without.  Still - if you don't mind,  
>> please
>> get an assignment just in case you are going to submit more patches.
>
> Great!  For the record, Łukasz Stelmach
> (lukasz.stelmach@iem.pw.edu.pl) inspired this patch -- he had an
> earlier patch that did something similar, although I didn't use any of
> his code.

Yes, I know these were very similar patches.

>
> A couple thoughts, though:
>
> s/applie/applies

Thanks?

>
> org-agenda-todo-ignore-scheduled = all isn't documented.

Yes it is.

Thanks.

- Carsten

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Make org-agenda-todo-ignore-* more flexible
  2010-02-15  6:56     ` Carsten Dominik
@ 2010-02-15 12:52       ` Andrew Lutomirski
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Lutomirski @ 2010-02-15 12:52 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode

On Mon, Feb 15, 2010 at 1:56 AM, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
>
> On Feb 14, 2010, at 11:37 PM, Andrew Lutomirski wrote:

>>
>> org-agenda-todo-ignore-scheduled = all isn't documented.
>
> Yes it is.

Whoops, I read your first commit but not your second.

--Andy

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-15 12:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 23:17 [PATCH] Make org-agenda-todo-ignore-* more flexible Andrew Lutomirski
2010-02-14 21:37 ` Carsten Dominik
2010-02-14 22:37   ` Andrew Lutomirski
2010-02-15  6:56     ` Carsten Dominik
2010-02-15 12:52       ` Andrew Lutomirski

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).