From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yMFOMeGs5WP/uQAAbAwnHQ (envelope-from ) for ; Fri, 10 Feb 2023 03:33:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UDU/MeGs5WMBCQAAauVa8A (envelope-from ) for ; Fri, 10 Feb 2023 03:33:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 781162B5AD for ; Fri, 10 Feb 2023 03:33:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pQJCw-0004mv-MM; Thu, 09 Feb 2023 21:32:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQJCu-0004ma-LT for emacs-orgmode@gnu.org; Thu, 09 Feb 2023 21:32:12 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQJCt-0001sL-5f for emacs-orgmode@gnu.org; Thu, 09 Feb 2023 21:32:12 -0500 Received: by mail-pj1-x1029.google.com with SMTP id bx22so3880612pjb.3 for ; Thu, 09 Feb 2023 18:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=IwtOOBMI+m8hrvGjdmNo4s1PPAajxY3ViZNCoPqNDgY=; b=hkpkpTHlqoFkDY/PIsdSjYruNF1sEmBEV58I6XFA36rjT/Fj6KMI2Len+MgxVGxVID ZJUyms3H2YBhyecDX2REmY5ILVQ22qJlvdyj9281B9SuW17wD4hIcaVEFooh3Lr01eqM lq5JQ+HMn5CvQ30745s2XOW0gwjSj21xyi2RW9eIESUcopQAGVI3jaXFnadBbm+m4coJ tOt3vKA0Y7XSsjn6Ipfpz0y7y1z1BDo6NknaRRoRofdQg8hisnv0zX81RWITSG9UJ1wq WM5tnXHgx08D8ahgrJz4kk8GFm9QBMajnZVr3bOCbOP8dpnhO5HTlKDM9T4jaUoHB0zI Z5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IwtOOBMI+m8hrvGjdmNo4s1PPAajxY3ViZNCoPqNDgY=; b=LGObkQxNQ33XvEwN4o8rEwGHAA4IoGI3KMgQFFQwILc+r3T4zmTrfov9EVQl25sVNq QGK9Z0GjTz91d+5dRoHHElL3O45iO0zQ0iO8iK+OHrkUo9JkBDIe0JWik8NDC0eyOD8I ct73MYc+MWRdnPKpZNkVgKs6yncshr+aKXgjwW9ANkGH1zoQBFfusnyQ6yU+bShzwMkR 6cO/ifrj0PglV4cRkBiOD1GpcUt6u/VD8B+OS/Jm35R460YkLxbULlTrBKBS2pB2QLwj dtYf2EoHZAJrKDeWOwVCLEseGmGjcvBnX1gXGK9xoF58TnxeqWlR65aXGTK6jXuT3Rld Kx4Q== X-Gm-Message-State: AO0yUKXQvzI6RnI24yhe1FMWbid7EBrj7LNuT2L2ssPZEbUzI6RjMzIY T4C3cDRfR8rQtsSbuH7gpmw= X-Google-Smtp-Source: AK7set+oiOHYQ0QodGljgGO38qq7010DROr4T/+gJ6qDX+TfTvUMmOuDsFY45Qx9VOc07WpZoeifOA== X-Received: by 2002:a17:903:41cd:b0:199:4be8:be48 with SMTP id u13-20020a17090341cd00b001994be8be48mr5038526ple.19.1675996329260; Thu, 09 Feb 2023 18:32:09 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id ji11-20020a170903324b00b0019682e27995sm1532024plb.223.2023.02.09.18.32.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 18:32:08 -0800 (PST) Message-ID: Date: Fri, 10 Feb 2023 09:32:05 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] remove unused code in ob-octave.el Content-Language: en-US To: Leo Butler , Org Mode Mailing List References: <87sffetu09.fsf@t14.reltub.ca> From: Max Nikulin In-Reply-To: <87sffetu09.fsf@t14.reltub.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=manikulin@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675996385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=IwtOOBMI+m8hrvGjdmNo4s1PPAajxY3ViZNCoPqNDgY=; b=iR+VirE7sadQKrQTFhzjp7MPA78J1YqTW15/gjfdBj5GWRMbp5fTiO0uEMuHlq0ZQvRxqY xaHoZjy6aYcUO24I1JbQye15B5bCz8jaXKpWIUP9mL+QeKISCkrTUpyeouSq2bwXXanKYU Jzr4ZmmIJ8u97GsNBb+AJ+cpFaY/4wA0sKPbXXTcAB+80933yDrgD63ii/2zzmpRZi0gac c278vHYo9cp9h/4xcT8+Fh671TyQ0+BroePYUeO0aTMuEIa/G0F/kiV9k/H3QgJ0IAjSBF mhkO1fA3NFyuWllP7MKWRdiVtTWfkphGve0Vjy9d4ioQor+uKLt5XkpeiducKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hkpkpTHl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675996385; a=rsa-sha256; cv=none; b=osOaTYFCnFI7KZTE5YjMY18Q//Veoypw5XFw3dBOx8uTrtbEYMXd8FRZWTbBwWOADXkNLX n7yK9qynpA9Xi+cNd7wEBBWYnzo4WkljzoM1f9pD3d2DfqS85yX6rXYaUFrQzJfESG83FG W8sfji3svM1RNE5QfC92ZmQ2c7IwJpsokUHPC2LNGqXjdYKHc5BoKv3PLqSDfwuLDJ1jkt Ow3WPID9laa768JcW7reBN3fTI3xXAZJ+lhU7dxwbn80FkqQ85TjMJnKA4mho9c0W6dQDu B4Neni4AT/CG/4eBnktxx/rokMX2G5PFpQS2oga+lL+/x9Ag4siYOaMY7ABWSg== X-Migadu-Spam-Score: 6.10 X-Spam-Score: 6.10 X-Migadu-Queue-Id: 781162B5AD Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hkpkpTHl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: RrN5Rmf2nFyc On 10/02/2023 04:21, Leo Butler wrote: > In lisp/ob-octave.el: > > What is the point of ob-octave-prep-session:octave or its brother, > ob-octave-prep-session:matlab? > > These two functions are unused in the existing code. Have you checked the following? I am not familiar with org-babel code. grep -nH org-babel-prep-session lisp/ob-core.el lisp/ob-core.el:1041: (prep-cmd (intern (concat "org-babel-prep-session:" lang)))) lisp/ob-core.el:1050: (error "No org-babel-prep-session function for %s!" lang)) Do test passes when you patch is applied? It might mean that test coverage is not perfect.