Re: [BUG] org-babel-header-arg-expand is rather cavalier about "appropriate context" [9.8-pre (release_9.7.10-127-g07dd3b @ /usr/local/share/emacs/site-lisp/org/)]

[Nick Dokos <ndokos@gmail.com>]

On 10/10/24 1:51 PM, Ihor Radchenko wrote:
> Nick Dokos <ndokos@gmail.com> writes:
>
>> This was reported by user @Addlai on Emacs SE. See
>> https://emacs.stackexchange.com/questions/82276/stop-org-cycle-from-prompting-for-header-args
>>
>> `org-babel-header-arg-expand' is added to the hook
>> `org-cycle-tab-first-hook' so when a TAB is pressed, the function is
>> called to check whether the context is approrpiate to call
>> `org-babel-enter-header-arg-w-completion'.
>>
>> But the only thing it checks is whether the preceding character is a
>> colon and whether we are in a source block (by calling
>> `org-babel-where-is src-block-head'), so if one presses TAB inside a
>> python source block after a colon, the context is deemed "appropriate"
>> and you are asked for a header arg.
> Confirmed.
>
>> It should probably check that it's *on* the header line of the source
>> block, not just that it is *inside* the header block.
> Agree.
> We need to compare the return value of
> `org-babel-where-is-src-block-head' with point.
>
> Would you be interested to submit a patch that fixes the issue?

Sure - it'll take me a few days, but I should be able to get one 
togother by early next week.


Thanks!

-- 

Nick


>