[PATCH] Allow 'prefix' to be set on the command line

[PATCH] Allow 'prefix' to be set on the command line

[Peter Jones]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

This patch allows you to:

  make install prefix=/some/path

Makes installing Org-mode in a non-standard path a bit easier.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: makefile.diff --]
[-- Type: text/x-patch, Size: 630 bytes --]

From e0b6b847c6b8a4b0c41aff3bab0ea2fe5e45c082 Mon Sep 17 00:00:00 2001
From: Peter Jones <pjones@pmade.com>
Date: Thu, 29 May 2008 21:22:59 -0600
Subject: [PATCH] Allow 'prefix' to be set on the command line

This patch allows you to:

  make install prefix=/some/path
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 35684f3..19fa9ca 100644
--- a/Makefile
+++ b/Makefile
@@ -14,7 +14,7 @@
 EMACS=emacs
 
 # Where local software is found
-prefix=/usr/local
+prefix?=/usr/local
 
 # Where local lisp files go.
 lispdir = $(prefix)/share/emacs/site-lisp
-- 
1.5.4.4


[-- Attachment #3: Type: text/plain, Size: 46 bytes --]


-- 
Peter Jones, pmade inc.
http://pmade.com

[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

RE: [PATCH] Allow 'prefix' to be set on the command line

[Dominik, C.]

[-- Attachment #1.1: Type: text/plain, Size: 486 bytes --]

Is this a syntax understood by all make programs?  Nice, 
I am taking the patch.  Thanks.

- Carsten


-----Original Message-----
From: emacs-orgmode-bounces+dominik=science.uva.nl@gnu.org on behalf of Peter Jones
Sent: Tue 6/3/2008 3:34 AM
To: emacs-orgmode@gnu.org
Subject: [Orgmode] [PATCH] Allow 'prefix' to be set on the command line
 
This patch allows you to:

  make install prefix=/some/path

Makes installing Org-mode in a non-standard path a bit easier.



[-- Attachment #1.2: Type: text/html, Size: 984 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [PATCH] Allow 'prefix' to be set on the command line

[Eddward DeVilla]

    I'm not sure if I read the diff right.  It replaces the equal sign
'=' with '?=' right?  I don't see that in the description of posix
make.  (http://www.opengroup.org/onlinepubs/009695399/utilities/make.html)

Also, if you look at section "Macros" for the phrase, "Macro
definitions shall be taken from the following sources", it kinda looks
like defining prefix (or any make macro) on the command line ought to
replace the definition in the makefile anyhow.  I'm pretty sure I've
used this before with gnu-make.  I think I've done it with the make on
freebsd (pmake?) and on aix.  Maybe this is broken on some
implementations?

Edd

On Mon, Jun 9, 2008 at 2:09 AM, Dominik, C. <C.Dominik@uva.nl> wrote:
> Is this a syntax understood by all make programs?  Nice,
> I am taking the patch.  Thanks.
>
> - Carsten
>
>
> -----Original Message-----
> From: emacs-orgmode-bounces+dominik=science.uva.nl@gnu.org on behalf of
> Peter Jones
> Sent: Tue 6/3/2008 3:34 AM
> To: emacs-orgmode@gnu.org
> Subject: [Orgmode] [PATCH] Allow 'prefix' to be set on the command line
>
> This patch allows you to:
>
>   make install prefix=/some/path
>
> Makes installing Org-mode in a non-standard path a bit easier.
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

Re: Allow 'prefix' to be set on the command line

[Peter Jones]

"Dominik, C." <C.Dominik@uva.nl> writes:
> Is this a syntax understood by all make programs?  Nice, 
> I am taking the patch.  Thanks.

It works with BSD Make, and GNU Make, I can't speak for Microsoft's
version of Make (nmake), but I don't believe it works there.

It's not POSIX, but I'm not sure if there are any operating systems
that are using a plain POSIX make.  Someone want to enlighten me?

-- 
Peter Jones, pmade inc.
http://pmade.com

Re: [PATCH] Allow 'prefix' to be set on the command line

[Carsten Dominik]

On Jun 3, 2008, at 3:34 AM, Peter Jones wrote:

> This patch allows you to:
>
>  make install prefix=/some/path
>
> Makes installing Org-mode in a non-standard path a bit easier.

I have noticed that at least my version of make (GNU make 3.81) does  
allow me to set
the prefix like that out of the box, without the need add the "?"  
before the = sign.


So I am now inclined to to remove this change again.  Peter, which  
version of make do *not* allow the prefix to be specified in this way?

- Carsten

>
>
> From e0b6b847c6b8a4b0c41aff3bab0ea2fe5e45c082 Mon Sep 17 00:00:00 2001
> From: Peter Jones <pjones@pmade.com>
> Date: Thu, 29 May 2008 21:22:59 -0600
> Subject: [PATCH] Allow 'prefix' to be set on the command line
>
> This patch allows you to:
>
>  make install prefix=/some/path
> ---
> Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 35684f3..19fa9ca 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,7 +14,7 @@
> EMACS=emacs
>
> # Where local software is found
> -prefix=/usr/local
> +prefix?=/usr/local
>
> # Where local lisp files go.
> lispdir = $(prefix)/share/emacs/site-lisp
> -- 
> 1.5.4.4
>
>
> -- 
> Peter Jones, pmade inc.
> http://pmade.com
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode