emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefankangas@gmail.com>
Cc: 68687@debbugs.gnu.org, emacs-orgmode@gnu.org
Subject: Re: bug#68687: [PATCH] Use text/org media type
Date: Wed, 31 Jan 2024 23:30:44 +0700	[thread overview]
Message-ID: <b40a4186-93bf-4daf-9364-852aadef940f@gmail.com> (raw)
In-Reply-To: <86plxoblrz.fsf@gnu.org>

On 26/01/2024 14:23, Eli Zaretskii wrote:
>> Max Nikulin writes:
> 
>>> diff --git a/lisp/gnus/mm-uu.el b/lisp/gnus/mm-uu.el
>>> index 3c7e3cbdf1a..b10da0c143a 100644
>>> --- a/lisp/gnus/mm-uu.el
>>> +++ b/lisp/gnus/mm-uu.el
>>> @@ -394,7 +394,7 @@ (defun mm-uu-emacs-sources-extract ()
>>>
>>>   (defun mm-uu-org-src-code-block-extract ()
>>>     (mm-make-handle (mm-uu-copy-to-buffer start-point end-point)
>>> -		  '("text/x-org" (charset . gnus-decoded))))
>>> +		  '("text/org" (charset . gnus-decoded))))
>>>
>>>   (defvar gnus-newsgroup-name)
>>>
>>> diff --git a/lisp/net/mailcap.el b/lisp/net/mailcap.el
>>> index 5ff75deb4e6..900099433c4 100644
>>> --- a/lisp/net/mailcap.el
>>> +++ b/lisp/net/mailcap.el
>>> @@ -989,7 +989,8 @@ (defvar mailcap-mime-extensions
>>>       (".jpe"   . "image/jpeg")
>>>       (".jpeg"  . "image/jpeg")
>>>       (".webp"  . "image/webp")
>>> -    (".org"   . "text/x-org"))
>>> +    ;; May be overridden by application/vnd.lotus-organizer in /etc/mime.types.
>>> +    (".org"   . "text/org"))
> 
> I'm not sure the removal of text/x-org in these two hunks is a good
> idea: could it perhaps cause trouble to someone, e.g. if an email
> message is sent from Emacs with this change and read by Emacs without
> it?

Changing of `mm-display-org-inline' may be postponed. I am curious 
however if there are a lot of users overriding their /etc/mime.types to 
avoid application/vnd.lotus-organizer.

However I am unsure whether `mm-uu-org-src-code-block-extract' is used 
to send messages. If it purpose to decode received messages then the 
change should be safe. I had a hope to receive some comments from 
developers familiar with Emacs mail clients.

I have realized that I missed `mm-automatic-display' there "text/org" 
should be added similar to `mm-inline-media-tests'.


  reply	other threads:[~2024-01-31 16:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-21 13:56 Org mode MIME type Max Nikulin
2024-01-21 15:11 ` Timothy
2024-01-22 16:21   ` Max Nikulin
2024-01-24 14:43   ` bug#68687: [PATCH] Use text/org media type Max Nikulin
2024-01-25 23:10     ` Stefan Kangas
2024-01-25 23:43       ` Ihor Radchenko
2024-01-26  7:40         ` Eli Zaretskii
2024-01-26 14:00           ` Ihor Radchenko
2024-01-30 19:39         ` Stefan Kangas
2024-01-30 20:34           ` Ihor Radchenko
2024-01-26  7:23       ` Eli Zaretskii
2024-01-31 16:30         ` Max Nikulin [this message]
2024-01-27  3:38       ` Richard Stallman
2024-01-28 16:35         ` Max Nikulin
2024-01-28 16:47           ` Eli Zaretskii
2024-01-30  3:56             ` Richard Stallman
2024-01-30 12:13               ` Ihor Radchenko
2024-01-30 17:12                 ` Org mode code evaluation (was: bug#68687: [PATCH] Use text/org media type) Mike Kupfer
2024-01-30 17:51                   ` Ihor Radchenko
2024-02-02  3:38                     ` bug#68687: " Richard Stallman
2024-02-02  4:58                       ` bug#68687: Org mode code evaluation Max Nikulin
2024-02-02 16:10                       ` bug#68687: Org mode code evaluation (was: bug#68687: [PATCH] Use text/org media type) Ihor Radchenko
2024-01-31 16:18                 ` bug#68687: [PATCH] Use text/org media type Max Nikulin
2024-01-31 16:32                   ` Ihor Radchenko
2024-02-02  3:40                 ` Richard Stallman
2024-02-02  7:15                   ` Eli Zaretskii
2024-01-30 12:52               ` Eli Zaretskii
2024-01-31 20:00     ` Stefan Kangas
2024-02-01 10:40       ` Max Nikulin
2024-02-02  7:09         ` Stefan Kangas
2024-02-02 16:28           ` bug#68687: [PATCH v2] " Max Nikulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b40a4186-93bf-4daf-9364-852aadef940f@gmail.com \
    --to=manikulin@gmail.com \
    --cc=68687@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).