From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Charles C. Berry" Subject: make update2 and ob-comint.el bugs Date: Sat, 23 Apr 2016 18:57:44 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1au9J2-0006DW-P9 for emacs-orgmode@gnu.org; Sat, 23 Apr 2016 21:57:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1au9Ix-0002pf-Oe for emacs-orgmode@gnu.org; Sat, 23 Apr 2016 21:57:52 -0400 Received: from iport-acv1-out.ucsd.edu ([132.239.0.176]:32422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1au9Ix-0002pG-G7 for emacs-orgmode@gnu.org; Sat, 23 Apr 2016 21:57:47 -0400 Received: from [137.110.33.30] (unknown [137.110.33.30]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ccberry@ad.ucsd.edu) by act-bufferout-a2.ucsd.edu (Postfix) with ESMTPSA id 1260C622F1 for ; Sat, 23 Apr 2016 18:57:45 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org-Mode mailing list Summary: ob-comint.elc compiled with `make update2' fails, but ob-comint.elc byte compiled via dired or with `emacs-lisp-byte-compile' succeeds. === I recently pushed a fix [1] for ob-comint.el or so I thought. See [2] for info on the bug. First, I tested the fix on my own system by eval'ing ob-comint.el and running some tests (including `make test' FWIW). I also byte-compiled the code using `dired-do-byte-compile', loaded that and ran more tests. All good. Then I pushed that commit to master. When I did `make update2' the compiled fixes did not work. But loading `ob-comint.el' works, and compiling via `dired-do-byte-compile' works and loading the result also works. What?! So I tried to undo the damage with two more commits, but in each case the `make update2' step generated code that was buggy. I see that `make update2' uses `byte-recompile-directory' and indeed running that gives a different (larger) ob-comint.elc than does `dired-do-byte-compile'. But both eventually use `byte-compile-file', and AFAICS the optimization level is the same in both cases. So I am baffled. Any advice on how to produce code that works when compiled with `make update2' or just to understand what gives here is appreciated. Best, Chuck [1] commit e42454088ff1176cce9cc65a4bd1c6f17fe958ec [2]