From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles C. Berry" <ccberry@ucsd.edu>
Subject: Re: bug: orgtbl-to-tsv: premature end of table
Date: Wed, 22 Jul 2015 21:04:10 -0700
Message-ID: <alpine.OSX.2.11.1507221959001.1943@charles-berrys-macbook.local>
References: <CAMg2vZpmomJzKG2UkatThncUr2gDQ_5NnSawON1T9X1db03Gag@mail.gmail.com>
	<alpine.OSX.2.11.1507221414280.1844@charles-berrys-macbook.local>
	<87h9ovzug3.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1ZI7k0-00078G-1f
	for emacs-orgmode@gnu.org; Thu, 23 Jul 2015 00:04:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1ZI7jw-0003Ow-Oi
	for emacs-orgmode@gnu.org; Thu, 23 Jul 2015 00:04:16 -0400
Received: from iport-acv6-out.ucsd.edu ([132.239.0.13]:38710)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1ZI7jw-0003OG-FP
	for emacs-orgmode@gnu.org; Thu, 23 Jul 2015 00:04:12 -0400
In-Reply-To: <87h9ovzug3.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org, lom pik <lompikvoila@gmail.com>

On Wed, 22 Jul 2015, Nicolas Goaziou wrote:

> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
>> Not a bug IMO.
>
> Notwithstanding the R issue, I think trimming the output of a radio
> table is a bit aggressive. We cannot know if trailing (and leading)
> spaces are significant in the output format the user defined.
>
> I removed the trimming part in commit
> bf37cd09b128b4431e1dd1a538fbcc4be3615042.
>
> Let me know if you disagree with that change.

I don't think the change broke anything that wasn't already broken.

And my diagnosis was wrong - I was confused by a problem that remains:

`org-babel-R-assign-elisp' is broken. Ragged rows in a table are filled 
with "" in each missing field; `org-table-to-lisp' returns a list of lists 
of common length.

`org-babel-R-assign-elisp' inspects that list to see if any element vary 
in length. But they do not, and therefore `max' and `min' in the let* 
varlist are equal and later on `ob-R-transfer-variable-table-with-header' 
is always used.

I think lom pik's example would not have failed had max and min differed 
as `ob-R-transfer-variable-table-without-header' would have been used 
instead.

R src blocks ought to render missing elements due to ragged rows in a 
table as NA, but this isnt the current behavior for this table:

#+NAME: tbl-ragged
| 1 | 2 | a |
| 8 | 9 |   |

It seems like the fix for this would be to prune any "" at the ends of 
lists in the value arg when beginning  `org-babel-R-assign-elisp'.

But I am tired, so I'll defer trying this till another time.

Best,

Chuck