From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Charles C. Berry" <ccberry@ucsd.edu>
Subject: Re: [PATCH] fix for ignored header args in org-babel-tangle
Date: Thu, 23 Apr 2015 18:45:12 -0700
Message-ID: <alpine.OSX.2.00.1504231820260.2080@charles-berrys-macbook.local>
References: <5532F914.5020505@gmail.com> <878udi1uy2.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1YlSgA-0005Aq-6a
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 21:45:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1YlSg6-0008IV-Rg
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 21:45:18 -0400
Received: from iport-bcv2-out.ucsd.edu ([132.239.0.73]:37738)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ccberry@ucsd.edu>) id 1YlSg6-0008IJ-IP
	for emacs-orgmode@gnu.org; Thu, 23 Apr 2015 21:45:14 -0400
In-Reply-To: <878udi1uy2.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Sam Ritchie <sritchie09@gmail.com>, emacs-orgmode@gnu.org

On Thu, 23 Apr 2015, Nicolas Goaziou wrote:

> Hello,
>
> Sam Ritchie <sritchie09@gmail.com> writes:
>
>> I found that all of my header arguments to source blocks were getting
>> ignored. Moving the header-args into the let* binding seems to fix
>> this issue, though I'm not enough of a guru to know why. Without this
>> arguments like
>>
>> #+BEGIN_SRC clojure :tangle ./project.clj
>>
>> and
>>
>> #+BEGIN_SRC clojure :tangle no
>>
>> were getting ignored and substituted for ":tangle yes" along with
>> other defaults.
>>
>> Hope this patch is in the right format:

I think it is inverted w.r.t. '-' vs '+'

>
> Thank you.

The patch in question modifies `org-babel-parse-src-block-match', which is 
a central part of org-babel.

The patch looks innocuous, but I have a hard time believing that `:tangle 
no' is ignored - there are many places I use it.

And if header args were ignored, lots of other things would break, too.

>
> Would you mind providing your patch with "git format-patch" and follow

Maybe start with an ECM?

Chuck