From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Charles C. Berry" Subject: Re: New patches WAS Re: [PATCH] inline src block results can be removed Date: Sat, 24 Jan 2015 21:01:05 -0800 Message-ID: References: <87egt81acy.fsf@gmail.com> <8761ejq9ek.fsf@nicolasgoaziou.fr> <87sihltt3v.fsf@selenimh.mobile.lan> <87zjbqrapy.fsf@nicolasgoaziou.fr> <87lhl2s5zc.fsf@nicolasgoaziou.fr> <87oapuac7g.fsf@nicolasgoaziou.fr> <87egqpxc6o.fsf@nicolasgoaziou.fr> <87a91a76sm.fsf@selenimh.mobile.lan> <87a917hd9u.fsf@gmail.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-516959571-1422162066=:4500" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFFJv-0007Q5-Gq for emacs-orgmode@gnu.org; Sun, 25 Jan 2015 00:01:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFFJs-0002BB-A0 for emacs-orgmode@gnu.org; Sun, 25 Jan 2015 00:01:11 -0500 Received: from iport-acv5-out.ucsd.edu ([132.239.0.10]:4333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFFJr-0002As-ST for emacs-orgmode@gnu.org; Sun, 25 Jan 2015 00:01:08 -0500 In-Reply-To: <87a917hd9u.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aaron Ecay Cc: emacs-orgmode@gnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-516959571-1422162066=:4500 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sat, 24 Jan 2015, Aaron Ecay wrote: > Hi Chuck, > > 2015ko urtarrilak 24an, "Charles C. Berry"-ek idatzi zuen: >> All tests passed (modulo a few shell and fortran issues unique to my setup >> which also failed for master). >> >> Then I did an update and `git merge master' and got a pile of errors due to >> >> commit fda70440f49292197d76ce4c2727dbf426bc65f3 >> Author: Aaron Ecay >> Date: Thu Jan 22 00:59:04 2015 -0500 >> >> which explicitly tests for conformity to the old inline regime or >> at least depends on it. > > By “pile of errors” do you mean test failures or merge conflicts? > AFAICS the patches you sent to the list did not touch the test suite, so > there should not be merge conflicts. But maybe you had a patch for the > tests that you didn’t send. (If I somehow caused merge conflicts for > your patches, I would offer to help fix them.) > > The test suite depends on the specific way in which inline results > are inserted, so it will need to be updated to take account of your > change. `test failures' is what I meant - sorry for being vague. No merge issues. I will mostly have to edit in the `{{{results(' `)}}}' wrappers in the places where the expected results are specified or specify [:results ...] to make the result agree with the specification, I guess. Thanks for your commit, BTW. I was feeling guilty about not having any tests, so my conscience is off the hook now. Chuck --0-516959571-1422162066=:4500--