From: William Denton <wtd@pobox.com>
To: Nick Dokos <ndokos@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Tables recently stopped aligning
Date: Wed, 8 Jul 2015 22:06:41 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1507082203510.26860@shell.miskatonic.org> (raw)
In-Reply-To: <87si9036r1.fsf@pierrot.dokosmarshall.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1759 bytes --]
Thanks for locating this. I don't know enough about Org's workings to see what
in the change introduced the bug, but something did go wrong, and column widths
+ table alignments are broken. I hope someone can fix it!
Bill
On 7 July 2015, Nick Dokos wrote:
> William Denton <wtd@pobox.com> writes:
>
>> Last week I got caught up on a week or two of Emacs and Org
>> development (I run both from development trees) and some tables
>> stopped aligning. I worked one down to five lines:
>>
>> https://gist.github.com/wdenton/ab890c36090cd4048d49
>>
>> With Org compiled from the dev tree in Git, when I load that file
>> (align.org) and hit C-c C-c, it doesn't align. emacs -Q loads Org
>> 8.2.10 (from the Emacs source) and it does align.
>>
>> Does it work for others? I assume it does---surely if other people
>> noticed this problem they'd have reported it already.
>>
>
> I can reproduce it with release_8.3beta-1274-gc76fef.
> I bisected it to the following commit:
>
> --8<---------------cut here---------------start------------->8---
> 6d60138260d54bf8403b9c87155682447808335e is the first bad commit
> commit 6d60138260d54bf8403b9c87155682447808335e
> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Sun Jun 28 15:45:31 2015 +0200
>
> org-table: Do not modify buffer needlessly when aligning table
>
> * lisp/org-table.el (org-table-align): Compare new table with old one
> before replacing it. Only replace modified lines.
>
> :040000 040000 2ef4220238baf6508c5de7270b6ac37733ac0934 f7d7ff100f0fdaee2ddab08b3514908d6d7643a0 M lisp
> --8<---------------cut here---------------end--------------->8---
>
>
--
William Denton ↔ Toronto, Canada ↔ https://www.miskatonic.org/
next prev parent reply other threads:[~2015-07-09 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 2:30 Tables recently stopped aligning William Denton
2015-07-07 4:56 ` Nick Dokos
2015-07-09 2:06 ` William Denton [this message]
2015-07-09 9:47 ` Rasmus
2015-07-09 16:01 ` Nicolas Goaziou
2015-07-10 0:07 ` Nick Dokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1507082203510.26860@shell.miskatonic.org \
--to=wtd@pobox.com \
--cc=emacs-orgmode@gnu.org \
--cc=ndokos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).