emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Carsten Dominik" <dominik@science.uva.nl>
To: Wanrong Lin <wanrong.lin@gmail.com>
Cc: org-mode list <emacs-orgmode@gnu.org>
Subject: Re: Blank lines in literal html
Date: Mon, 17 Dec 2007 09:57:44 +0100	[thread overview]
Message-ID: <acf852aa0712170057gbf0b5e5j7e7f9bd0c4dfc118@mail.gmail.com> (raw)
In-Reply-To: <4756FC88.1050701@gmail.com>

On Dec 5, 2007 8:31 PM, Wanrong Lin <wanrong.lin@gmail.com> wrote:
>
> Finally, I decided to learn some elisp debugging techniques and as a
> practice, it seems I found the bug and fixed it with this patch (against
> org.el in 5.16b)
>
> @@ -24437,7 +24437,7 @@
>            (when (re-search-backward
>               "\\(<p>\\)\\([ \t\r\n]*\\)\\=" (- (point) 100) t)
>          (setq par (match-string 1))
> -        (replace-match "\\2\n"))
> +        (replace-match ""))
>            (insert line "\n")
>            (while (and lines
>                (get-text-property 0 'org-protected (car lines)))
>
> I am not completely sure whether this is the right fix, but so far the
> output looks OK to me.


Hi Wanrong,

thanks for this patch - it is not the correct fix in this case, it is an issue
having to do with the fact that an empty line cannot hold text properties,
and that orgmode marks lines that are protected from processing by
putting a text property on it.  In this case, the fix is to continue the
loop looking for additional protected lines until the first non-empty,
unprotected line is found.  I am fixing this in the next release.

Bastien, thanks for your input on this as well.

- Carsten

>
> Can Carsten take a look of it and see whether it is OK to check this
> into the next release? Thanks a lot.
>
> Wanrong
>
>
>
> Wanrong Lin wrote:
> > Hi,
> >
> > Sometimes I use "htmlize" to  convert  a section of my buffer into
> > html and then insert it into my org file with "#+BEGIN_HTML" and
> > "#+END_HTML". One thing I noticed is the blank lines in the original
> > text is "amplified". For example, I have a section like this in my org
> > file:
> >
> > #+BEGIN_HTML
> > <pre>
> > Line 1
> >
> > Line 2 with a blank line in between
> > </pre>
> > #+END_HTML
> >
> > When I export the above to a html file, there are actaully 3 blank
> > lines between my "Line 1" and "Line 2".
> >
> > Is the above a bug or I mis-configured something? Thank you very much.
> >
> > Wanrong
> >
> >
> >
> >
>
>

  parent reply	other threads:[~2007-12-17  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-03 19:06 Blank lines in literal html Wanrong Lin
2007-12-05 19:31 ` Wanrong Lin
2007-12-09  1:07   ` Bastien
2007-12-09 23:08     ` Wanrong Lin
2007-12-10  0:26       ` Bastien
2007-12-10  1:57         ` Wanrong Lin
2007-12-10 14:33           ` Bastien
2007-12-17  8:57   ` Carsten Dominik [this message]
2007-12-18  3:00     ` Wanrong Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acf852aa0712170057gbf0b5e5j7e7f9bd0c4dfc118@mail.gmail.com \
    --to=dominik@science.uva.nl \
    --cc=emacs-orgmode@gnu.org \
    --cc=wanrong.lin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).