From dbd1c288db4cddf37cc5ba85722ef999bc206c2e Mon Sep 17 00:00:00 2001
From: Phil Estival <pe@7d.nz>
Date: Fri, 17 Jan 2025 05:26:50 +0100
Subject: [PATCH 11/11] ob-sql: update commentary reflecting recent changes on
 session

* lisp/ob-sql.el: mention support for session in commentary.  Sqlite
engine support.  Current limitations in sessions: only sqlite and
postgres are configured yet. Error line number are reported as LINE 1.
Default port number only.
---
 lisp/ob-sql.el | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
index 0489e466f..d4448d0d7 100644
--- a/lisp/ob-sql.el
+++ b/lisp/ob-sql.el
@@ -37,6 +37,7 @@
 ;; Header args used:
 ;; - engine
 ;; - cmdline
+;; - session
 ;; - dbhost
 ;; - dbport
 ;; - dbuser
@@ -54,20 +55,28 @@
 ;; - rowname-names
 ;;
 ;; Engines supported:
-;; - mysql
+;; - mysql/mariadb
 ;; - dbi
 ;; - mssql
 ;; - sqsh
 ;; - postgresql (postgres)
+;; - sqlite
 ;; - oracle
 ;; - vertica
 ;; - saphana
 ;;
+;; Limitation:
+;; - sessions:
+;;   - engines configured: sqlite, postgres
+;;   - no error line number (stays as LINE 1)
+;;   - default port number only
+;;
 ;; TODO:
 ;;
-;; - support for sessions
 ;; - support for more engines
-;; - what's a reasonable way to drop table data into SQL?
+;; - babel tables as input
+;; - raw replace result
+;; - port number configuration for sessions
 ;;

 ;;; Code:
--
2.39.5