From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eCfHNL0zFV/nEgAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 06:03:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AFGIML0zFV/OGwAAB5/wlQ (envelope-from ) for ; Mon, 20 Jul 2020 06:03:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B79F940224 for ; Mon, 20 Jul 2020 06:03:40 +0000 (UTC) Received: from localhost ([::1]:36836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxOtm-0004Ep-85 for larch@yhetil.org; Mon, 20 Jul 2020 02:03:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxOtM-0004Ei-UT for emacs-orgmode@gnu.org; Mon, 20 Jul 2020 02:03:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]:47745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxOtK-00008L-Q0 for emacs-orgmode@gnu.org; Mon, 20 Jul 2020 02:03:12 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4CAE816005F for ; Mon, 20 Jul 2020 08:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1595224985; bh=ylqXgvxynyYmtPJV0lQr5xf1qustcKAyinpDJ+NtMgs=; h=Subject:To:Cc:From:Date:From; b=L4IZoQWWw1+V2YMv42SnyceEzOUUFjdG/MIj1sgQxQHfyGRVd1M1mLTNkSl+Qk13d xNNyLwcFA+lmYsyJx+hH4z6Frs8tYctdANiWHR+tkr9acXvRxj2CazwOoQ6zJi2yKy qH9yaP8rXuRA4LvFmVNH53ehZ30IFuNu3mKw2WLqRom7D/v/2JRJNPjk2o9x/1hkEG GgGFTmJ9zy0FRWx6fzPdOFd5d8HHDRNy5NFzwPZuV4XooQ5h4BEQaMafKoguepaLaH wjs+E8pnZPQmMKptpZmuApKT7l4RV2+WQzuTMZQNMfK4nkRktikQDRgQJUhh/pNL/B vFyI32Q7JLm0g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B9B3X5xFKz9rxG; Mon, 20 Jul 2020 08:03:04 +0200 (CEST) Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command To: Kyle Meyer References: <6afc1c4b-9846-6081-aa3e-0496226e135a@posteo.de> <87blkaeuor.fsf@kyleam.com> From: Clemens Message-ID: Date: Mon, 20 Jul 2020 08:03:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87blkaeuor.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=clemens.radermacher@posteo.de; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/20 01:29:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=L4IZoQWW; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: j9r3HtrrmuiW > Note, though, that org-set-tags-command already supports completing > multiple tags through org-tags-completion-function, which it passes as > the COLLECTION argument to completing-read. In order to see that in > action, you may need to tell the completion library you use to fall back > to the built-in completing-read. As an example, I use Helm and have > this in my configuration: > > (add-to-list 'helm-completing-read-handlers-alist > '(org-set-tags-command)) > I looked and helm-org does include a similar adjustment to make it work correctly: https://github.com/emacs-helm/helm-org/blob/b7a18dfc17e8b933956d61d68c435eee03a96c24/helm-org.el#L490-L523 My patch aims to get you completion with the default completion and also for any framework that complies to it out of the box. Without my patch (and without helm-org) you don't get completion after the first tag I think.