From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cA0vMG9e1F42bgAA0tVLHw (envelope-from ) for ; Mon, 01 Jun 2020 01:48:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iCbaK29e1F6EDgAAbx9fmQ (envelope-from ) for ; Mon, 01 Jun 2020 01:48:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29790940415 for ; Mon, 1 Jun 2020 01:48:31 +0000 (UTC) Received: from localhost ([::1]:36352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfZZ0-0007KH-5I for larch@yhetil.org; Sun, 31 May 2020 21:48:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfZYe-0007Jh-PZ for emacs-orgmode@gnu.org; Sun, 31 May 2020 21:48:08 -0400 Received: from devianza.investici.org ([198.167.222.108]:56505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfZYd-0005fn-6a for emacs-orgmode@gnu.org; Sun, 31 May 2020 21:48:08 -0400 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id D60C4E0604; Mon, 1 Jun 2020 01:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anche.no; s=stigmate; t=1590976082; bh=c60L6KbBMC+JdBMMz/IIDEQqUAnUyPbHPjKemimGgZE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=sF7L/g2CnhcwFu4BCFq6Euzl9xg0x5gj6iclzOmQ9GUrXUOxuX2bomFyy1n+thaTO s5ngKOMxHtDZT0LENYnUjx9XaKjTySoGLNSonl5KZ41WAqiB9h38zGubs+T+VVl8uY nqqqLfTVI35VXgSxrly5AMMKDeJcGdSoaKGzV01Y= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: mariotomo@inventati.org) by localhost (Postfix) with ESMTPSA id 963A8E05E6; Mon, 1 Jun 2020 01:48:01 +0000 (UTC) Subject: Re: `with` as a list. To: Kyle Meyer References: <87h7vxuq8i.fsf@kyleam.com> <1a448b21-cdf9-467d-e707-471bb8c01781@anche.no> <874krvvdr3.fsf@kyleam.com> From: Mario Frasca Message-ID: Date: Sun, 31 May 2020 20:47:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <874krvvdr3.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=198.167.222.108; envelope-from=mario@anche.no; helo=devianza.investici.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 21:48:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=anche.no header.s=stigmate header.b=sF7L/g2C; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: kKoUgmc69Xb4 On 31/05/2020 19:19, Kyle Meyer wrote: > You've been sending a diff, > presumably from the point you branched off of to the tip of your branch. > In that case, you're already presenting each iteration you've sent as > one change; it just lacks a commit message. right, that's indeed what I did, and this is also what I thought, so no need to rebase, squash or whatever, as long as I make sure that the diff I'm sending you is about this single issue, and let's agree on the commit message, because after all I'm adding a function to a software I don't really know. I hope to send an updated patch soon, that will also include the docs. I have no strong opinion on workflows, just trying to understand the one used here. btw: if I had write permissions to the repositories, I would be adding test cases, and reviewing the docstrings, some of which I find misleading.  your remark on setf/setq could also be addressed in the code.  and some of the code ought to be refactored, as to allow for unit tests. ciao, MF