From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uB2QJpaQ8l/HVwAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 03:50:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wFtYIpaQ8l+eAgAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 03:50:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E144E9403E6 for ; Mon, 4 Jan 2021 03:50:45 +0000 (UTC) Received: from localhost ([::1]:52474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwGtI-0007UK-R0 for larch@yhetil.org; Sun, 03 Jan 2021 22:50:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwGsu-0007UA-Qk for emacs-orgmode@gnu.org; Sun, 03 Jan 2021 22:50:20 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:40611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwGst-00075t-0e for emacs-orgmode@gnu.org; Sun, 03 Jan 2021 22:50:20 -0500 Received: by mail-ej1-x633.google.com with SMTP id x16so35171629ejj.7 for ; Sun, 03 Jan 2021 19:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=muyXNMk+swCdKxkW1eT0PbInJZDysZo2ZuWNzyDAxMY=; b=mIEUijinsk5mjfVcW5z4OOjuXROWhQY93W89Sp39EEXu5RLWrIAuxXsFUvEx3UP+Qm ipd30JhZBwCX689wFFSlpPW4zIwmdWUlZfexK+FvFN7UukRaWcd9pbzaKgdr5UemOh02 jAq4dfuMcJP/eLYFrIKjuzOBxNGQkNXqGJpyrKsii08YEeC5syWrk4fVvzTuJJCB3CYo fy4K5stsPiEqIDTL5+jr+NeKxR1KNTKrg15tBWNdrRxpCIFAahpaB5T0A20pFq/d89ih fDjQqqS/MVD5AZ2kxPuBp0HNWxqaWixuVdXzSdx8r/vsEd1ZJM6gCnPhHWLN97FvcFWx Xk4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=muyXNMk+swCdKxkW1eT0PbInJZDysZo2ZuWNzyDAxMY=; b=bCdfTufRBRakkFIr/ZcEga2KMiI8+mkgN+2FphFExSzs62DbOww2ABYv+73kPM25AI uyLvedKEVh+CE2nN54KrM81By1ca08l0WQZv6YNUgUaS0Eqy4ICUlWIuR4vki4Lyg48r m0sfKtG+JniQwuN4eLoRQaDgl9NtxCipzo8SpjGglfH8gjc6vbUZly1/yFGI/aFBOF8K UmhJPNsDhkNh9hBnx2PbVghljJQogBKEmqMotofMbDK1sNtgZVThUPmELrQFB1LeO5qH WieJBVuEG3ew4HHYIWv1Ye89ZnTt+DZzZZrzeDTU70Zw6Tt3heoSDRal8UzGogJbyMjp 3eWA== X-Gm-Message-State: AOAM532MHb7Vm5fNoKX+Z0WQYeHeMVXcGkoZdBBF7aCRZS5yGkNFi0HM FIpF8laSyyER2mrPKv/ueNDpQ5MLNw== X-Google-Smtp-Source: ABdhPJz3rDiBnuaHKgirCW83zeJM3OCpy9d7lp5kKEAQSBieqCpwZG/xIXMFwgO19elZW22K9Qwhpw== X-Received: by 2002:a17:907:1182:: with SMTP id uz2mr66763242ejb.183.1609732217234; Sun, 03 Jan 2021 19:50:17 -0800 (PST) Received: from VI1PR1001MB1070.EURPRD10.PROD.OUTLOOK.COM ([2603:1026:300:5a::5]) by smtp.gmail.com with ESMTPSA id l14sm43211026edq.35.2021.01.03.19.50.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2021 19:50:16 -0800 (PST) Received: from dark (183.246.146.135) by HK2PR06CA0005.apcprd06.prod.outlook.com (2603:1096:202:2e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19 via Frontend Transport; Mon, 4 Jan 2021 03:44:53 +0000 From: miles christopher To: David Florness Subject: Re: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded Thread-Topic: [PATCH] org-contacts.el: Only use org-id-store-link if org-id is loaded Thread-Index: AQHW4isVyqhcym6m30+0j41Pye2/tqoW0xyA X-MS-Exchange-MessageSentRepresentingType: 1 Date: Mon, 4 Jan 2021 03:44:57 +0000 Message-ID: References: <874kjxpqht.fsf@florness.com> In-Reply-To: <874kjxpqht.fsf@florness.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Exchange-Organization-AuthAs: Internal X-MS-Exchange-Organization-AuthMechanism: 06 X-MS-Exchange-Organization-AuthSource: VI1PR1001MB1070.EURPRD10.PROD.OUTLOOK.COM X-MS-Has-Attach: X-MS-Exchange-Organization-Network-Message-Id: 7374394f-7599-4540-c08b-08d8b0631ab7 X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 x-clientproxiedby: HK2PR06CA0005.apcprd06.prod.outlook.com (2603:1096:202:2e::17) To VI1PR1001MB1070.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:69::18) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=numbchild@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: miles christopher Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.03 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=mIEUijin; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E144E9403E6 X-Spam-Score: -3.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: Zp3MTxM4M7EF Thanks for your patch. :smile: Can you send patch file as attachment? I don't know how to apply patch in e= mail body. David Florness writes: > Fixes bug introduced in 6b83c6e4e that made org-contacts-anniversaries > error if org-id was not loaded. > --- > Alternatively, we could autoload org-id-link-to-org-use-id. If you all > would prefer this, let me know and I can send a v2 patch. > > 6b83c6e4e was found using git-blame. > > contrib/lisp/org-contacts.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el > index 82881ecd0..7ad425519 100644 > --- a/contrib/lisp/org-contacts.el > +++ b/contrib/lisp/org-contacts.el > @@ -1166,7 +1166,7 @@ are effectively trimmed). If nil, all zero-length = substrings are retained." > "Store the contact in `org-contacts-files' with a link." > (when (and (eq major-mode 'org-mode) > (member (buffer-file-name) (mapcar 'expand-file-name org-contacts-= files))) > - (if org-id-link-to-org-use-id > + (if (and (featurep 'org-id) org-id-link-to-org-use-id) > (org-id-store-link) > (let ((headline-str (substring-no-properties (org-get-heading t t = t t)))) > (org-store-link-props --=20 [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3