Re: [BUG] dead loop on (org-table-clean-line "|a|b|") [9.6 (release_9.6-3-ga4d38e @ share/emacs/29.0.60/lisp/org/)]

[Lin Sun <sunlin7@hotmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 444 bytes --]

Hi Ihor,

> I cannot reproduce.
> Can you please provide detailed steps starting from emacs -Q?

The bug caused by the function org-table-clean-line​ calls the org-string-width​ inside a string-match​ clause without protection, for the org-string-width​ maybe change the match data then cause the string-match run into wrong result.

The attachment is a quick patch for the issue, please help to review and apply it, thanks



[-- Attachment #1.2: Type: text/html, Size: 1999 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-table.el-fix-match-data-changed-in-org-table-cle.patch --]
[-- Type: text/x-patch; name="0001-org-table.el-fix-match-data-changed-in-org-table-cle.patch", Size: 909 bytes --]

From 428f989c6e9f846cf6a1bbb25ada56146789a2c6 Mon Sep 17 00:00:00 2001
From: Lin Sun <lin.sun@zoom.us>
Date: Fri, 2 Dec 2022 07:31:05 +0000
Subject: [PATCH] org-table.el: fix match-data changed in org-table-clean-line

---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index b160dc97c..6e6835fba 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -1699,7 +1699,7 @@ In particular, this does handle wide and invisible characters."
       (setq s (mapconcat (lambda (x) (if (member x '(?| ?+)) "|" " ")) s ""))
     (while (string-match "|\\([ \t]*?[^ \t\r\n|][^\r\n|]*\\)|" s)
       (setq s (replace-match
-	       (concat "|" (make-string (org-string-width (match-string 1 s))
+	       (concat "|" (make-string (save-match-data (org-string-width (match-string 1 s)))
 					?\ ) "|")
 	       t t s)))
     s))
-- 
2.20.5