From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QKzYIbduCmCxAQAA0tVLHw (envelope-from ) for ; Fri, 22 Jan 2021 06:20:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EO6THbduCmDqCgAAbx9fmQ (envelope-from ) for ; Fri, 22 Jan 2021 06:20:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2C739403EA for ; Fri, 22 Jan 2021 06:20:38 +0000 (UTC) Received: from localhost ([::1]:41286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2poC-0007tD-9B for larch@yhetil.org; Fri, 22 Jan 2021 01:20:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2pnY-0007sp-Ei for emacs-orgmode@gnu.org; Fri, 22 Jan 2021 01:19:56 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:39486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2pnW-0002Sc-PH for emacs-orgmode@gnu.org; Fri, 22 Jan 2021 01:19:56 -0500 Received: by mail-wm1-x32f.google.com with SMTP id u14so3363875wmq.4 for ; Thu, 21 Jan 2021 22:19:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:reply-to:accept-language:content-language :mime-version; bh=xIK3SaMyJhntQvvgi6GeXJTHqW1rwYpNTDvoSmkNWYE=; b=hhRQGbAOGGJ7KKCJvQK84uKSp/Cw5AaHnQqWZtknkzSery52BfnBurzIsevDwLQeQw O/6/K1IpbT3vgxCsXbkdycn2qiC8R777EAlnLgDWp1kIiRGF/Nyzw9imguOKgW7BzAqA ZGGcgwaHkDFYqUEj9bvY1OUvxBYhjZr9FGQfI4e4Lbj9B4ragksE1z/lH4N7VDRYYXhZ cMEikpSoXfmKRPRRc7Tt5kzHUBxL+HIDLKVQav2uey5G1Tsx/PY7XQaILju7wjCQzE35 w1siszIrN2SiL09BAtPFQWT9FwbUM6KNAgQyIr2vBlGb1TPuJGx10lTW+IRj/Fqxd7eS Oz/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:reply-to:accept-language :content-language:mime-version; bh=xIK3SaMyJhntQvvgi6GeXJTHqW1rwYpNTDvoSmkNWYE=; b=Cvy83wXlA8LCPeaw8hw4z1OTwF2VwdxSBrBxjk3pNuA8VDS9LRrhZgZ24tAvLcyaBG 8XJGgDPy90GxJVjZdI6OCFkPo8Oz2HCNLKildnysb8TYJxIFgFC8lz4XOOWpFse3y6p7 u0IZXlCtC0cLIJGCH6myBzl/CRT9MJBnElokAzd1win7Kx0ya5DQxGZjtlKrSEQGo4pX 34Y/w7q+gtOkWsJkfIfutj9Y+iEddLdPQo4d0vOO0CcSVPNILi0eXph7FwlDeZcRRo74 +RA0lAFuFvvG41wldUL8PgA6zYlx8UVSCAQFOL/m4XR6JoArM9o7BRE3uMxTrTz+UuFu DLdA== X-Gm-Message-State: AOAM532MOxFoTkY8rfFeRzrYVwvMkXioSdnB2WLZ2Ej/NYDzDOU8Ixgu ZAlMHT/VprRS9w4uQL0B/g== X-Google-Smtp-Source: ABdhPJzN9tWcH55XoNqtT7HT7qrBZg6L1WD25SWWjbB4IzYOp7pSH79k1JtefLuDesEBYpIan6ABjA== X-Received: by 2002:a1c:e90a:: with SMTP id q10mr2297550wmc.102.1611296393256; Thu, 21 Jan 2021 22:19:53 -0800 (PST) Received: from PAXPR08MB6640.eurprd08.prod.outlook.com ([2603:1026:c0a:1::5]) by smtp.gmail.com with ESMTPSA id u17sm10028431wmj.35.2021.01.21.22.19.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2021 22:19:52 -0800 (PST) Received: from dark (183.246.145.54) by HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11 via Frontend Transport; Fri, 22 Jan 2021 06:00:08 +0000 From: Christopher Miles To: Maxim Nikulin Subject: Re: [PATCH] Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Thread-Topic: [PATCH] Re: [BUG] [C-u C-u C-c C-o] open link with external program invalid to open file Thread-Index: AQHW1caRExHu/lvlJkaB4JwUrG5MzKouXvEAgAD+vwCAAKniAIAA3xQAgACNfQCAARGGgIAA1jMA X-MS-Exchange-MessageSentRepresentingType: 1 Date: Fri, 22 Jan 2021 06:00:09 +0000 Message-ID: References: <87ftazz9q0.fsf@gmail.com> <87lfho7ja2.fsf@gnu.org> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Exchange-Organization-AuthAs: Internal X-MS-Exchange-Organization-AuthMechanism: 06 X-MS-Exchange-Organization-AuthSource: PAXPR08MB6640.eurprd08.prod.outlook.com X-MS-Has-Attach: yes X-MS-Exchange-Organization-Network-Message-Id: ef787197-2f16-48b3-00a0-08d8be9af978 X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 x-clientproxiedby: HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) To PAXPR08MB6640.eurprd08.prod.outlook.com (2603:10a6:102:dd::5) Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=numbchild@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, PDS_BAD_THREAD_QP_64=0.998, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Christopher Miles Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.15 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=hhRQGbAO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A2C739403EA X-Spam-Score: -5.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: EnW7U/N70RIw --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxim Nikulin writes: > On 21/01/2021 07:58, Christopher Miles wrote: >>=20 >> I "=3Dgit am=3D" your first patch, but failed to apply your second patch= . Seems not >> continuous. So I modify code manually. I found I can't find the local va= riable >> ~shell-command~, and ~shell-command-switch~. Can your provide complete p= atch? So I >> can test it. > > Second patch is an alternative to the first one. I could do 'git apply=20 > org-open-file-make-process-min.patch' to the current master with no=20 > conflict. However you are right, it should be ~shell-file-name~, not=20 > ~shell-command~. There is a typo in ~shell-command-switch~. Both=20 > ~shell-file-name~ and ~shell-command-switch~ are defined in emacs=20 > sources, they are not local variables. Indeed, I learned new stuff. =F0=9F=98=84 > > I do not think that the first patch could be accepted in any form.=20 > Launching a handler without shell is a serious change. However trying to= =20 > rewrite that part, I realized that original code has a problem. > > I intentionally do not add formal patch description since I suppose that= =20 > error reporting should be improved. You're right, the error handling can be improved. =2D-=20 [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAmAKaeEACgkQG13xyVro msPcoggA1W5es7MbCT5o+8Lt8C9s/zJS2ZnlaYqiQRf/EEe2ZWFmoMBBuG2Ouhzr 1GDsdeO6mJ+6hdBBLm/bQiAWytp9j4LHoaFHv4QkTyW5nSR47Mi565UbIcGBWQaV u4U+vPdQBvGWgf7QJnewtTD64HD4mkhbbmCV6/OqYQL0PKKm9snTUTgdwaio6aj6 Jz9rxGhQpaFuNrzPqSbKA0ej7UrrXKlUcRj/7VHYzsxTppoMCM1O9fx4Y+m7wsaT 1CiNhRXchf6RRcFxYgAHq+TDhHJutVnk4/DFVs+yR6rXF7S+ydRnxeygvpOdx4SH zfdqBfOvMV1QTViOBbCtp9wS80XU1g== =qAiD -----END PGP SIGNATURE----- --=-=-=--