From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iEoJOKooPGLFHwAAgWs5BA (envelope-from ) for ; Thu, 24 Mar 2022 09:15:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YL1/NaooPGIMPQEA9RJhRA (envelope-from ) for ; Thu, 24 Mar 2022 09:15:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3637E3BC85 for ; Thu, 24 Mar 2022 09:15:38 +0100 (CET) Received: from localhost ([::1]:52280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXId6-0002by-C6 for larch@yhetil.org; Thu, 24 Mar 2022 04:15:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXIcG-0002bn-PG for emacs-orgmode@gnu.org; Thu, 24 Mar 2022 04:14:45 -0400 Received: from mail-vi1eur05olkn2093.outbound.protection.outlook.com ([40.92.90.93]:17537 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXIcE-0001ai-Mz for emacs-orgmode@gnu.org; Thu, 24 Mar 2022 04:14:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9tQyttxWFgDSbr5HBo3ZyGkG6GwgeH4+gebhiEKJ/xyA7A3zb5xk4NHf6B77KInmlxbfDI/Z8dylKhCjKKz+yQGPWjm0AyNl4xuf4XB1LjtNNgXDdv+UPV2sQyMqlxV1d8UDH2dgulTQY3BaO14VgqlD2G8qgydeE1mbq+cPzkJscjixLAwgVPm1m/vWeTeek0S+KcnNCVS1SKxcGzmk/k3Ns+r6HavQSOH0b0iVIdG3wusNmWiyYzUxmpkT1J8ryAe15yc54312wBJZQVf8Z2DbCHe2Z8kFeCVXGAUiTwbW0DJY6TOTpF2ojTRIDDH5EEuyaaxG46jtSEWI3BOsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nj4lLrWDTju2IlptTXZyrqiRLrxzVWqtSQ4XbsA96jY=; b=TFZrukLNHwAh6GBwMrhlLdr4GAR6GgNTJGLKBUHW+MUhsOC53lt8sx2/Ojsnhv1TYGrLyKZAZd0LxLwSIfOBwaUBZPa7Dh+tA8yjg9o0LrROTaornPGwkk+OTwcUD7E+i3/kpM7nKht/iTqk5zWmbsJzr05A6igUtoFURF1pyi1Giu467FMeFA1yhnxucdE2PCrBJMdzcV3oMzrx2PvWqAaiXvqXffeZp+jBrm/llkMxtobXaHIYy/JXWDeP1aT4G4cxjDEnu0iF/tu81KVm+kcqs+NwuC+UyoC/GKxuduIzO4tWrLZkWNY/dXUJgm5TVPC51Poiukc77LoIssjFGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nj4lLrWDTju2IlptTXZyrqiRLrxzVWqtSQ4XbsA96jY=; b=uxkL1i6lsl/rlLby3Ry5Czo6W2Vl9WMgj0VdL4OmKahZ/QEwGF03qD20JqohcwkazCMNJpfVwQy1GdfMHjR/f3d3nPCCKvdz1xqTXnciVUDiWT3i9ipcsyM9a6gKTPxObFsX66xl+dDRhw7LbR0qB1bhkWQmYtaEfCh+v0FFC2M0DHvomObYFKq9Ud4bS/DR0tWch6MEUWWdOKq4uyCrQ4AO1OsxOePY0VpSeiLKXgQfXY0ZKVVsUM/ciI4AQyJ+I6OsJDU9+sSapA+stumwVqkfxac+m/VGRSZR9ZqwPWeXVZFiQWIwCLZWbVlTsIu8CPcuq12uaX/6Xb92FY9JfQ== Received: from PAXPR06MB7760.eurprd06.prod.outlook.com (2603:10a6:102:155::8) by DB9PR06MB7884.eurprd06.prod.outlook.com (2603:10a6:10:296::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.16; Thu, 24 Mar 2022 08:14:40 +0000 Received: from PAXPR06MB7760.eurprd06.prod.outlook.com ([fe80::e05a:8d81:8648:b10f]) by PAXPR06MB7760.eurprd06.prod.outlook.com ([fe80::e05a:8d81:8648:b10f%8]) with mapi id 15.20.5102.017; Thu, 24 Mar 2022 08:14:40 +0000 References: <878rt019jq.fsf@hotmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Ignacio Casso To: emacs-orgmode@gnu.org Subject: Re: [BUG] C-c C-o on headline evaluates source code blocks with links inside [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)] Date: Thu, 24 Mar 2022 09:02:09 +0100 In-reply-to: <878rt019jq.fsf@hotmail.com> Message-ID: Content-Type: text/plain X-TMN: [Sfg/OdC87jHZ8lSDP6kvE2JzUQruxuYR] X-ClientProxiedBy: MR2P264CA0037.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::25) To PAXPR06MB7760.eurprd06.prod.outlook.com (2603:10a6:102:155::8) X-Microsoft-Original-Message-ID: <87wngjzs11.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 669680fd-2f9b-4392-e113-08da0d6e57be X-MS-TrafficTypeDiagnostic: DB9PR06MB7884:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WWkUJbRv8PBsjGOKMq5lD5Ax76LDd6K9hw2cXzA4gpueWK6LqME6q2zxiIdMBYKkcQ37uxP1ZMC83JnSY3l8oHiTi5HdFjWFr+W0Itz47zufe2IuqHWsklWiaH/rhIR5inkxWfwlBYZKL1SkMVEppTwg4zW246PDvn7/JQ4eig5QguTKjz0ZFD/Xa6/MU6Z2fl66D64OPPdA+6NwsMkGTcM+FmBpLD6lVGNBMQ7gqNc0v29LEo6Frg/59yExP2y7npn9zKiAHD0GE/vwQW+EigA16070UmPY9cpy/UdAMpMxANyq8S7KxCRNdoIAu2yrOp75sKBdfnCfUTDmsFb6sDvGrcgX2O+mMRDDNHbbkrVxuietZ8soQHV9tYEZZTEswGe3rvb67m+VbgTO01eUDDd6SpDzqbaKbebNkJ/5Fqr+CUkVj668EVvCGBk76Qk8JOQUiQQMF8JbK82dr9qGivnngTIeENLzMu9LRrp6fq+TFCeKr/grnugg4/CTvzHM9MiDqkNfrr2ZIcSoGXO8Iyf2vlHh+53IQMstTLJ/CTF0lSX7G4Hu//TYqoQDqjAwM9Qcd4z+ptY8eyvg2SBbMA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aaBp7L6LFU6xuz0zfhej7b79XESo8n8kd1zKc0yAdSmeYV0LRSsNt8I+SEVN?= =?us-ascii?Q?t+Sxwqz6SgqbzMxcixf+R6ziRtnzepOHihi7/N1w10jl1KyZf0QUTRNCZVi+?= =?us-ascii?Q?Ek6sTfmgKIYJ1BK6nxdevShs+RQY3HNJHFlSbjSgVdf+UI8YqKQPsG6+b/JJ?= =?us-ascii?Q?XBxa0nwAC5cGmhvt6Ew1jO8iobnG1fL75PARicpQpfKTka0me7Hr/joi5cZM?= =?us-ascii?Q?U8IEAS31mKg2dE0/mXrre4esffrbScedNXQrZWmKMOzU4Ar6W5eD66wTLwUv?= =?us-ascii?Q?aYb+xROiNIr4oonNkJ8zE2Exhmm5nwvTyN+rvpTl2kV75fi824Ffm90J6R2y?= =?us-ascii?Q?YMSksw5uRP7Ybs0ZoxYlukGeSltXzZToZAeUsIsNvISZw8QbQNBXnjDe5gFt?= =?us-ascii?Q?7oA5rPYr/CfZ/LIF+0CPpoytcx5UAz2ZYzFnPq297E2czthitJYZkMCZebMT?= =?us-ascii?Q?DVLeHHNcLpESPNEEECrhpWG82p4+8rTOJPyKgMFscNo8Gtp+/Ao6BBHwdl7a?= =?us-ascii?Q?PBN6S4nplUf1aEoveI1meUYokuFkXVAqgMN2YQiyStpN96dSRZkaOs7FTxAR?= =?us-ascii?Q?G8UPmw0Z31Mbbz6DmGFZkF6dPK5a5RXOtQSzG95ITFC1a78z4Ui4NVHwxxsm?= =?us-ascii?Q?IlzJxKWESb+tzHlCeQ96vKpaoCPbnFIwy/QunC9Sn3SaoLM41Zud29lrgpN6?= =?us-ascii?Q?oiSfgTytmmI9a407aPvg9v/xIVH3RPjdmEXDgBWtgbhWdRXlOzzmxF2wNEzO?= =?us-ascii?Q?HQiPbHs2aS7tDBRFLu7gNIQv4f4Zv6RBnSKPJXf5I4u58Lk5j8sO3jehb2vW?= =?us-ascii?Q?lyzT06Teagq2GHcnUiryPWWScE3lmkfSw/Q2p9HMCd/edngG0286FTXqEE92?= =?us-ascii?Q?QqdXUglsairWZ2UGqfaRLAmKMaO3AYVoJHFf2Erz117M4itEehb8hVUL0tWO?= =?us-ascii?Q?qDQ1cbQ0XgT3/86DHnAgs6oTS9HqNteWiaSrdc9Nosimz01D02wrhlpzeoRH?= =?us-ascii?Q?tdeypjFoFXyGbSShUhzHZmtnQCqgVgfYvoCXiaFAGLiZhrlKYd7CJYcpkrln?= =?us-ascii?Q?JucNXUNAuj0mxb0KPq0Nduyqgw3CWkhvnMJqJxom37vCaFTR4fZhC/qbuQDr?= =?us-ascii?Q?G4kHqYPT2Yi3v9sQSNCpk7BGYUaE+VCt2Q=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6e454.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 669680fd-2f9b-4392-e113-08da0d6e57be X-MS-Exchange-CrossTenant-AuthSource: PAXPR06MB7760.eurprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2022 08:14:40.0411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR06MB7884 Received-SPF: pass client-ip=40.92.90.93; envelope-from=ignaciocasso@hotmail.com; helo=EUR05-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648109738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Nj4lLrWDTju2IlptTXZyrqiRLrxzVWqtSQ4XbsA96jY=; b=X0m9YYlwEZ6NJhK6IopUGsQGvQELSczsCOuf/eJazTy3CjmU3oIJAZpqJBEDxyb+OPm3Ny JUsjWYbxub156D4bd7JSrg2DVNXi9i+MY0Rh9tdpB3zk1OJdZs6hII5KVnsoHudl9lvGOQ niU1sh2MX/PeHLx0ZgGhCxEWuMsFrqpHhm9Y6gcuaRhjnbV9B+Zp69ar+HJXGEo5hAPT+C /K4f0niF9C28zr6ufGdiKBM/jm1p1mF5CqCeuEkTDgzQyfcwhYJWSHtkiMkOUZGIVD7nqk CB8xzYEe1weVAFtwlvf2SWQmVZQDTL92tl6uqNokTIabaxH7cUfUD8B5e9guXQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1648109738; a=rsa-sha256; cv=pass; b=fla5fv0N0b41mQH1m4BU4WB2cBYkYAcFERTADObmMV/p+9d7gRvHTGDnuSWz/s7K+Iv+8w mOpIC3hTZ6nQcVYcm/WEHV9yq99BBkNpKMenlpRYCcekt6lTnuYncV6v8pQm5Xp+zOob1B WBJqfsluYTcvy+YyZmseiQu9HSbkYEcFgDamM24knTrkdAuOukpbj+dx4ecppy7k3P3ty+ RJPzFX24R56pgeM+uY+EYVYllGUbhA/KGy+S36IIaty0HzqQ67ve4bdr+0F5o0Rz1GTiKu li/5zDsZeUjPmyhlIKkg5B0YFRmqZMm7UDbac76y1RIhAnbrim0rxLtNyoX34w== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=uxkL1i6l; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.59 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=uxkL1i6l; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3637E3BC85 X-Spam-Score: -6.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: GagIVrCmAHi0 > The following patch should fix it: > > [4. patch --- text/x-diff; 0001-fixed-bug.patch] > From bc5092fdef512280b7d7d3aa04f1ba887360a759 Mon Sep 17 00:00:00 2001 > From: Ignacio > Date: Thu, 24 Mar 2022 01:15:44 +0100 > Subject: [PATCH] fixed bug > > --- > lisp/org/org.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/org/org.el b/lisp/org/org.el > index 67c8f1cedf..0fff28af81 100644 > --- a/lisp/org/org.el > +++ b/lisp/org/org.el > @@ -9063,7 +9063,8 @@ org-offer-links-in-entry > (org-back-to-heading t) > (setq end (save-excursion (outline-next-heading) (point))) > (while (re-search-forward org-link-any-re end t) > - (push (match-string 0) links)) > + (when (eq (org-element-type (org-element-context)) 'link) > + (push (match-string 0) links))) > (setq links (org-uniquify (reverse links)))) > (cond > ((null links) Actually, this fix would suffer from the same problem as the fix for the issue of org-agenda recognizing timestamps inside source code blocks, and now links inside property drawers would no longer be opened using C-c C-o with point on the headline. So if we want to preserve that behavior the new lines should probably be (when (memq (org-element-type (org-element-context)) '(link node-property)) (push (match-string 0) links)) or something like that, with probably more element types in the list beside link and node-property.