From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2EfpLZAUaGLvygAAbAwnHQ (envelope-from ) for ; Tue, 26 Apr 2022 17:49:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iPXqLZAUaGJEiQAAauVa8A (envelope-from ) for ; Tue, 26 Apr 2022 17:49:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51EF4F84E for ; Tue, 26 Apr 2022 17:49:36 +0200 (CEST) Received: from localhost ([::1]:36194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njNRX-0000bM-Ed for larch@yhetil.org; Tue, 26 Apr 2022 11:49:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njNQ8-00087d-VJ for emacs-orgmode@gnu.org; Tue, 26 Apr 2022 11:48:09 -0400 Received: from mail-db8eur05olkn2041.outbound.protection.outlook.com ([40.92.89.41]:53217 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njNQ6-0004zU-Rb for emacs-orgmode@gnu.org; Tue, 26 Apr 2022 11:48:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=epeuqE7K/MJSTSoeJyP8+DzhSVSCAVpavAstXW7WUJJvRQ0dZGwHoyKGZkyhaOtCHn0HOfl4J+u/gHFUd4sK1JTMo82GJ6O6VuPUXXpWdsdWcKL61NOBYbMxL/11Yylh2KRpx1uemOG3mXJfgGdYieJmra5xj4B30Wo7AtHgvEzXYiQnuF0jlqNLnGAbTDWAJE3/4393ns7yag1Q3iWtthjhNaQP6n4oFCE3S2VYr7AzWpD2wGlr+2MJfkDBCauQku/crzWAg6DUHddkNgIU2qNKDksU0KcwxTTZHf01BEHkU34sEKc9WwfqchDlDaXAPtel/HlJ75ytQinfyBTHbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HrplNBGnIWDyAA4GdFFuR8pqmrTALNm4PbmpkdoReOA=; b=mGJBGg1lLwa1RcWFkvEBXYhKTBsSGCjRzlSzrI+Ai19CNZh6Fq/OPj6W69xcp3QA+eOYQ95GOcYO9HflUWtmEprPOectqUmjErA3HAnXtIwiXrYn1FUssOLv652XQxSNW5/XrtTQCbfaz87wU53xSlfYJqD9oLAovdMqo5zY/U8ZO962iv6/T1NejP/jEaS22LyUg7Yz0mTyBowqa6E1p2kKQmRIQxF3qX1twbqEm1Ccqf5vB/ydXcEuh9blnGQawP9hgY6EQ/uSZ0VoyFXhTFdC/UoBAvjIj6CAO7n2bao46jeQfiyKOTSsJ3p0ecqBAyVvMuxeIl2LBibiuUnRjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrplNBGnIWDyAA4GdFFuR8pqmrTALNm4PbmpkdoReOA=; b=iQJl6SGUkuXpxq431qxcqMoFg6m9ie/IOw+tDIimbEdyrqs7hnnGxn2mw7ivNmzjlPdgjK+qcCqd2ikW/zzdxvk7g9KkTciZu4hDr8WIbDcac6sAbNcCB1Sa81Zvr3SgJgmkzFcIkv1LnRaUf3XqWjOLPQLYwn5hUn113/VRV1ftXd18F6CYOeBzIMwVkqFYPLih6+e6k0Vh5Oq/slrTN4oDbDEysnsOuUlP53oNduhzQliOaMQwy3ExZ9AxfCxcnCivOkM8NJcwIBFiusu1QZrtGdSrLc8rGMsE1irhKnQwxM8TYmJxM+tGUI6RV5CAtdyDWRz/xhy2k7t73IyzQw== Received: from PAXPR06MB7760.eurprd06.prod.outlook.com (2603:10a6:102:155::8) by VI1PR0602MB3518.eurprd06.prod.outlook.com (2603:10a6:803:11::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 26 Apr 2022 15:48:04 +0000 Received: from PAXPR06MB7760.eurprd06.prod.outlook.com ([fe80::3d50:522e:f03c:6225]) by PAXPR06MB7760.eurprd06.prod.outlook.com ([fe80::3d50:522e:f03c:6225%7]) with mapi id 15.20.5186.021; Tue, 26 Apr 2022 15:48:04 +0000 References: <87y1zvlyj0.fsf@localhost> <878rrsut3o.fsf@localhost> <8735i0vtn7.fsf@localhost> User-agent: mu4e 1.6.10; emacs 27.2 From: Ignacio Casso To: Ihor Radchenko Subject: Re: [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)] Date: Tue, 26 Apr 2022 16:46:31 +0200 In-reply-to: <8735i0vtn7.fsf@localhost> Message-ID: Content-Type: text/plain X-TMN: [YETPZxkiqWdoyNtf9k7tjgRij5NRbgJ9] X-ClientProxiedBy: MR2P264CA0136.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::28) To PAXPR06MB7760.eurprd06.prod.outlook.com (2603:10a6:102:155::8) X-Microsoft-Original-Message-ID: <87y1zrethq.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 240f2752-f715-4889-55d1-08da279c25cb X-MS-TrafficTypeDiagnostic: VI1PR0602MB3518:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rE3YLyQD2hftSOmKg7Hqq7FKh1Za4tkrkJwj7SyZU48OC2v94zK85f+ehpJpMSZ75hfWvf8QkSw8U91XhuhG2c6q2ea+Y5DNoc49iOdzdaCTEWjf3feHYnxwX/Dvi4yxBiOoGqQjzHlyPIR+3E7kEW8ACftxVVhnr5GixjvlKlxPXa6Cg0mSPafQKj++6MDmWTkw9c1tEzhtJb+LJ7ecYEFF7WBnY65tMXjUHPsB2XfMDFmhEXq8VYvDSLzhqbJ5x1wwPypLBq2e36aEEl+8e36JYaFmx5yD18AOpgGVC2VAfHEoBHCkbdteWAWnoyMVUv6C7Kff5x8gYrsbNvLcLbtK0F1QXby9lKUB77VoZ/qukXiXy5U1ehXSx0KFZIYmhRRCCzrhrJJpsDH0PrI0GC0WTN9V5gFrnrPt1Wx2RN0UmP8tk45SRuZDXAwzAHA6mXaGcTA5adCixbF4yZsVwAyatBsHaTvJc6LYjA3Utmg8mbHUi8F0fomQ6qi+weTtHwkA/pAsH4rYZ2RUzKVEC6lBdyiN5yqGVKHBqzwnCF1DtVvmdWqFx1SHaV4DFreqeizBgZ9BxAS0BSTFifXLkg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tRf8sI1tHnRp8MJ6Dx8FOraok6bC3LgZkQixxcmeNiwVNu2RNxQSr6Jquqa7?= =?us-ascii?Q?9Au2qPBnzBtRH3u6ZMA9WSYmkhJ2rd90bHrO06SQQhTO466Qow+D8W1iOFMu?= =?us-ascii?Q?w2gPnztko6irZ8DcJcrVf6sWwjM0deRhXwU9kheGaHatg0dRBamdAe9jH2cL?= =?us-ascii?Q?Mbbu3veSpw/awgr6CLXzZCZ1Jw4GSoxpttbrvYrEOV1WsXwhPnReyUFpxNS9?= =?us-ascii?Q?jTl1uTXtEI0/qOdenzbwv3zKARnHjPiBcEBtTv2n0iKd+MNeE6nNYxFIsZbA?= =?us-ascii?Q?hN/nVDJGhKnQsagxhEZpNCJ9hfhvmw5RGjC5EmUiKA489MBPFPk49Q7C4IPM?= =?us-ascii?Q?QW69PxmXalO7t7kHdRYaU6weX5lxfXxNztZz9uz6skg0SnPcKubkvNf+pny7?= =?us-ascii?Q?ezbrxdEw0p53OS8J3m11xyyL7Pm/N6fdNLenOnxjTN7/RP/nZwY7ozr823B5?= =?us-ascii?Q?DVkxFyGljEd4bRHGOKcO0uwKmAqFNrmRsPoxOthB+mv9VBiMt7Z5tzZFq95o?= =?us-ascii?Q?kbLqW3Y20xdoRAarNpgf+DLpA/dZuoM1+o3B1mZiLAMboWSTwHfFU8qtBZoe?= =?us-ascii?Q?comTIe2k/3cxwHZJWHlAXOKAIDdGYO3rJOMDmC5/5EFv46HkRYo6kKxLnIVh?= =?us-ascii?Q?Xssk8UBJCVTe1atY4CIxoctM7pCcnqK7wCmmuy8RloKcPIvC8A1X23jm4Dfr?= =?us-ascii?Q?07FEzcaQkqF/LxW+rPs8JKElXXL0K3vBMPgcrGp/ZMV0wk/qhnVaqg7HAA7v?= =?us-ascii?Q?dUyBavZpXdxinOVax/0skW5b/msAlGQ6krZRjUS6p3xwlcuiOkinkfQZ37bS?= =?us-ascii?Q?MWN59RFXU95U/73H/9TZxYLHtCQLn7dSFY16gLR0UB5NlqIoMV7rXH7af44s?= =?us-ascii?Q?TcSrtLEod6UdmY1dyo/KanfSRKLZzLuuWLkcnI2n+ZvmGTYD8hEleoaNmhpl?= =?us-ascii?Q?ZTRzjYGQ8lTEY8newWvZprRJsUsdzclaqr9U0Qu+MKCzWsnhQ5kDNMD4tmXr?= =?us-ascii?Q?Bk69QuKWRpz2nN7jnaPgSVbyjHBUBVNdwgqqKVZxcM6jc4GsjVsneHSoNSLj?= =?us-ascii?Q?AFN7b0ImTpgG5tcLNJnYo0IdHri2wjSzezKO3qpIsKXl/udOCqsW578oqPCd?= =?us-ascii?Q?YxWqsThysM3d0XAb3ojR/uoxdovsEYhMrOfoLRsDADo7FMoa6Z84ZUEaq1RW?= =?us-ascii?Q?BK2nXL33FUrtydrDmbCJife7oNIWm80Ut6fNVtiqg3TXq6y1VqIX0XBRriV3?= =?us-ascii?Q?nprzMEIcVTLr2TD2fRwIBrVt8NKM14bM98XwHK+Lz/IbsQE8+Lacof5pxU87?= =?us-ascii?Q?G378+Cxj8txfgzCITqqtmzdCY37reKB3JU3atl/ZP0+i4MpQqsKYpa2t4q0a?= =?us-ascii?Q?HWN7Ey9RRFI55B0MLgR+Zy8kL0hbhyljm5m0BIFS8zYLbsOcZ6dETMmPQNm1?= =?us-ascii?Q?LcBl68P3r7I=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6e454.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 240f2752-f715-4889-55d1-08da279c25cb X-MS-Exchange-CrossTenant-AuthSource: PAXPR06MB7760.eurprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2022 15:48:03.9746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0602MB3518 Received-SPF: pass client-ip=40.92.89.41; envelope-from=ignaciocasso@hotmail.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650988176; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HrplNBGnIWDyAA4GdFFuR8pqmrTALNm4PbmpkdoReOA=; b=gN4TUjXAS4cZdz+8kW1ZLgKyYZK4evy4DFuyEpvh4q9j7CeWh9w4SSt3Mol1iYdrgVn3Ma is8YypRvTJ6Egojiw7s7Qq80lDqTknoXvemZnsdaBX4S/tVVcsf198Rx6wyAUXWNkinKSf 1aFrUdPYCj/Zt2qKRCFUJg0ucNfdAAhs0ieEwTjDtbzn4w76+vUTULSyGwHJ736L2V0Tbc TOcpUYGszT8zYATgBhDElVeFbrTVlA/l7v58jo6vLztOLfoY1EPoYzsIpCKi3IhBEcTk+y V1mvhiAwTQyuhftMgjAM7/9XuKYm+d2LzH2pkEeVxxhdL96wS9WcV0x1EiRlIw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1650988176; a=rsa-sha256; cv=pass; b=tgBMubzc3zrPA/rKwmoi2Rp9H8QwcV/2CEjmk/+1JUYu8RSC1ZewDodzExJs8Rvf2oa1sF D+DnHGjS9x/PjG3XK28E2pVCMLA64rekipW/k8H0rq6RPx7Ccf6KJITiDbtixTX6ZOmnDp /lqs8FYnSN5rmrPfjIsrPR/HcEAgjK1JusNvkm67+CiWXL64GyEHB0eCqGZ5/7yBU7WINj wsRpzUYh+MEX94CDXNQZGpQ/GNBD7oMTrGEzwrlrUa15xlneOm/2owqdTX5w3GDj3HkmEc cFMNVGPsPexdfRX3RA7OosllxQWABqjbQeXfMAbh+sCOKlb2DaUhD/KtJo+8aA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=iQJl6SGU; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.81 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=hotmail.com header.s=selector1 header.b=iQJl6SGU; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 51EF4F84E X-Spam-Score: -9.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: Nw60YvypjJgq >> (cond ((org-in-regexp org-link-any-re) >> (let ((org-link-abbrev-alist >> (append org-link-abbrev-alist org-link-abbrev-alist-local))) >> (org-link-open-from-string (match-string-no-properties 0)))) >> ...) >> ... >> What do you think? > > I do not like this idea. There is also org-link-abbrev-alist-local and > potentially other variables to be introduced in future. We should not > rely too much on internal workings of ol.el. > > A better approach could be using org-link-expand-abbrev. It is an API > function and should be forward-compatible. Do you mean something like this? (defun org-open-at-point-global () ... (cond ((org-in-regexp org-link-any-re) (org-link-open-from-string (org-link-expand-abbrev (match-string-no-properties 0)))) ...)) Right now that is not enough because `org-link-expand-abbrev' only works for links without square brackets, like "abbrev:suffix", and `org-link-any-re' matches links with square brackets, like "[[abbrev:suffix]]". That could be easily worked around in `org-open-at-point-global' but maybe it would be better to change `org-link-expand-abbrev' to work with both forms. Let me know if you want me to send a patch implementing any of those options or any other that you see fit. Otherwise, I know enough now to fix the issue in my own config, so we can leave at that. Regards, --Ignacio