From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eJOTENAa3WKc9QAAbAwnHQ (envelope-from ) for ; Sun, 24 Jul 2022 12:11:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wHWcD9Aa3WJKXQEAG6o9tA (envelope-from ) for ; Sun, 24 Jul 2022 12:11:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB5AF15326 for ; Sun, 24 Jul 2022 12:11:27 +0200 (CEST) Received: from localhost ([::1]:45888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFYa7-0006Wg-2b for larch@yhetil.org; Sun, 24 Jul 2022 06:11:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFYYN-0006WY-DO for emacs-orgmode@gnu.org; Sun, 24 Jul 2022 06:09:39 -0400 Received: from mail-oln040092064041.outbound.protection.outlook.com ([40.92.64.41]:20776 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFYYK-0004aj-Rc for emacs-orgmode@gnu.org; Sun, 24 Jul 2022 06:09:38 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ylq+9Y8/x2H3zMrHB/eoK6oh6Xu6TEYEanfSX/WewTCTaAKfg1xcSx/P6xDKTMIKkjRIXmuN7oOpuJreXF/XCTIIRTfjms6JZ/S3uxmUhQhuMdS+NurHLBa1oWW27yb6f8Jakxezjt7fdQIc1uCkTSUnm44aQM+lQVcEF9UiH+y+ITPUV/eJl6o2XsHG6PLIeVKggUx1KOuurdtVwdBfL9pRmUTQIx4d/37rRC2fjm1S60V6y76E/8yg8412ZHAsRtA1wy/lPq42aEUcucnKjj6a1qqfS1vXHO9TY60kXwaq09JRma/2/5GrQwXuwQIfdLGnqyri5/ycr3KSPrmFug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvwCFJ+HCTSZqQZHnBO918vVMIZHeeMr0+Jk7kIdkEg=; b=KCr3pIOOgbp7gr7c8ddr6MJ2TNl1O8Bd6JqUfqrGJcU7LX45grzwJzktaWG7GjjQSHCde/p8l0RkpKY5d5H6ayLmz5txDM/TwgM5Bny/VJ4qUc46Kc0aMrOSck+I2LN+dXAJO30Z9rdNi/kT0bq+sKPf8jGv9MV4ye7Rl4urnkJjZxiAw21wO8qAb5mjZKspNyMXfnP9juq5LgXfAFw6GqDGyzZ5ALtS4aaHSjqemGYWtZwLrRpuzmy1NhOHvUTdfXjKLEL3F4KfojS5y9xRpixWygsosB/kL+2vv4oZIOZKlnnmTrQMLNjdJtqkAnZyhs70FWj1FX0EV/kIiwFywQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PAXP251MB0470.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:283::11) by AS4P251MB0752.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:507::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Sun, 24 Jul 2022 10:09:34 +0000 Received: from PAXP251MB0470.EURP251.PROD.OUTLOOK.COM ([fe80::f881:eab3:bd1d:bcf5]) by PAXP251MB0470.EURP251.PROD.OUTLOOK.COM ([fe80::f881:eab3:bd1d:bcf5%8]) with mapi id 15.20.5458.021; Sun, 24 Jul 2022 10:09:34 +0000 References: <87y1widf0h.fsf@localhost> User-agent: mu4e 1.8.5; emacs 29.0.50 From: Kenneth Stuart To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: Bug in definition of org-encode-time Date: Sun, 24 Jul 2022 11:06:56 +0100 In-reply-to: <87y1widf0h.fsf@localhost> Message-ID: Content-Type: text/plain X-TMN: [kV0XYKBHd2Umx28aIgk10qdTkqtBxEX/] X-ClientProxiedBy: LO2P265CA0216.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::36) To PAXP251MB0470.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:283::11) X-Microsoft-Original-Message-ID: <87tu76n7oi.fsf@hotmail.co.uk> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bc62226-6aa3-498f-9b17-08da6d5c9b9e X-MS-TrafficTypeDiagnostic: AS4P251MB0752:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JiSTQMLWzpC/0FUIQ3GUPJabFJ7xKjW88ff9rxZUCHNKeCqVIIwfgsMGSKkfBKYfDf/RHBS9TcU173LTxBq+pMKeYqDi/ggheXzN8s59aM9W2zCQ3CUwbeZOBLvH859rXHWR6S3RjIijJmcDuNQ0uC5sYT7jnMnSaU451aEJcNcWq5mm7jV7NKY6dBIkiVRHihznO3WmyzroWr/TViYY+6kkTCAYt1FU9zjVPWCznIh9unZJBtVZZ+XDXcgGWenJ6HC1RyKyfw+hnxuZB7KgQR4zZudEe7xaUJXcedbTfbUZUvu4ShSoXPQgB6g8TAc1NRXfguCbeARYFxbVbtcznceA43dv+PNj1ElFAM0CaN6+VAqdRNpmk/uOhr8nM+P1gK+JV8FaCJrHlf7+QLWsgGci+RuG3Nba7ous6yryO9lLpU0Jz7/dA/ggcXSGvRko364P9QvpaY+SCm18utGckhzxj9wvu7UPfYlnar7l+FyF2G9SHXxIh2alVZotSnZtVT9nQDQhne1+eGNnAuS2mAd87UBZC7vvWa8HTE4UyLQTamTiivwRtKoQmVkppgbES9XhDe3L6BycX1FYcnNu8T3mIxhA5JtFouA1/x709CobpI+j5ha7DqxD0R1BgF/s5Kk8V3InI+j8V7tq871DS8i9IV2kL4XFdzEzTDYynWirfMZrhsRS9cFuvKZcg4mL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i1pk3RhMDjV7YhVcIzFOmMmOhYo/6bKKtq2TE7+tPLeGd5+u6VKHlrgNo15E?= =?us-ascii?Q?vwUlq0h+1gFw/dO6+bGZx1q+19+J2WnuqoJy65LWCSMSWVFIwXk7Lu1ptg+e?= =?us-ascii?Q?nOumnpUitNgZ/E/mAZXGAOGxxBXNALdmoF3U/3mTca3Cx51KWzxlrxm2tzHD?= =?us-ascii?Q?ladJCwJaKty5rfLjdiGSRqY43+rMzbppY9qTHSdzOSeM1Tj2dtOspRkjtbKm?= =?us-ascii?Q?tQU/xFNcHhK+UZFysEkXdMYZFVp5nPs91O4pQDBIRNNxK6iW+b5gIUu8dc8D?= =?us-ascii?Q?q4U4N20yQOMRlRDUjW3CkYMbTHUuVpk48ItctUuE+MH38MnNmuRANSFzKhnZ?= =?us-ascii?Q?Ah3AWaGUEXebWwV5qqujuisH8S6Uw86LNANVAAQlX0TQNdXBEmN66Ygoh3v9?= =?us-ascii?Q?EXcjl8/GcyfOOigfg31AxTXF8OMfgM17MMhOeu/Cch4IGb5irAJxi8G7MUWi?= =?us-ascii?Q?KOLZL1VV7qw6ffGpYZ756/e3Kipdb4Nwu/dS1tNqFsaphhA2NkEsFEh7z0yU?= =?us-ascii?Q?WMWA3x+rhO22tmVRINslq7w+X60KmIDRE6fSCnbJ9p25cBRLmkZKeMYsdzNi?= =?us-ascii?Q?pz13nx3xIbdTuiTubB8IcFkiqFZsCi4H5xAeVlF5pyWpiPrXlO4sn2U7THJ3?= =?us-ascii?Q?UpyT07NscV7gNxTl34zfVA0aTfI+K2kPlAZTUBpe+jLOIAU1jom3/lHrTLZe?= =?us-ascii?Q?zBmTgphgJ6/+OJUzBWR0FpJLHKW8mCS3wP7AZ5F5qOo4wlgmjVNJ4EzWB8h1?= =?us-ascii?Q?PdA5nHtY9kbog8KUrdtithiCwertA8UDtVayDAE/sz++hUBZCyPlBrknRoMw?= =?us-ascii?Q?rmIQb7TB9pMjRN+DOD0nh9x0GKOVzB1+HbU1el9Yfn5jhHMgCWYotws/nj1S?= =?us-ascii?Q?QueFuM4Nxik2tpMMUOtnDAp3Ltlk3IXSuIfYpe3DI2aJc4NMEf1mZ3iRA7IE?= =?us-ascii?Q?PguYodVOle8S8bLHtYt+2BpO1DmI1f+fnQoXTwvMAm0oLjvMBCVi3BzoFTMD?= =?us-ascii?Q?cuvbN2uM65RxYqcURYCp03JGccJjLAxNNEi9dcp5gewvCzzWlG7FUi8nSYpx?= =?us-ascii?Q?9u1s6uyTnbNVE9yQ9lymK9y9rCMZB5qFGI7GQx3cm167x2v1nrPi34PRo8yn?= =?us-ascii?Q?+PxDbSc/BS5TqP4qZP3L/9wLp/JjVeWJedhwOMUzrnFPADjSxoorzscs+qnD?= =?us-ascii?Q?hiZY9wFeeEWFdD/EkH0ixaW7+QEkWn243fUcxNr47Y8JMUR/mg6yD5ssvchD?= =?us-ascii?Q?50hLEydLW80KNDKbUPd5tdzekSTOKsFpddpf3XcSKA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-00b75.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc62226-6aa3-498f-9b17-08da6d5c9b9e X-MS-Exchange-CrossTenant-AuthSource: PAXP251MB0470.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2022 10:09:34.3971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P251MB0752 Received-SPF: pass client-ip=40.92.64.41; envelope-from=kstuart@hotmail.co.uk; helo=EUR01-DB5-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658657487; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=PvwCFJ+HCTSZqQZHnBO918vVMIZHeeMr0+Jk7kIdkEg=; b=DFHoPJ8+g18SkrU+rRzc+4g3mtcl2oSRq7vVQ8+zCDf2a7Q2mi7qvZJT5N/XCjV3bOVmfN t1gZ4A/n+lXfUhst+dqQVKO6dvbLwn6M+oHF7/YvHP/BBvvew6/UtDDdL97d627WFPEOoF 3BbYT+qGT7b25AJGjyIkIePBiLF42E6X3ikQf5PYlO+oSNz2Dkgl8qADg82VwCgJBMltBz S8cX9mc6GBlovwIZhDQq402G1UMdpFejAKeFW1NqPeGK37Dvw6DhWWZEIOQPZf+IREwanT XMq4pxURxNyAwI5zAlN40rlo9KR5WT/uYRxS5lV46TfMWsQ3iXXf0K1onPvwPA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1658657487; a=rsa-sha256; cv=pass; b=qEn52WUMSQvtraRyM7e9CKqV+NIwrjdJ9z1nImnUNPGqiCNbLF4Qxg8vxZbYRmwAMuECgt 0jelQdeX5bzi2noFOLHuf8t/2Jeee7oQkba9QInY0KYTnkNTT/7w9yTy3VptbLAkFEFueB yxViCweGjqHOEjaOCwrMDATPNkQbopLUYZZIPWsP43d+vWxanLaaGL0kDJ/5NwbZggUYuR rEYf0WLbrcpHM+vE8xBZLcv08xACJ42bFOhg42QPkZcmc6XIVTQ/qY3jemULXnsdI1AhIo 0Vshm/xYgqGdz6c7T8OXEeKZ2NGp9tEKU1MpHnotBPPYS6b+8WPalCpbhdH8SQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=none; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=hotmail.co.uk (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.53 Authentication-Results: aspmx1.migadu.com; dkim=none; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=hotmail.co.uk (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CB5AF15326 X-Spam-Score: -0.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: hzFZIFIkG2cv Yes, you're right I should have looked more closely, I also see 'Morgan Smith' has already raised the issue more clearly. Please ignore the noise ;) Ihor Radchenko writes: > Kenneth Stuart writes: > >> Macro `org-encode-time` (lisp/org-macs.el +1395) does not get defined >> for emacs >= 27.1 as the top level if statement is missing its ELSE clause. > > Are you sure? > >> #+begin_src elisp >> (if (version< emacs-version "27.1") >> (defmacro org-encode-time (&rest time) >> (if (cdr time) >> `(encode-time ,@time) >> `(apply #'encode-time ,@time))) >> (if (ignore-errors (with-no-warnings (encode-time '(0 0 0 1 1 1971)))) >> (defmacro org-encode-time (&rest time) >> (pcase (length time) ; Emacs-29 since d75e2c12eb >> (1 `(encode-time ,@time)) >> ((or 6 9) `(encode-time (list ,@time))) >> (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given" >> (length time))))) >> (defmacro org-encode-time (&rest time) >> (pcase (length time) >> (1 `(encode-time ,@time)) >> (6 `(encode-time (list ,@time nil -1 nil))) >> (9 `(encode-time (list ,@time))) >> (_ (error "`org-encode-time' may be called with 1, 6, or 9 arguments but %d given" >> (length time)))))) //MISSING ELSE//) >> #+end_src > > This is equivalent to > > (if condition > (defmacro ...) > ;; else > (if another-condition > (defmacro ...) > ;; else > (defmacro))) > > Best, > Ihor