From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: Wow -- adding images to an org file Date: Wed, 12 May 2010 08:07:37 +0200 Message-ID: References: <3950.1273620034@iinet.net.au> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=38128 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OC56g-0002H8-MD for emacs-orgmode@gnu.org; Wed, 12 May 2010 02:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OC56d-0006QL-Cu for emacs-orgmode@gnu.org; Wed, 12 May 2010 02:07:46 -0400 Received: from mail-ew0-f216.google.com ([209.85.219.216]:51401) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OC56d-0006Q3-6g for emacs-orgmode@gnu.org; Wed, 12 May 2010 02:07:43 -0400 Received: by ewy8 with SMTP id 8so1655410ewy.8 for ; Tue, 11 May 2010 23:07:41 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Baoqiu Cui Cc: emacs-orgmode@gnu.org On May 12, 2010, at 7:39 AM, Baoqiu Cui wrote: > "robut@iinet.net.au" writes: > >> I very much like the idea of native inline image display in Org- >> mode but can't >> seem to make it work. >> >> Given a 6.36 snapshot or 6.36 release and these org file contents >> >> * Test image >> Test image >> [[Screenshot.png]] >> >> >> I hoped org would display that image after C-c C-x C-v. Rather Org- >> mode returns >> "No images to display inline". >> >> I've tried different ways of linking that image, different image >> formats, >> relative vs complete paths, and my regular .emacs vs a near empty >> one and >> always the same result. If I toggle iimage-mode the image displays >> fine per se >> but does not affect how Org-mode works. >> >> Seems clear I am missing something simple. What? > > I like the idea of inline image display too, but hit the similar > problems. After reading the code in org.el, I found that the inline > image file link has to start with either "file:" or "./". > > For example, the following two links are OK: > > [[file:~/images/myImage.png]] > [[./figures/org-mode-unicorn.svg]] > > but the following two are not: > > [[Screenshot.png]] This one I do not want to support, because it limits what other things we can do with links. > [[~/images/myImage.png]] This one on the other hand should be supported, I like that. Can you please modify the patch accordingly? I believe this will also require corresponding changes in the exporter(s) somewhere... Thanks! - Carsten > > Here is a small patch that seems to work well for me, but I'd like > Carsten to check whether it may break anything: > > diff --git a/lisp/org.el b/lisp/org.el > index 0381a26..5efc162 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -15502,7 +15502,7 @@ with a description part will be inlined." > (interactive "P") > (org-remove-inline-images) > (goto-char (point-min)) > - (let ((re (concat "\\[\\[\\(file:\\|\\./\\)\\(~?" "[-+./_0-9a-zA- > Z]+" > + (let ((re (concat "\\[\\[\\(file:\\)?\\(~?" "[-+./_0-9a-zA-Z]+" > (substring (org-image-file-name-regexp) 0 -2) > "\\)\\]" (if include-linked "" "\\]"))) > file ov) > > Regards, > > -- > Baoqiu > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten