Re: Unicode TODO keyword issues in agenda search leading to org-scan-tags regex

[Marcel Lauhoff <ml@irq0.org>]

> On 2022-09-05, at 12:29, Ihor Radchenko <yantar92@gmail.com> wrote:
> 
> Marcel Lauhoff <ml@irq0.org> writes:
> 
>>> Thanks for reporting!
>>> Fixed on main via a1c923afd.
>>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1c923afda22089cbf14c7b7a175cee10bfd297b
>> 
>> ┌────
>> │ -		     " *\\(" (regexp-opt org-todo-keywords-1 'words) "\\)?"
>> │ +		     " *\\(" (regexp-opt org-todo-keywords-1 'words) " \\)?"
>> └────
>> 
>> That change doesn't seem to work for me, but maybe I'm holding it wrong or missed a follow up commit.
> 
> Oops. You are indeed right. I forgot to remove the 'words argument. Now
> fixed (hopefully).
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eeb4fa8c09e6e21b86bec51328e53b4adf662945

I think it should be

" *\\(" (regexp-opt org-todo-keywords-1 t) "\\)?"

1. Without the 3rd argument regexp-opt generates a non-capturing group. 'word generates a capturing group.
2. With the additional space in " \\" I'm no longer able to match any todo in my org files.


> 
>> The following snippet tries some regex variations matched to one of `("TODO" "≣" "TODO " "≣ ")'. a1c923afd does seem to require a space after the keyword now:
> 
> Org requires a space after TODO-keyword in headlines. TODO-keywords
> themselves do not need to have space.

Yes, I added the space variant to test the "\\)?" -> " \\)?" part of the change.


~marcel