From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Underlines and strike-through lines in column view Date: Fri, 16 May 2008 17:20:06 +0200 Message-ID: References: <48109F6A.4020203@gmail.com> <3234B746-6FA4-4BB9-BF25-EC3580C1C877@science.uva.nl> <4818E3E0.40808@gmail.com> <48222BF8.2020604@gmail.com> <48230EFC.2000307@gmail.com> <482C757E.1040101@gmail.com> <91A9307E-412F-49B4-9A65-43CBAF26DD02@uva.nl> <482D9FA3.8000800@gmail.com> Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jx1j7-0006kV-QO for emacs-orgmode@gnu.org; Fri, 16 May 2008 11:20:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jx1j6-0006k3-5I for emacs-orgmode@gnu.org; Fri, 16 May 2008 11:20:09 -0400 Received: from [199.232.76.173] (port=38663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx1j6-0006k0-1v for emacs-orgmode@gnu.org; Fri, 16 May 2008 11:20:08 -0400 Received: from korteweg.uva.nl ([146.50.98.70]:1736) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jx1j5-0006MF-Fd for emacs-orgmode@gnu.org; Fri, 16 May 2008 11:20:07 -0400 In-Reply-To: <482D9FA3.8000800@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Wanrong Lin Cc: org-mode mailing list Hi Wanrong, the org-column face should explicitly mask all face properties that should not shine through into the column view. Therefore, the default org-column face has explicitly :underline nil :strike-through nil and now, after looking at your config, it will also get :slant normal Your configured org-column face does not set these attributes, so whatever is below will shine through. Phew, finally this is resolved. Please customize the face and change the face accordingly. - Carsten On May 16, 2008, at 4:52 PM, Wanrong Lin wrote: > > Hi Carsten, > > Attached is a minim emacs config file I made that can reproduce the > problem using "emacs -q -l minimal.el". The first line of the file > add the load-path to the org-mode package, so you may need to change > it. Also attached is a simple two-line org-file that you can open to > see the problem in column-view. My face settings are for light > background. > > Besides those strike-through lines and underlines, I also noticed > that there is a light gray vertical line in the "PRI" column. It has > something to do with my use of "box" face for org-column, but I > wonder whether that can get fixed together, as those strike-through > and underlines start right from that vertical line. > > I am using the official GNU Emacs 22.2 on Windows XP. > > Thanks a lot for looking into this. > > Wanrong > > > Carsten Dominik wrote: >> Hi Wanrong, >> >> I have lost track a bit of the details, so in order to fix this, can >> you please make me a test case with a minimal .emacs that contrains >> your face definitions, and a small example file. Please make it >> work so that >> >> emacs -q -l minimal.emacs >> >> will reproduce the problem. Please also include the exact version >> of Emacs you are using. >> >> Thanks. >> >> - Carsten >> >> On May 15, 2008, at 7:40 PM, Wanrong Lin wrote: >> >>> >>> Feedback: I just tested again on org 6.03, and the "line noises" >>> are still there in the column view. >>> >>> Wanrong >>> >>> Wanrong Lin wrote: >>>> >>>> Just a reminder: do you have any TODO faces with strike-through >>>> lines? Remember the line noises will only happen when that is true. >>>> >>>> Also, maybe there are some other check-ins after your patch that >>>> fixed this. I only tried your patch, not the latest GIT revision. >>>> I can just wait until next release to test again. >>>> >>>> Thanks a lot. >>>> >>>> Wanrong >>>> > > ;; org-config.el, config file for emacs org-mode > ;; Time-stamp: <2008-05-16 10:42:58 linw> > ;; Tested with emacs 22.1 and org-5.14 > ;; > ;; Wanrong Lin > > (setq my-local-extra-loadpath "c:/linw/.emacs-lisp/") > (add-to-list 'load-path (concat my-local-extra-loadpath "org/lisp")) > (add-to-list 'load-path (concat my-local-extra-loadpath "org/CONTRIB/ > lisp")) > > (require 'org-install) > > (add-to-list 'auto-mode-alist > '("\\.org\\'" . org-mode)) > > ;; TODO keywords > (setq org-todo-keywords '((sequence "TODO(t)" "STARTED(s!)" > "WAITING(w@/!)" "MAYBE(m/!)" "DELEGATED(g@/!)" "DEFERRED(d!/!)" > "HOLD(h!/!)" "|" "DONE(x)" "CANCELED(c)"))) > (custom-set-faces > ;; custom-set-faces was added by Custom. > ;; If you edit it by hand, you could mess it up, so be careful. > ;; Your init file should contain only one such instance. > ;; If there is more than one, they won't work right. > > '(org-level-1 ((t (:weight bold)))) ;; bold > > ;; normal text > ;; '(org-level-2 ((t nil))) ;; normal text > ;; Use the following complicated format because the above line does > not work very well > ;; with column view (in org-mode 5.12c) > '(org-level-2 ((((background light)) (:foreground "#000000")) ;; > black (with light background) > (t (:foreground "#F0F0F0")))) ;; > white (with dark background) > > '(org-level-3 ((t (:foreground "#800000")))) ;; > dark red > '(org-level-4 ((t (:foreground "#0000FF")))) ;; blue > '(org-level-5 ((t (:foreground "#006000")))) ;; > dark green > '(org-level-6 ((t (:foreground "#B020A0")))) ;; > purple > '(org-level-7 ((t (:foreground "#0060C0")))) ;; > green blue > '(org-level-8 ((t (:foreground "#4030C0")))) ;; > purple blue > > '(org-agenda-structure ((t (:foreground "#0040C0" :weight > bold)))) ;; dark green blue > '(org-agenda-date ((t (:foreground "#800000" :weight bold)))) ;; > dark red > '(org-agenda-date-weekend ((t (:foreground "#006000" :weight > bold)))) ;; dark green > '(org-scheduled-today ((t (:foreground "#0000FF")))) ;; bright blue > '(org-scheduled-previously ((t (:foreground "#181880")))) ;; dark > green blue > '(org-upcoming-deadline ((t (:foreground "#C00000")))) ;; middle red > '(org-warning ((t (:foreground "#C00000" :weight bold)))) ;; bold > middle red > '(org-todo ((t (:foreground "#B020A0" :weight bold)))) ;; purple > '(org-done ((t (:foreground "#008000" :strike-through t :weight > bold)))) ;; bold dark green > ;; hard coding it here> > `(org-hide ((t (:foreground "white")))) ;; same as background > '(org-table ((((class color) (min-colors 512)) (:foreground > "#181880" :background "#98D0D8")) > (t (:foreground "#181880")))) ;; dark green blue > '(org-drawer ((t (:foreground "#0040C0")))) ;; dark green blue > '(org-formula ((t (:foreground "#800000")))) ;; dark red > '(org-time-grid ((t (:foreground "#B8860B")))) ;; dark golden rod > ;; '(org-link ((((class color) (background light)) (:foreground > "#A020F0" :underline t)))) ;; official purple > ;; '(org-date ((((class color) (background light)) (:foreground > "#A020F0" :underline t)))) ;; official purple > '(org-link ((t (:foreground "#5050FF" :underline t)))) ;; light blue > '(org-date ((t (:foreground "#5050FF" :underline t)))) ;; light blue > '(org-tag ((t (:foreground "#008000" :weight bold)))) > '(org-code ((t (:foreground "#505050")))) ;; gray > '(org-special-keyword ((t (:foreground "#205060")))) ;; dark green > blue > '(org-column ((t (:background "gray80" :box (:line-width 1 :color > "grey70"))))) > ) > > ;; pale org-todo face > (defface my-org-todo-faded '((t (:inherit org-todo :foreground > "#7050B8"))) > "Face for to-do items in a background/faded state.") > > (setq org-todo-keyword-faces > '( > ("STARTED" . (:inherit org-todo :slant italic :underline > t)) > ("WAITING" . (:inherit org-todo :slant italic :underline > t)) > ("DELEGATED" . (:inherit org-todo :slant italic :underline > t)) > ("DEFERRED" . (:inherit my-org-todo-faded)) > ("HOLD" . (:inherit my-org-todo-faded)) > ("MAYBE" . (:inherit my-org-todo-faded)) > ("CANCELED" . (:inherit my-org-todo-faded :strike-through > t)))) > > (defface my-org-ellipsis-face '((t (:underline t :weight bold))) > "Face folding ellipsis.") > (setq org-ellipsis 'my-org-ellipsis-face) > > (setq org-hide-leading-stars t) > > > (provide 'org-config) > ;; org-config.el ends here > > * DONE Just a test > * STARTED Another test > >