From: Carsten Dominik <carsten.dominik@gmail.com>
To: Richard KLINDA <rklinda@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: checkbox statistics (fixed version)
Date: Sun, 10 May 2009 09:17:26 +0200 [thread overview]
Message-ID: <F2DA4517-0228-44E7-8F6D-EBD4AF5A5E08@gmail.com> (raw)
In-Reply-To: <8763gu8atv.fsf_-_@gmail.com>
Hi Richard,
I am accepting the patch, with one small change:
The new variable is called `org-hierarchical-checkbox-statistics'
and works the other way round, default t.
Thanks.
- Carsten
On Apr 24, 2009, at 3:01 PM, Richard KLINDA wrote:
> This is the fixed patch, it actually works on my real life org files
> so
> this has a slight chance of being right.
>
>> ------------------------------------------------------------------------
>
> diff --git a/lisp/org-list.el b/lisp/org-list.el
> index 7469add..872dddf 100644
> --- a/lisp/org-list.el
> +++ b/lisp/org-list.el
> @@ -110,6 +110,9 @@ with \\[org-ctrl-c-ctrl-c\\]."
> :group 'org-plain-lists
> :type 'boolean)
>
> +(defcustom org-recursive-checkbox-statistics nil
> + "Non-nil means, that checkbox counting should happen recursively.")
> +
> (defcustom org-description-max-indent 20
> "Maximum indentation for the second line of a description list.
> When the indentation would be larger than this, it will become
> @@ -402,7 +405,10 @@ the whole buffer."
> (org-beginning-of-item)
> (setq curr-ind (org-get-indentation))
> (setq next-ind curr-ind)
> - (while (and (bolp) (org-at-item-p) (= curr-ind next-
> ind))
> + (while (and (bolp) (org-at-item-p)
> + (if org-recursive-checkbox-statistics
> + (<= curr-ind next-ind)
> + (= curr-ind next-ind)))
> (save-excursion (end-of-line) (setq eline (point)))
> (if (re-search-forward re-box eline t)
> (if (member (match-string 2) '("[ ]" "[-]"))
> @@ -410,7 +416,12 @@ the whole buffer."
> (setq c-on (1+ c-on))
> )
> )
> - (org-end-of-item)
> + (if org-recursive-checkbox-statistics
> + (progn
> + (end-of-line)
> + (when (re-search-forward org-list-beginning-
> re lim t)
> + (beginning-of-line)))
> + (org-end-of-item))
> (setq next-ind (org-get-indentation))
> )))
> (goto-char continue-from)
>
>> ------------------------------------------------------------------------
>
> --
> Richard
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-05-10 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 10:47 checkbox statistics Richard KLINDA
2009-04-21 12:26 ` Carsten Dominik
2009-04-24 12:44 ` Richard KLINDA
2009-04-24 12:56 ` Richard KLINDA
2009-04-24 17:37 ` Samuel Wales
2009-04-25 8:21 ` Richard KLINDA
2009-04-24 13:01 ` checkbox statistics (fixed version) Richard KLINDA
2009-04-24 19:48 ` Eddward DeVilla
2009-05-08 15:27 ` Carsten Dominik
2009-05-08 23:50 ` Eddward DeVilla
2009-05-09 6:56 ` Carsten Dominik
2009-05-09 20:47 ` Eddward DeVilla
2009-05-10 7:17 ` Carsten Dominik [this message]
2009-04-26 18:05 ` checkbox statistics Marc Spitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2DA4517-0228-44E7-8F6D-EBD4AF5A5E08@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=rklinda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).