From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0Ey0KQU/3WNVOgAAbAwnHQ (envelope-from ) for ; Fri, 03 Feb 2023 18:06:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cO2HKQU/3WPECwEAauVa8A (envelope-from ) for ; Fri, 03 Feb 2023 18:06:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 551FF1BBBD for ; Fri, 3 Feb 2023 18:06:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNzVB-0000Yt-MC; Fri, 03 Feb 2023 12:05:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNzV9-0000YU-Dq for emacs-orgmode@gnu.org; Fri, 03 Feb 2023 12:05:27 -0500 Received: from mail.bundesbrandschatzamt.de ([198.7.63.95]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNzV3-00087J-PT for emacs-orgmode@gnu.org; Fri, 03 Feb 2023 12:05:24 -0500 Received-SPF: pass (mail.bundesbrandschatzamt.de: authenticated connection) receiver=mail.bundesbrandschatzamt.de; client-ip=91.64.203.22; helo=smtpclient.apple; envelope-from=baron@bundesbrandschatzamt.de; x-software=spfmilter 2.001 http://www.acme.com/software/spfmilter/ with libspf2-1.2.10; Received: from smtpclient.apple (ip5b40cb16.dynamic.kabel-deutschland.de [91.64.203.22]) (authenticated bits=0) by mail.bundesbrandschatzamt.de (8.14.7/8.14.7) with ESMTP id 313H554Y023689 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Feb 2023 17:05:05 GMT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Andreas Gerler Mime-Version: 1.0 (1.0) Subject: Re: [O] [PATCH] ob-eval: display error fix Date: Fri, 3 Feb 2023 18:04:54 +0100 Message-Id: References: <877cx886oc.fsf@localhost> Cc: Ruijie Yu , emacs-orgmode@gnu.org In-Reply-To: <877cx886oc.fsf@localhost> To: Ihor Radchenko X-Mailer: iPhone Mail (20D47) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.bundesbrandschatzamt.de [198.7.63.95]); Fri, 03 Feb 2023 17:05:06 +0000 (UTC) X-DCC-MGTINTERNET-Metrics: heimdall.bundesbrandschatzamt.de 1170; Body=3 Fuz1=3 Fuz2=3 X-SMTP-Vilter-Version: 1.3.6 X-Spamd-Symbols: SPF_PASS,UNPARSEABLE_RELAY Received-SPF: permerror client-ip=198.7.63.95; envelope-from=baron@bundesbrandschatzamt.de; helo=mail.bundesbrandschatzamt.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675443973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MzCELEZAXWuDDHiBGnZtTevyYluktNRCVwA/4mlPDpw=; b=QCvSIGmWsb8UgXKLjut894IiGBzme7bXVs95fEtPo4zmTXmgv5c9wdce+H0ysYZMR8yOw3 ASfknWYHR8vfkLy6OC9PnGwZMHxR1Z2m8XJVwpe16umatv6h+MnCXKDYxC1aZBco7jSb9I V2Ihp6lOAYUOh+6PyHmj143e76vwBYKaX5dJDPUoaGfJ/YyEkhPsYTkt92ELe5VXe2Oumt 5mlWnRN9jKLyTZmMU2bNG8MeyakgkiRQQM8O/+XJfEzwFylQBskzc5qMmCUKFXjY0sik7y 82zObYnnWzIPZHT5xAtJPTOHBAH1ZYzR0v6LydWZDjWu1pTWl1QsGhe75fv2EA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675443973; a=rsa-sha256; cv=none; b=iuPxXSUcekin+sr/w5VaNeLUYfwSanj7TtfZqrF9/8DOwgEtHKYC4NqROMI9FPAQfDJxyf Jla70UNwvYTWnWnsIoDzwL/+emIaD+eMuEZA/mwHdwNtJpbcvBqf6PnWNQOuOau14duN18 YAk7NFj5IIQtOnG7ywPW/EiEY9xhYsY2z5GLX+yU7C15wCKXtabeo4BuFyyHefkr4ycTIg RNS9DSpxpU1vRUlfhl6krzSeZMjtDZVCSIpOkSIti9Y11mJuhiedoTbspqyHY29Dam96hg sHcjuXi1r8tS3utZKtV6BxaEXW+8nqh4bffHwYXEg+mSiRrmR8oROvePvUq+xg== X-Migadu-Queue-Id: 551FF1BBBD X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.18 X-Spam-Score: -3.18 X-TUID: HcgwYhA7nPcG Hi Ihor, way too busy right now. As soon as I find some time I=E2=80=99ll rework that change. Might take a we= ek or two. so long... Andreas Gerler > On Jan 27, 2023, at 2:11 PM, Ihor Radchenko wrote: >=20 > =EF=BB=BFAndreas Gerler writes: >=20 >> +(defcustom org-babel-eval-error-display-notify nil >> + "Display org-babel-eval-errors always or only if exit code is not 0." >=20 > This docstring is confusing. What will happen if the value is nil? > non-nil? I cannot answer these questions by reading the docstring. >=20 > Also, what is "org-babel-eval-errors"? Symbol? >=20 > Finally, I do not think that "nil" is a good default here. It is better > to display warnings by default and let people disable them only > consciously, when needed. Ideally, we may allow the value to be a list > of backends where to display/not display the warnings. >=20 >> + :group 'org-babel >> + :version "29.1" >=20 > Please use :package-version instead. >=20 > And add the new customization to etc/ORG-NEWS. >=20 > --=20 > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at . > Support Org development at , > or support my work at >=20