From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: Bug: Getting property ALLTAGS always returns nil [6.33trans (release_6.33f.130.gb8e0)] Date: Mon, 18 Jan 2010 08:30:30 +0100 Message-ID: References: <873a248mf0.wl%maus.david@gmail.com> <87zl4c75jg.wl%maus.david@gmail.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWm4S-0007Cz-9i for emacs-orgmode@gnu.org; Mon, 18 Jan 2010 02:30:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWm4N-0007CA-3w for emacs-orgmode@gnu.org; Mon, 18 Jan 2010 02:30:43 -0500 Received: from [199.232.76.173] (port=36674 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWm4L-0007Bz-Mm for emacs-orgmode@gnu.org; Mon, 18 Jan 2010 02:30:38 -0500 Received: from postduif.ic.uva.nl ([145.18.40.180]:47970) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWm4L-0007B3-7v for emacs-orgmode@gnu.org; Mon, 18 Jan 2010 02:30:37 -0500 In-Reply-To: <87zl4c75jg.wl%maus.david@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org On Jan 17, 2010, at 11:03 PM, David Maus wrote: > And replying to myself: > > The problem seems to be that some if-clauses in `org-entry-properties' > are not right: > > - when requesting the ALLTAGS property, the code that adds its value > to the alist did not check if the variable `specific' is > "ALLTAGS", but "TAGS" > > - when requesting the BLOCKED property, the code that adds its value > to the alist did not check if the variable `specific' is > "BLOCKED", but "TAGS" > > So requesting one of those properties explicitly didn't work. > > I attached three patches for org.el. Patch 0001 fixes a type in the > docstring of `org-entry-properties', patch 0002 modifies the if-clause > for the ALLTAGS property to check if `special' is "ALLTAGS" and patch > 0003 modifies the if-clause for the BLOCKED property and adds BLOCKED > to the list of properties that are excluded if user requests all or > standard properties. > > Hope I got it right and understood the logic in this function. Yes you did. There were really important fixes for quite stupid bugs, thanks a lot! - Carsten