emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: David Maus <maus.david@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: Bug: Getting property ALLTAGS always returns nil [6.33trans (release_6.33f.130.gb8e0)]
Date: Mon, 18 Jan 2010 08:30:30 +0100	[thread overview]
Message-ID: <EF67AE5F-ABA4-4604-9F38-3D11B1C113DA@gmail.com> (raw)
In-Reply-To: <87zl4c75jg.wl%maus.david@gmail.com>


On Jan 17, 2010, at 11:03 PM, David Maus wrote:

> And replying to myself:
>
> The problem seems to be that some if-clauses in `org-entry-properties'
> are not right:
>
> - when requesting the ALLTAGS property, the code that adds its value
>   to the alist did not check if the variable `specific' is  
> "ALLTAGS", but "TAGS"
>
> - when requesting the BLOCKED property, the code that adds its value
>   to the alist did not check if the variable `specific' is  
> "BLOCKED", but "TAGS"
>
> So requesting one of those properties explicitly didn't work.
>
> I attached three patches for org.el. Patch 0001 fixes a type in the
> docstring of `org-entry-properties', patch 0002 modifies the if-clause
> for the ALLTAGS property to check if `special' is "ALLTAGS" and patch
> 0003 modifies the if-clause for the BLOCKED property and adds BLOCKED
> to the list of properties that are excluded if user requests all or
> standard properties.
>
> Hope I got it right and understood the logic in this function.

Yes you did.  There were really important fixes for quite
stupid bugs, thanks a lot!

- Carsten

      reply	other threads:[~2010-01-18  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-17 21:13 Bug: Getting property ALLTAGS always returns nil [6.33trans (release_6.33f.130.gb8e0)] David Maus
2010-01-17 22:03 ` David Maus
2010-01-18  7:30   ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EF67AE5F-ABA4-4604-9F38-3D11B1C113DA@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=maus.david@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).