From: "Jan Lübke" <jan.luebke@luebke-wohnen.de>
To: emacs-orgmode@gnu.org
Subject: Re: org-mac-link patch
Date: Wed, 9 Dec 2020 15:01:49 +0100 [thread overview]
Message-ID: <EEF91014-D2F3-49C2-85E7-EF212442D9D5@luebke-wohnen.de> (raw)
In-Reply-To: <F30B342B-77BC-400C-AF52-9333CD3954A5@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
Good morning,
this is my first time submitting a patch, here. I hope I did everything right. If I made a mistake, please let me know. If you have any questions, feel free to ask.
Not sure if this is even an official bug, yet. However here is a fix for a strange behaviour: Links to mail.app don’t open any more after upgrading to macOS 11.
Thank you for making orgmode!
Jan Lübke
[-- Attachment #2: 0001-contrib-module-org-mac-link.el-open-links-from-Mail..patch --]
[-- Type: application/octet-stream, Size: 1396 bytes --]
From 05ddec9035bcb45dfa0c1bbcae5f74ca6180065b Mon Sep 17 00:00:00 2001
From: raumi75 <@raumi75>
Date: Wed, 9 Dec 2020 09:31:01 +0100
Subject: [PATCH] contrib module org-mac-link.el/open links from Mail.app: fix
compatibility issue with macOS 11 Big Sur.
* org-mac-link.el (org-mac-message-open): replaced angular brackets with encoded version (< to %3C and > to %3E) so macOS 11 Big Sur can open the message in mail.app
TINYCHANGE macOS 11 does not open the mail link with angular brackets any more. This fix is backwards compatible. I have tested it on macOS 10.15.7.
---
contrib/lisp/org-mac-link.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index d16190e5a..e692acb3e 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -912,7 +912,7 @@ selected items in DEVONthink Pro Office and make link(s) out of it/them."
"Visit the message with MESSAGE-ID.
This will use the command `open' with the message URL."
(start-process (concat "open message:" message-id) nil
- "open" (concat "message://<" (substring message-id 2) ">")))
+ "open" (concat "message://%3C" (substring message-id 2) "%3E")))
(defun org-as-get-selected-mail ()
"AppleScript to create links to selected messages in Mail.app."
--
2.29.2
next parent reply other threads:[~2020-12-09 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F30B342B-77BC-400C-AF52-9333CD3954A5@gmx.de>
2020-12-09 14:01 ` Jan Lübke [this message]
2020-12-11 4:30 ` org-mac-link patch Kyle Meyer
[not found] <27B86020-32B1-4DBA-94CE-EA5A52E07DD3@luebke-wohnen.de>
2020-12-16 5:49 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EEF91014-D2F3-49C2-85E7-EF212442D9D5@luebke-wohnen.de \
--to=jan.luebke@luebke-wohnen.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).