emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH 2/3] Provide customization variable `org-clone-delete-id'.
Date: Wed, 19 May 2010 23:35:20 +0200	[thread overview]
Message-ID: <EDBACE58-30A9-47D6-8B79-0F7980DC3EDF@gmail.com> (raw)
In-Reply-To: <1274295207-4961-2-git-send-email-dmaus@ictsoc.de>

Hi David, do you have these patches on a branch?

Thanks!

- Carsten

On May 19, 2010, at 8:53 PM, David Maus wrote:

> When non-nil, clones of a subtree don't inherit the ID property.
> Otherwise they do and it will be set to a new unique identifier.
> ---
> lisp/ChangeLog |    3 +++
> lisp/org.el    |   16 ++++++++++++++--
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index ec2fa36..ba65761 100644
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -4,6 +4,9 @@
> 	when cache was cleared.
> 	(org-clone-subtree-with-time-shift): Maybe create ID property
> 	in cloned subtrees.
> +	(org-clone-delete-id): New customization variable.
> +	(org-clone-subtree-with-time-shift): Use customization
> +	variable `org-clone-delete-id'.
>
> 2010-05-17  Carsten Dominik  <carsten.dominik@gmail.com>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 64da60a..88d636d 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -105,6 +105,13 @@
> (require 'org-footnote)
>
> ;;;; Customization variables
> +(defcustom org-clone-delete-id nil
> +  "Remove ID property of clones of a subtree.
> +When non-nil, clones of a subtree don't inherit the ID property.
> +Otherwise they inherit the ID property with a new unique
> +identifier."
> +  :type 'boolean
> +  :group 'org-id)
>
> ;;; Version
>
> @@ -7204,13 +7211,18 @@ and still retain the repeater to cover  
> future instances of the task."
> 			   (with-temp-buffer
> 			     (insert template)
> 			     (org-mode)
> -			     (org-id-get-create t)
> +			     (goto-char (point-min))
> +			     (if org-clone-delete-id
> +				 (org-entry-delete nil "ID")
> +			       (org-id-get-create t))
> 			     (buffer-string))))
> 	    (with-temp-buffer
> 	      (insert template)
> 	      (org-mode)
> 	      (goto-char (point-min))
> -	      (if idprop (org-id-get-create t))
> +	      (and idprop (if org-clone-delete-id
> +			      (org-entry-delete nil "ID")
> +			    (org-id-get-create t)))
> 	      (while (re-search-forward org-ts-regexp-both nil t)
> 		(org-timestamp-change (* n shift-n) shift-what))
> 	      (unless (= n n-no-remove)
> -- 
> 1.7.1
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

  reply	other threads:[~2010-05-19 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 18:53 [PATCH 0/2] org.el: Customize subtree cloning + remove empty property drawer after cloning David Maus
2010-05-19 18:53 ` [PATCH 2/3] Provide customization variable `org-clone-delete-id' David Maus
2010-05-19 21:35   ` Carsten Dominik [this message]
2010-05-20  5:48     ` David Maus
2010-05-19 18:53 ` [PATCH 3/3] Remove empty property drawers in cloned subtrees David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EDBACE58-30A9-47D6-8B79-0F7980DC3EDF@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=dmaus@ictsoc.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).