emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* docstring typoes in org-read-date-force-compatible-dates
@ 2019-01-04  1:11 Van L
  2019-01-04  1:47 ` Kyle Meyer
  0 siblings, 1 reply; 4+ messages in thread
From: Van L @ 2019-01-04  1:11 UTC (permalink / raw)
  To: Org Mode Mailing List

Hello,

I found and fixed the following typoes.

diff --git a/lisp/org.el b/lisp/org.el
index 5dd5c024d..755c190cf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3329,7 +3329,7 @@ Depending on the system Emacs is running on, certain dates cannot
 be represented with the type used internally to represent time.
 Dates between 1970-1-1 and 2038-1-1 can always be represented
 correctly.  Some systems allow for earlier dates, some for later,
-some for both.  One way to find out it to insert any date into an
+some for both.  One way to find out is to insert any date into an
 Org buffer, putting the cursor on the year and hitting S-up and
 S-down to test the range.
 
@@ -3337,7 +3337,7 @@ When this variable is set to t, the date/time prompt will not let
 you specify dates outside the 1970-2037 range, so it is certain that
 these dates will work in whatever version of Emacs you are
 running, and also that you can move a file from one Emacs implementation
-to another.  WHenever Org is forcing the year for you, it will display
+to another.  Whenever Org is forcing the year for you, it will display
 a message and beep.
 
 When this variable is nil, Org will check if the date is

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: docstring typoes in org-read-date-force-compatible-dates
  2019-01-04  1:11 docstring typoes in org-read-date-force-compatible-dates Van L
@ 2019-01-04  1:47 ` Kyle Meyer
  2019-01-04  2:36   ` time range, timestamps // was: " Van L
  0 siblings, 1 reply; 4+ messages in thread
From: Kyle Meyer @ 2019-01-04  1:47 UTC (permalink / raw)
  To: Van L, Org Mode Mailing List

Van L <van@scratch.space> writes:

> Hello,
>
> I found and fixed the following typoes.
>
> diff --git a/lisp/org.el b/lisp/org.el

Thank you.  I've applied your changes.  In the future, please send
generated patches with git format-patch so that they include a commit
message (see <https://orgmode.org/worg/org-contribute.html#org31412be>
for instructions).

-- 
Kyle

^ permalink raw reply	[flat|nested] 4+ messages in thread

* time range, timestamps // was: docstring typoes in org-read-date-force-compatible-dates
  2019-01-04  1:47 ` Kyle Meyer
@ 2019-01-04  2:36   ` Van L
  2019-01-05 17:43     ` Kyle Meyer
  0 siblings, 1 reply; 4+ messages in thread
From: Van L @ 2019-01-04  2:36 UTC (permalink / raw)
  To: Kyle Meyer; +Cc: Org Mode Mailing List


> Kyle Meyer wrote:
> 
> In the future, please send
> generated patches with git format-patch so that they include a commit
> message (see <https://orgmode.org/worg/org-contribute.html#org31412be>
> for instructions).

Thanks Kyle. Noted.

I am muddling my way through

 [info:org#Creating timestamps]
 [info:org#The date/time prompt]

and see that org-evaluate-time-range does nothing for

<2019-01-04 Fri 11:00-12:15>

which was created using the “11am+2:15” style from

— quote
   You can specify a time range by giving start and end times or by
giving a start time and a duration (in HH:MM format).  Use one or two
dash(es) as the separator in the former case and use ’+’ as the
separator in the latter case, e.g.:

     11am-1:15pm    ⇒ 11:00-13:15
     11am--1:15pm   ⇒ same as above
     11am+2:15      ⇒ same as above

   Parallel to the minibuffer prompt, a calendar is popped up(2).  When
you exit the date prompt,
— quote ends

exporting that to ASCII in a buffer transforms the time range to

<2019-01-04 Fri 11:00>–<2019-01-04 Fri 12:15>

Now, that formatting put back in the Org buffer does work for org-evaluate-time-range, as follows:

<2019-01-04 Fri 12:34>-<2019-01-04 Fri 12:35> 00:01

;; Using the C-u C-c C-y

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: time range, timestamps // was: docstring typoes in org-read-date-force-compatible-dates
  2019-01-04  2:36   ` time range, timestamps // was: " Van L
@ 2019-01-05 17:43     ` Kyle Meyer
  0 siblings, 0 replies; 4+ messages in thread
From: Kyle Meyer @ 2019-01-05 17:43 UTC (permalink / raw)
  To: Van L; +Cc: Org Mode Mailing List

Van L <van@scratch.space> writes:

[...]

> I am muddling my way through
>
>  [info:org#Creating timestamps]
>  [info:org#The date/time prompt]
>
> and see that org-evaluate-time-range does nothing for
>
> <2019-01-04 Fri 11:00-12:15>

It looks like org-evaluate-time-range uses org-at-date-range-p, which
matches only the timestamp--timestamp range style.  I'd guess that the
easiest way to make org-evaluate-time-range support the single timestamp
range variant would be to update it to use the org-element api (e.g.,
org-element-context reports the above timestamp as :type active-range).

-- 
kyle

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-05 17:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-04  1:11 docstring typoes in org-read-date-force-compatible-dates Van L
2019-01-04  1:47 ` Kyle Meyer
2019-01-04  2:36   ` time range, timestamps // was: " Van L
2019-01-05 17:43     ` Kyle Meyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).