emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Mark Barton <mbarton98@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Bug: tab key no longer bound to org-cycle in commit 565361eb69 [9.4.6 (9.4.6-10-gee652a-elpaplus @ /Users/bartm002/.emacs.d/elpa/org-plus-contrib-20210705/)]
Date: Wed, 7 Jul 2021 21:18:27 -0700	[thread overview]
Message-ID: <E2C88A05-A498-4CE2-9DDE-59E746672D11@gmail.com> (raw)
In-Reply-To: <87lf6itfg2.fsf@nicolasgoaziou.fr>

So I put back the mapping in org-key.el to map TAB instead of <tab> in my local copy and instead commented out line 185 in outline.el to get TAB to map to org-cycle.

——snippet from outline.el
(defvar outline-mode-cycle-map
  (let ((map (make-sparse-keymap)))
    (let ((tab-binding `(menu-item
                         "" outline-cycle
                         ;; Only takes effect if point is on a heading.
                         :filter ,(lambda (cmd)
                                    (when (outline-on-heading-p) cmd)))))
      (define-key map [tab]       tab-binding)
      (define-key map (kbd "TAB") tab-binding)
      (define-key map (kbd "<backtab>") #'outline-cycle-buffer))
  "Keymap used by `outline-mode-map' and `outline-minor-mode-cycle'.")

Does that sound like the right thing to do? If so then I could submit it to the Emacs dev list.

I don’t see outline as a minor mode listed when I use C-h m while in an org file expecting org-cycle.

> On Jul 7, 2021, at 6:35 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>> On Tuesday,  6 Jul 2021 at 18:05, Mark Barton wrote:
>>> I normally use C-RET to enter a new headline and then press TAB to
>>> make it child headline. Recently it stopped working and I think I have
>>> it tracked down to the change that was made last week. I could be
>>> missing something that allows “TAB” to work for a kdb binding, but the
>>> previous format of "<tab>" works.
>> I've also found TAB no longer moving from cell to cell in tables.  I use
>> evil and now TAB (translated from <tab> according to C-h c) is bound to
>> evil-jump-forward.  The only change in my environment has been updating
>> org.
> Binding <tab> is frowned upon, because it has higher priority than TAB,
> and also because it doesn't work everywhere, like in terminals.
> If TAB doesn't work properly in Org, then something, e.g., a minor mode
> (Evil in the second case), is stealing the binding. I guess you have to
> reclaim it back.
> Please see (and answer there)
> <https://orgmode.org/list/00ca1c7b-1e1d-fc91-eef3-dfc29b51b825@daniel-mendler.de/>
> Regards,
> -- 
> Nicolas Goaziou

  parent reply	other threads:[~2021-07-08  4:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  1:05 Bug: tab key no longer bound to org-cycle in commit 565361eb69 [9.4.6 (9.4.6-10-gee652a-elpaplus @ /Users/bartm002/.emacs.d/elpa/org-plus-contrib-20210705/)] Mark Barton
2021-07-07 12:23 ` Eric S Fraga
2021-07-07 13:35   ` Nicolas Goaziou
2021-07-07 14:11     ` Eric S Fraga
2021-07-08  4:18     ` Mark Barton [this message]
2021-07-08  8:47       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E2C88A05-A498-4CE2-9DDE-59E746672D11@gmail.com \
    --to=mbarton98@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).