emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bruno Barbier <perso.bruno.barbier@free.fr>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-babel-comint-with-output: incorrect prompt detection [9.6-pre]
Date: Fri, 11 Nov 2022 09:39:18 +0100	[thread overview]
Message-ID: <E1otPTW-0006wC-Jt@lists.gnu.org> (raw)
In-Reply-To: <87sfiq9r75.fsf@localhost>

Ihor Radchenko <yantar92@posteo.net> writes:

> The problem is that Bash can send incoming text like
>
> "prompt> " "prompt> " "prompt> output\n".
>
> "prompt> prompt> prompt> output\n".

Yes. And I've seen these "outputs" with ob-haskell too ...

>
> So, we cannot reliably distinguish your case from other possibly comint
> quirks based on newline.
>
> One possible fix could be replacing `comint-prompt-regexp' one more time
> at the very end in addition to `org-babel-comint-prompt-separator'.

If I understand correctly, you suggest to do one last replace on the whole
text (buffer-string). But, for ob-haskell, the current prompt regex is:
     "^[[:alnum:].*_() |λ]*> "
     
(it starts with "^")

> We must also make `comint-prompt-regexp' more precise to avoid "lude> "
> being detected as a prompt.
If we need to do that for ob-haskell (when relying on the interpreter),
the cleanest way might be to redefine the set of possible prompts. ghci
is quite flexible:
      GHCi, version 8.10.7

   :set prompt <prompt>        set the prompt used in GHCi
   :set prompt-cont <prompt>   set the continuation prompt used in GHCi
   :set prompt-function <expr> set the function to handle the prompt
   :set prompt-cont-function <expr>
                               set the function to handle the continuation prompt

I'll keep thinking about how to solve this.

Do we have common design principles and/or generic tests that all
languages based on org-babel/ob-comint must pass ?


Thanks Ihor!

Bruno




>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-11-11  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 20:34 [BUG] org-babel-comint-with-output: incorrect prompt detection [9.6-pre] Bruno Barbier
2022-11-11  2:10 ` Ihor Radchenko
2022-11-11  8:39   ` Bruno Barbier [this message]
2022-11-13  3:57     ` Ihor Radchenko
2022-12-12 11:59   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1otPTW-0006wC-Jt@lists.gnu.org \
    --to=perso.bruno.barbier@free.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).