From: Carsten Dominik <carsten.dominik@gmail.com>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Re: [BUG] nested blocks aren't protected on export
Date: Mon, 28 Jun 2010 18:21:31 +0200 [thread overview]
Message-ID: <DE7399D3-4C34-48D1-85C5-4BE0996C4EDB@gmail.com> (raw)
In-Reply-To: <87wrtjb3mc.fsf@gmail.com>
On Jun 28, 2010, at 5:04 PM, Eric Schulte wrote:
> Hi Carsten,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
> [...]
>>
>> The above patch looks definitely right to me. In fact, I think the
>> org-if-unprotected should be around the entire content of the while
>> loop - with an additional fix to make sure search is resumed not
>> from the beginning of location of a match that has not been
>> processed,
>> that would create in infinite loop.
>>
>
> Great, I've just applied this patch with the fix you described.
>
>>
>>>
>>> From d422f564163e37c51d0727e2992b24b85caf54ea Mon Sep 17 00:00:00
>>> 2001
>>> From: Eric Schulte <schulte.eric@gmail.com>
>>> Date: Sun, 27 Jun 2010 19:36:14 -0700
>>> Subject: [PATCH 2/2] org-latex: check for protection before wrapping
>>> ": " lines as verbatim
> [...]
>>
>> I am not quite certain why this second patch is needed?
>>
>
> This second patch ensures that we do not nest verbatim environments on
> latex export, for example w/o this patch the following org-mode
>
> --8<---------------cut here---------------start------------->8---
> #+begin_src org
> ,* escaped org-mode markup
>
> ,this should be exported as is
> ,#+results: escaping-example
> ,: 24
> #+end_src
> --8<---------------cut here---------------end--------------->8---
>
> exports to the following LaTeX
>
> --8<---------------cut here---------------start------------->8---
> \begin{verbatim}
> * escaped org-mode markup
>
> this should be exported as is
> #+results: escaping-example
> \begin{verbatim}
> 24
> \end{verbatim}
>
> \end{verbatim}
> --8<---------------cut here---------------end--------------->8---
>
> I'll wait to hear from you before doing anything with this second
> patch.
For now I don't see anything wrong with this. The fastest
way to find out is to put it into master and watch the list :-)
Please go ahead and do that.
Thanks.
- Carsten
next prev parent reply other threads:[~2010-06-28 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 2:18 [BUG] nested blocks aren't protected on export Eric Schulte
2010-06-28 2:42 ` Eric Schulte
2010-06-28 6:37 ` Carsten Dominik
2010-06-28 15:04 ` Eric Schulte
2010-06-28 16:21 ` Carsten Dominik [this message]
2010-06-28 18:40 ` Eric Schulte
2010-06-28 19:59 ` Eric Schulte
2010-06-29 4:32 ` Carsten Dominik
2010-06-29 5:09 ` Eric Schulte
2010-06-28 15:07 ` Nicolas Goaziou
2010-06-28 15:30 ` Eric Schulte
2010-06-28 17:04 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE7399D3-4C34-48D1-85C5-4BE0996C4EDB@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).