Re: [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps

["Gustav Wikström" <gustav@whil.se>]

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

Hi,

Taking your comments and improving the first patch a bit resulted in the attached one. It replaces the previous. Using string-prefix-p and string-suffix-p solves the out of index problem in the substrings.

BR
Gustav 

> -----Original Message-----
> From: Nicolas Goaziou [mailto:mail@nicolasgoaziou.fr]
> Sent: Wednesday, November 25, 2015 15:53
> To: Gustav Wikström <gustav@whil.se>
> Cc: emacs-orgmode@gnu.org; sgeorgii . <sgeorgii@gmail.com>
> Subject: Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and
> regexps
> 
> Gustav Wikström <gustav@whil.se> writes:
> 
> > Hmm, since the error was thrown when trying to look at indexes outside
> > of the string in (substring ... ), I don't see how isregexp can be
> > left as is. We have to make sure the substring-code is not evaluated
> > if the tag is empty. What am I missing?
> 
> Nothing, I was clear as mud.
> 
>   (cond
>    ((string= "" tag) (setq f1 '(not tags)))
>    ((and (equal "{" ...)
>          (equal "}"...))
>     ...)
>    (t ...))
> 
> Or even
> 
>  ((and (string-prefix-p "{" ...)
>        (string-suffix-p "}" ...)))
> 
> on master.
> 
> Regards,

[-- Attachment #2: 0001-org-agenda-Filter-empty-tags.patch --]
[-- Type: application/octet-stream, Size: 1321 bytes --]

From e5a86a3e89f5d624945b2f5b563c6e9c4aa95cbc Mon Sep 17 00:00:00 2001
From: Gustav Wikstrom <gustav.erik@gmail.com>
Date: Wed, 25 Nov 2015 13:06:31 +0100
Subject: [PATCH] org-agenda: Filter empty tags

* lisp/org-agenda.el (org-agenda-filter-make-matcher-tag-exp): Deal with
  the case when the user provided an empty string to filter or exclude
  rows from the agenda.

  This is done in order to fix a problem reported in emacs-orgmode
  mailing list 2015-11-25 02:50 with subject "[O] [RFC] [PATCH] Changes
  to Tag groups - allow nesting and regexps".
---
 lisp/org-agenda.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 27ca20c..93c6bf8 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7636,10 +7636,12 @@ switches in the returned form."
   (let (f f1) ;f = return expression. f1 = working-area
     (dolist (x tags)
       (let* ((tag (substring x 1))
-	     (isregexp (and (equal "{" (substring tag 0 1))
-			    (equal "}" (substring tag -1))))
+	     (isregexp (and (string-prefix-p "{" tag)
+			    (string-suffix-p "}" tag)))
 	     regexp)
 	(cond
+	 ((string= "" tag)
+	  (setq f1 '(not tags)))
 	 (isregexp
 	  (setq regexp (substring tag 1 -1))
 	  (setq f1 (list 'org-match-any-p regexp 'tags)))
-- 
1.9.5.msysgit.1