From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Remove redundant "Select link" prompt in C-c C-o Date: Tue, 8 Sep 2009 08:05:22 +0200 Message-ID: References: <87hbve2ur4.fsf@bzg.ath.cx> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mktr3-0005W8-UC for emacs-orgmode@gnu.org; Tue, 08 Sep 2009 02:07:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mktqy-0005Vg-UZ for emacs-orgmode@gnu.org; Tue, 08 Sep 2009 02:07:01 -0400 Received: from [199.232.76.173] (port=41921 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mktqy-0005Vd-PB for emacs-orgmode@gnu.org; Tue, 08 Sep 2009 02:06:56 -0400 Received: from mail-bw0-f220.google.com ([209.85.218.220]:45354) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mktqy-0002vQ-AI for emacs-orgmode@gnu.org; Tue, 08 Sep 2009 02:06:56 -0400 Received: by mail-bw0-f220.google.com with SMTP id 20so330876bwz.42 for ; Mon, 07 Sep 2009 23:06:56 -0700 (PDT) In-Reply-To: <87hbve2ur4.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org OK to this change as well. - Carsten On Sep 8, 2009, at 1:35 AM, Bastien wrote: > Since the minibuffer already prompts the user to select a link > when C-c C-o triggers a choice, no need to prompt this again in > the temporary window. > > Objections? > > diff --git a/lisp/org.el b/lisp/org.el > index b58cacc..39ef466 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -8094,7 +8094,6 @@ there is one, offer it as link number zero." > (save-window-excursion > (delete-other-windows) > (with-output-to-temp-buffer "*Select Link*" > - (princ "Select link\n\n") > (mapc (lambda (l) > (if (not (string-match org-bracket-link-regexp l)) > (princ (format "[%c] %s\n" (incf cnt) > > -- > Bastien > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode