emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bastien <bastienguerry@googlemail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Remove redundant "Select link" prompt in C-c C-o
Date: Tue, 8 Sep 2009 08:05:22 +0200	[thread overview]
Message-ID: <D5A1C1E1-EEE8-4F9D-B66B-86EF7CEF6F99@gmail.com> (raw)
In-Reply-To: <87hbve2ur4.fsf@bzg.ath.cx>

OK to this change as well.

- Carsten

On Sep 8, 2009, at 1:35 AM, Bastien wrote:

> Since the minibuffer already prompts the user to select a link
> when C-c C-o triggers a choice, no need to prompt this again in
> the temporary window.
>
> Objections?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index b58cacc..39ef466 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -8094,7 +8094,6 @@ there is one, offer it as link number zero."
> 	(save-window-excursion
> 	  (delete-other-windows)
> 	  (with-output-to-temp-buffer "*Select Link*"
> -	    (princ "Select link\n\n")
> 	    (mapc (lambda (l)
> 		    (if (not (string-match org-bracket-link-regexp l))
> 			(princ (format "[%c]  %s\n" (incf cnt)
>
> -- 
> Bastien
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2009-09-08  6:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 23:35 Remove redundant "Select link" prompt in C-c C-o Bastien
2009-09-08  6:05 ` Carsten Dominik [this message]
2009-09-08  3:13   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D5A1C1E1-EEE8-4F9D-B66B-86EF7CEF6F99@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=bastienguerry@googlemail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).