problem with org-refile remains in 5.20

problem with org-refile remains in 5.20

[Jost Burkardt]

Hi, 

org-refile still does not work correctly for me. it seems that the
refiling-bug from 5.19 still remains in 5.20. When refiling the entry
"something to refile to Project/A/Notes" to "Project/A/Notes",
org-refile sitll puts it to "Project/B/Notes" instead to "Project/A/Notes"


----- BEGIN TEST.org ---
* Stuff
** something to refile to Project/A/Notes
* Projects
** A
*** Notes
** B
*** Notes
----- END TEST.org -----

--
 Jost

Re: problem with org-refile remains in 5.20

[Carsten Dominik]

I cannot reproduce this problem anymore, it works fine for me.
Could someone else please try?

- Carsten

On Feb 6, 2008, at 8:23 PM, Jost Burkardt wrote:

> Hi,
>
> org-refile still does not work correctly for me. it seems that the
> refiling-bug from 5.19 still remains in 5.20. When refiling the entry
> "something to refile to Project/A/Notes" to "Project/A/Notes",
> org-refile sitll puts it to "Project/B/Notes" instead to "Project/A/ 
> Notes"
>
>
> ----- BEGIN TEST.org ---
> * Stuff
> ** something to refile to Project/A/Notes
> * Projects
> ** A
> *** Notes
> ** B
> *** Notes
> ----- END TEST.org -----
>
> --
> Jost

Re: problem with org-refile remains in 5.20

[Jost Burkardt]

I think the reason, I get this behaviour is the following code in
org-refile:
...
(goto-char (or (save-excursion
		 (if reversed
		     (outline-next-heading)
		   (outline-get-next-sibling)))
	       (point-max))) 
...

before org-refile moves the point to the correct position, as I have not
set `reversed', outline-get-next-sibling is called, as there is no
sibling to "*** Notes" the point is moved to "** B", but the call
returns nil, so finally (point-max) moves to the end of the file.

So the similar "*** Notes"-item below Project B was misleading me. Can
you reproduce this one? 

I tested it on:
GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0) of 2007-12-31 on wodka
Org-mode version 5.21

--
 Jost

Carsten Dominik <dominik@science.uva.nl> writes:

> I cannot reproduce this problem anymore, it works fine for me.
> Could someone else please try?
>
> - Carsten
>
> On Feb 6, 2008, at 8:23 PM, Jost Burkardt wrote:
>
>> Hi,
>>
>> org-refile still does not work correctly for me. it seems that the
>> refiling-bug from 5.19 still remains in 5.20. When refiling the entry
>> "something to refile to Project/A/Notes" to "Project/A/Notes",
>> org-refile sitll puts it to "Project/B/Notes" instead to "Project/A/
>> Notes"
>>
>>
>> ----- BEGIN TEST.org ---
>> * Stuff
>> ** something to refile to Project/A/Notes
>> * Projects
>> ** A
>> *** Notes
>> ** B
>> *** Notes
>> ----- END TEST.org -----
>>
>> --
>> Jost
>
>

Re: problem with org-refile remains in 5.20

[Carsten Dominik]

On Feb 7, 2008, at 7:39 PM, Jost Burkardt wrote:

>
> I think the reason, I get this behaviour is the following code in
> org-refile:
> ...
> (goto-char (or (save-excursion
> 		 (if reversed
> 		     (outline-next-heading)
> 		   (outline-get-next-sibling)))
> 	       (point-max)))
> ...
>
> before org-refile moves the point to the correct position, as I have  
> not
> set `reversed', outline-get-next-sibling is called, as there is no
> sibling to "*** Notes" the point is moved to "** B", but the call
> returns nil, so finally (point-max) moves to the end of the file.


Thanks, I can see it now - I am using reversed notes, so that is why I  
could
not reproduce the problem.

This is fixed in the git repository, will be in the next release.

Thanks for being persistent.

- Carsten